public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Md Danish Anwar <a0501179@ti.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Rob Herring <robh@kernel.org>
Cc: nm@ti.com, srk@ti.com, vigneshr@ti.com,
	devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	MD Danish Anwar <danishanwar@ti.com>,
	"Andrew F . Davis" <afd@ti.com>,
	Roger Quadros <rogerq@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [EXTERNAL] Re: [PATCH v8 1/6] dt-bindings: remoteproc: Add PRU consumer bindings
Date: Fri, 18 Nov 2022 11:18:54 +0530	[thread overview]
Message-ID: <dd1fbe2d-585e-8298-bd36-56b3bd4a9ae1@ti.com> (raw)
In-Reply-To: <20221116180949.GC61935@p14s>

Hi Mathieu,

On 16/11/22 23:39, Mathieu Poirier wrote:
> On Wed, Nov 16, 2022 at 10:09:48AM -0600, Rob Herring wrote:
>> On Wed, Nov 16, 2022 at 05:46:29PM +0530, MD Danish Anwar wrote:
>>> From: Suman Anna <s-anna@ti.com>
>>>
>>> Add DT schema binding for PRU consumers. The binding includes
>>> all the common properties that can be used by different PRU consumer
>>> or application nodes and supported by the PRU remoteproc driver.
>>> These are used to configure the PRU hardware for specific user
>>> applications.
>>>
>>> The application nodes themselves should define their own bindings.
>>>
>>> Co-developed-by: Tero Kristo <t-kristo@ti.com>
>>> Co-developed-by: Suman Anna <s-anna@ti.com>
>>> Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
>>> Co-developed-by: Puranjay Mohan <p-mohan@ti.com>
>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>
>> Run checkpatch.pl and fix the warnings with the tags.
> 
> My bad - I asked Danish to remove the SoBs to lighten the changelog
> presentation.  Danish, do you absolutely need to list everyone that touched that
> patchset?  If so I suppose just listing the SoBs would be a compromise.
> 

I started working on this patch series after version 5. In the first version of
this patch series below were the tags.

Co-developed-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>

I am not sure whom to drop and whom to keep that's why I have been keeping all
the tags that were present from the beginning.

In the next version I'll keep only the SoBs tags of the the people listed above.

>>
>> You didn't add review/ack tags either.
> 
> Those are important.  
> 
> Please send another patchset that clears checkpatch with review/acks and I'll
> look at it.
> 

I am really sorry for that, I was not aware about adding review tags as I am
very new to upstreaming.

I will share new version after fixing checkpatch errors/warnings and adding
review tags.

Thanks,
Danish.

> Thanks,
> Mathieu
> 
>>
>>> ---
>>>  .../bindings/remoteproc/ti,pru-consumer.yaml  | 60 +++++++++++++++++++
>>>  1 file changed, 60 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-11-18  5:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 12:16 [PATCH v8 0/6] Introduce PRU remoteproc consumer API MD Danish Anwar
2022-11-16 12:16 ` [PATCH v8 1/6] dt-bindings: remoteproc: Add PRU consumer bindings MD Danish Anwar
2022-11-16 16:09   ` Rob Herring
2022-11-16 18:09     ` Mathieu Poirier
2022-11-18  5:48       ` Md Danish Anwar [this message]
2022-11-18 18:56         ` [EXTERNAL] " Mathieu Poirier
2022-11-16 12:16 ` [PATCH v8 2/6] remoteproc: pru: Add APIs to get and put the PRU cores MD Danish Anwar
2022-11-16 12:16 ` [PATCH v8 3/6] remoteproc: pru: Add enum for PRU Core Indentifiers MD Danish Anwar
2022-11-16 12:16 ` [PATCH v8 4/6] remoteproc: pru: Make sysfs entries read-only for PRU client driven boots MD Danish Anwar
2022-11-16 12:16 ` [PATCH v8 5/6] remoteproc: pru: Add pru_rproc_set_ctable() function MD Danish Anwar
2022-11-16 12:16 ` [PATCH v8 6/6] remoteproc: pru: Configure firmware based on client setup MD Danish Anwar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd1fbe2d-585e-8298-bd36-56b3bd4a9ae1@ti.com \
    --to=a0501179@ti.com \
    --cc=afd@ti.com \
    --cc=danishanwar@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=srk@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox