From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B879C10F0E for ; Sun, 7 Apr 2019 04:31:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2954620863 for ; Sun, 7 Apr 2019 04:31:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rfEpYQ12"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="UO74W5zh"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="BTqZ48Q3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2954620863 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2/XQ7Qbvwk87Qs22Tmd4lw3Ei+f4F3+vWTxwIChRwjo=; b=rfEpYQ12nZmd20HHpUm7DJBC0 LgWVFtW9XGc3gS8JP4wTgXIbd3bg1XQ3rmzxGKMBIT3SZ2eBU2onQQ9oXDuBFVjA8Gocay6Y+qh7p jv04BYyEu3yltjBStnnmTomLaRUPJagjvMJAK80hKITonkZmZXaqPTpYjNNrzn3id6GjX0HCb3N3e PW4CArj+WcSQwj//oSYz50/7i6ADfeko3NL/EqcXa3VR1XE9lsgFFh5K+zZnmw9ozJiFcQX03Re0H fW+Mmu3l3LNR/2gamzvGzCa08OdXuE66RQDLLGW/SJsTCydRMn8ahLUJYiOdgZrflUpSSAb6/v80m 4f1OD7P3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCzTB-0008Ks-9A; Sun, 07 Apr 2019 04:31:49 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCzT7-0008KB-7L for linux-arm-kernel@lists.infradead.org; Sun, 07 Apr 2019 04:31:46 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7D7FA601B4; Sun, 7 Apr 2019 04:31:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554611503; bh=oNM9tJvVmOTCGt8t+HNwYOiEV7UThcneuW01axOfIs8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=UO74W5zhttclC89EnOPnUaRgZdWj83tp8VMCbVY3H6zIFvHm3oHxatODmpbHgEE0U p3208R5BCjFc6fvX822U2o5ejj9hVtGlDoVBeGhPraoNw1Fv/GZ7Gzlk35TZSBqmaM HTOOHd61KtObd3qYynw9NNrmKeIffTn5nhjE4I9I= Received: from [192.168.43.47] (unknown [27.59.118.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6DB73601B4; Sun, 7 Apr 2019 04:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554611502; bh=oNM9tJvVmOTCGt8t+HNwYOiEV7UThcneuW01axOfIs8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=BTqZ48Q3j1pCFqVEzNmcZjpao42K7aWMfJqPazPtlY7RWj4gMIiE2yOUM/KOMtG4a x5Va+iKgFEQzoEoS0UvgPggQKqzaDX6YnnYzX7MXO7hPwbIWtyVILB+3VECRwbbT5w smV6RYP2tuE/7CKqO+MT60ixuxpHxkPvaqJNMZEk= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6DB73601B4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=saiprakash.ranjan@codeaurora.org Subject: Re: [PATCH] stm class: Fix out of bound access from bitmap allocation To: David Laight , Alexander Shishkin , Greg Kroah-Hartman , Mulu He , Tingwei Zhang , Maxime Coquelin , Alexandre Torgue , "linux-stm32@st-md-mailman.stormreply.com" , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan References: <20190405122256.27840-1-saiprakash.ranjan@codeaurora.org> From: Sai Prakash Ranjan Message-ID: Date: Sun, 7 Apr 2019 10:01:23 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190406_213145_307552_5325EF93 X-CRM114-Status: GOOD ( 15.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rajendra Nayak , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Sibi Sankar , Vivek Gautam , "linux-arm-kernel@lists.infradead.org" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/5/2019 6:44 PM, David Laight wrote: > From: Sai Prakash Ranjan >> >> diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c >> index 93ce3aa740a9..21a5838f6e67 100644 >> --- a/drivers/hwtracing/stm/core.c >> +++ b/drivers/hwtracing/stm/core.c >> @@ -168,7 +168,7 @@ static int stp_master_alloc(struct stm_device *stm, unsigned int idx) >> struct stp_master *master; >> size_t size; >> >> - size = ALIGN(stm->data->sw_nchannels, 8) / 8; >> + size = ALIGN(stm->data->sw_nchannels, STM_MASTER_SZ) / STM_MASTER_SZ; > > I'm not sure that using STP_MASTER_SZ improves readability at all. > I thought it was better to have a macro than directly specifying sizeof(unsigned long), anyways I can change it. > Is there something that gives the size of a bitmap for 'n' items? > Not sure if there is something. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel