From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 298EBC433EF for ; Tue, 22 Mar 2022 13:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S9kUKfNfAy0l/fPvsbjT878Cn4SG887hynpSauP49Fk=; b=firBeCboHF4acl cC5xOBxjSQvdJl4wS3wTwpTYBtPqyJSIwQhiTstMWXXQsTsxRuXk6K5rZuaggywL3FY267Vq8eHzz pPfvXTfe86c0O0ga5SGGsg3nDnAYQT4ntEXuNYXxENU6wH9miHXxjrW+G7SueM9lm7XYHj8UAEXg+ 8cs+FZiFvKqXx5uSAjROOZZB1lD7cFCQA6Sol/PxzW9xWT5lIgHdaDXgdSae6kv1SBNuKoT2m6bya chU8xmjckhp9JQUSqEoR56bBHDdT/rWSAHJKRDN3sASTRnCC58cr/3qIRnflCKRdj9f4l1FblHMbk iGLwm13b57HSpaAwFeoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWef8-00B56B-78; Tue, 22 Mar 2022 13:35:02 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWef3-00B55g-Se for linux-arm-kernel@lists.infradead.org; Tue, 22 Mar 2022 13:34:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 50A5B61591; Tue, 22 Mar 2022 13:34:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 447C8C340EC; Tue, 22 Mar 2022 13:34:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647956096; bh=slpexDXuns1omfJ3pZfc8nfXkY5VkY6iw4Eg1zDo1RA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dd6aK/0uZcHegkgssWUCn7t1h4XjA69qETpa531Ftrk2vE4goNQXlll4vi7XSJXdH SYA5p+7NRsSJ39830KqGFfS9Ktuwr/tibaWTtTMUfI+tSHxacVLgaPJDOyMA4Lp9+4 PgfookCDsObDKc5C0PDT5ENfqNIAK3Th4gdd04EwGe0uvbVIIgQ7a/+NoqzyExpxj/ bs3vGYgFhkKl+oBZx7tPIOv2ZfAFLveInWAS+rsiu06+P9vkJhdGlWUZB82ZXCacJ/ p2Zr64pr3cLqkhnewbMt+c7xOnzGZeTc8RET4WU+FwnNjnVhnvyR+/mHjRDjebB0NI bemMFE7YC5gaQ== Message-ID: Date: Tue, 22 Mar 2022 08:34:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] arm64: dts: n5x: add sdr edac support Content-Language: en-US To: Krzysztof Kozlowski , robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-arm-kernel@lists.infradead.org References: <20220301151238.15836-1-dinguyen@kernel.org> <1217ab63-f441-a757-2864-e1b01ab54349@kernel.org> From: Dinh Nguyen In-Reply-To: <1217ab63-f441-a757-2864-e1b01ab54349@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220322_063458_009805_188EE466 X-CRM114-Status: GOOD ( 21.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/18/22 07:00, Krzysztof Kozlowski wrote: > On 01/03/2022 16:12, Dinh Nguyen wrote: >> The N5X platform has the Synopsys DDR controller the includes an EDAC >> controller. Add the entry for the controller in the DTS file instead of >> the base Agilex DTSI because the base Agilex does not have the >> controller. >> >> Signed-off-by: Dinh Nguyen >> --- >> arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts >> index f3c1310dae0a..628c9943914b 100644 >> --- a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts >> +++ b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts >> @@ -23,6 +23,16 @@ memory { >> /* We expect the bootloader to fill in the reg */ >> reg = <0 0 0 0>; >> }; >> + >> + soc { >> + sdram_edac: sdr_edac@f87f8000 { > > This patch was merged but it is not correct. The node name should be > memory-controller (generic, not specific). > >> + compatible = "snps,ddrc-3.80a"; >> + reg = <0xf87f8000 0x400>; >> + interrupts = <0 175 4>; > > This fails dt schema. > >> + intel,sysmgr-syscon = <&sysmgr 0xb8>; > > This fails schema even more... it's not documented. > >> + status = "okay"; > > This is not needed. > > > Please test your changes against bindings (you can use dtbs_check). > Will do and I'll send a patch to fix this up in a bit. Thanks, Dinh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel