From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F04CFC47258 for ; Tue, 23 Jan 2024 08:11:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Fb2aA7vOVU0Qtsn0VbvL0uMIbwGZ2+BkWIxgHr7HZ/c=; b=Dar1YWk+DNeWVL Nx4GRJTFGHNGvVwD2ikdB2N6rls2mJJyYHT8h2eTBDRxuft9KYbOjVq0oVZzMGonoUHVVETHHL6vn isHrNc/HrpmYJqZLq/bQjgiRmYFFpTKzWxshxX7xEhspABA2wQmDsxIeP/QwYnb5NNRn2z3/ovTKT 4JBSNktHS7/Vy9zWwO0dfZ2WRkljALq7mpwM3+cSnGNoMb1lc8vW0HaavyGJ3C2RL/1keSDgkv8wP 3bZbRWib9JEzoS9SGbOkrnFV2UUFiHOHyNHTHNJOXJKxeH3N8uMUd9VNg+29ME+QZbYLz6DGJoAQu Q7p+01ZbTAFID4Fx0Yxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSBsB-00FUbt-19; Tue, 23 Jan 2024 08:11:07 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSBs5-00FUbN-1x for linux-arm-kernel@lists.infradead.org; Tue, 23 Jan 2024 08:11:06 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E7E053200AC7; Tue, 23 Jan 2024 03:10:58 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 23 Jan 2024 03:11:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1705997458; x=1706083858; bh=8GW7Ys4hJn ST61kBAZS3rGpqnAP7hlhrw5R1Bh3T8ww=; b=kb9tyox9sC8LX4vvUW6Cl3tie5 GEjSeraUi+YDFtWxtzz1dBB49Q7snKx7PRapGHnK559ubVuRf+diSA3Fcxjwwofy rL67E17qTnu8kSkyE/1e2wubWQtNHWPvO3utGUGRB9N830o5EVYv/j51C+4WzhHV +PMSADJ5M5qeMIrC+1EF9NWx+tE8+3O0KCXPWW/hPKHbjVloSoHWcDwzezmghDIW KK+qnjoMW0zNOc8lFmTMYW9Xuu4rhiBDwPJHH9iHU5KjapShGBbCjOm0zEzkhYMw KlLEWBcgflzfCdvv7diRxCR0HQNq6VbywNA1/VIhYHGg4jmMLdDvdTNfEIBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1705997458; x=1706083858; bh=8GW7Ys4hJnST61kBAZS3rGpqnAP7 hlhrw5R1Bh3T8ww=; b=ikD6gGQqdQQJgaZWnkOFLIu9nGcs8/pDgiQd4NCc0cx6 qvYTCMhGlRUm72OQo1KFjzQBa8QHWi/vQm1bBHW3mSfVDrDslDAH0BVB8sedNQSe y9mKr8t6lOc9a/rvxFEkD2z3jtT2orFeZtmCvGO5cnBFZ4V3+fqgNyRUHqsUSFMJ KvU+zPtA1R9AgGtVOIFJbKnzfnqTn8dLDw5Gmr46d6JpMe3CZSRtlzjxz962PVS8 h9VRcL2wJ4ISaPX1xGEWiiYEOTwkvcAqXh1qZzjLGqg4Hk6BS+E1rIgm+tYTD882 0v798k4YNR+UNv74FNPurqeb93NW+JFHhRMQAUfLzg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdekjedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E487FB6008D; Tue, 23 Jan 2024 03:10:57 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-119-ga8b98d1bd8-fm-20240108.001-ga8b98d1b MIME-Version: 1.0 Message-Id: In-Reply-To: <20240122225710.1952066-3-peter.griffin@linaro.org> References: <20240122225710.1952066-1-peter.griffin@linaro.org> <20240122225710.1952066-3-peter.griffin@linaro.org> Date: Tue, 23 Jan 2024 09:10:36 +0100 From: "Arnd Bergmann" To: "Peter Griffin" , "Rob Herring" , krzysztof.kozlowski+dt@linaro.org, "Guenter Roeck" , "Wim Van Sebroeck" , "Conor Dooley" , "Alim Akhtar" , jaewon02.kim@samsung.com, chanho61.park@samsung.com, "Sam Protsenko" Cc: kernel-team@android.com, "Tudor Ambarus" , =?UTF-8?Q?Andr=C3=A9_Draszik?= , saravanak@google.com, "William McVicker" , linux-fsd@tesla.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 2/9] soc: samsung: exynos-pmu: Add exynos_pmu_update/read/write APIs and SoC quirks X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_001101_696993_7FD7B0DD X-CRM114-Status: GOOD ( 11.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 22, 2024, at 23:57, Peter Griffin wrote: > --- a/include/linux/soc/samsung/exynos-pmu.h > +++ b/include/linux/soc/samsung/exynos-pmu.h > @@ -21,11 +21,39 @@ enum sys_powerdown { > extern void exynos_sys_powerdown_conf(enum sys_powerdown mode); > #ifdef CONFIG_EXYNOS_PMU > extern struct regmap *exynos_get_pmu_regmap(void); > +extern int exynos_pmu_update_bits(unsigned int offset, unsigned int > mask, > + unsigned int val); > +extern int exynos_pmu_update(unsigned int offset, unsigned int mask, > + unsigned int val); > +extern int exynos_pmu_write(unsigned int offset, unsigned int val); > +extern int exynos_pmu_read(unsigned int offset, unsigned int *val); > #else > static inline struct regmap *exynos_get_pmu_regmap(void) > { > return ERR_PTR(-ENODEV); > } > + > +static inline int exynos_pmu_update_bits(unsigned int offset, unsigned > int mask, > + unsigned int val); > +{ > + return ERR_PTR(-ENODEV); > +} > + > +static inline int exynos_pmu_update(unsigned int offset, unsigned int > mask, > + unsigned int val); > +{ > + return ERR_PTR(-ENODEV); > +} This won't build since you have the wrong return type. I would suggest you just remove the #ifdef check entirely and instead require drivers using this to have correct dependencies. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel