From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46572C3DA59 for ; Mon, 15 Jul 2024 14:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3Zn/o0vWxJvI8uafBBDslyWACdzZ+2xD3hQW8mRKVxU=; b=AG95RGpai1DaqMt/PCZhpHEmmt K14LYivYVCkkEMBL2RVtMwh0/dJgpl9T5jzLYa8dAhRcvModN0oi6MWAIWF3czRbuBY3fbeoM8Z6D JzKDBQVA7ioKaF6uE26LK0Iqf0jWEyZfQFnHpa/s3QC01QfzRdrr1F9nmCgFN53vtL0yzldVToyoe MhJTLGixuAKMjcFdRASVd+DqWWcCAUPPwDUb3qrcBGhs9MRes97onZf50X87d9kppLOfQ43+ugFGm Ck2Ae2kH70H28SUxFwkIoKbUH05oTO2zUmylxthJKv8pHGjNBqIIMt+Om5Xmzjb/zccsIt0KrFV04 aQyHSaXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTMHH-00000007J3J-1PbJ; Mon, 15 Jul 2024 14:02:07 +0000 Received: from smtp-out1.suse.de ([195.135.223.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTMGb-00000007IpD-22HP; Mon, 15 Jul 2024 14:01:45 +0000 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DE74F21BBE; Mon, 15 Jul 2024 14:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1721052084; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Zn/o0vWxJvI8uafBBDslyWACdzZ+2xD3hQW8mRKVxU=; b=xQNMTknNXhDPj8wSl2RpchGQCVZCMmL86IgH8AA6wiq+e8hprw10ZoOKUexZDbaD9/UxVQ WCSx8QAMS51wdhrjA+rlokIM/LJFp/InRp5HORWqo7L3I2xP5reSIGwplrThhzlG5QV9M0 Eohgg0HuqUYFfV12zhTPysZHg8WRUvg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1721052084; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Zn/o0vWxJvI8uafBBDslyWACdzZ+2xD3hQW8mRKVxU=; b=s96+alHRnsGOJu+qVcpxR42UwIaZakk0kFuVH3/M559MzBvGNrqHeLQU+w+eNyoeRWhgjv TvX6OifyXnQv/qCw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1721052083; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Zn/o0vWxJvI8uafBBDslyWACdzZ+2xD3hQW8mRKVxU=; b=PoxUaKoIOc3p0GhFr6usKFy5dhk6g6kuz5m+nQaXZPumXbBUAzGZSoFm4XoLOuzBhE1b1i +BhEAq+4LWTS5hKdvGHSLXkiFF6YyFDo9XoFFNcbt/Zyi22SVlLiIsIcGsgh4SS0CKib6Y rPNCKtor8pdCPw1vPXF88SI6UfeORuw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1721052083; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Zn/o0vWxJvI8uafBBDslyWACdzZ+2xD3hQW8mRKVxU=; b=5NYjoUQoArWFelRw52kCH0VQ00Fpvg9Mck9JGGZgNTdo4L7WT5CMBAMZaqACgjQi2Uji1N OCW6kM9tBdpPFqAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0F9A9137EB; Mon, 15 Jul 2024 14:01:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SINeAbMrlWaHYAAAD6G6ig (envelope-from ); Mon, 15 Jul 2024 14:01:23 +0000 Message-ID: Date: Mon, 15 Jul 2024 17:01:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 10/12] PCI: brcmstb: Check return value of all reset_control_xxx calls To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Philipp Zabel , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20240710221630.29561-1-james.quinlan@broadcom.com> <20240710221630.29561-11-james.quinlan@broadcom.com> Content-Language: en-US From: Stanimir Varbanov In-Reply-To: <20240710221630.29561-11-james.quinlan@broadcom.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-0.29 / 50.00]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; FREEMAIL_TO(0.00)[broadcom.com,vger.kernel.org,kernel.org,google.com,arm.com,debian.org,suse.de,gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWELVE(0.00)[18]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:email] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_070125_716784_07194E23 X-CRM114-Status: GOOD ( 17.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/11/24 01:16, Jim Quinlan wrote: > In some cases the result of a reset_control_xxx() call have been ignored. > Now we check all return values of such functions and propagate the error to > the next level. > > Signed-off-by: Jim Quinlan > --- > drivers/pci/controller/pcie-brcmstb.c | 100 ++++++++++++++++++-------- > 1 file changed, 71 insertions(+), 29 deletions(-) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index c44a92217855..c334cc427fb7 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -232,8 +232,8 @@ struct pcie_cfg_data { > const enum pcie_type type; > const bool has_phy; > unsigned int num_inbound; > - void (*perst_set)(struct brcm_pcie *pcie, u32 val); > - void (*bridge_sw_init_set)(struct brcm_pcie *pcie, u32 val); > + int (*perst_set)(struct brcm_pcie *pcie, u32 val); > + int (*bridge_sw_init_set)(struct brcm_pcie *pcie, u32 val); > }; > > struct subdev_regulators { > @@ -278,8 +278,8 @@ struct brcm_pcie { > int num_memc; > u64 memc_size[PCIE_BRCM_MAX_MEMC]; > u32 hw_rev; > - void (*perst_set)(struct brcm_pcie *pcie, u32 val); > - void (*bridge_sw_init_set)(struct brcm_pcie *pcie, u32 val); > + int (*perst_set)(struct brcm_pcie *pcie, u32 val); > + int (*bridge_sw_init_set)(struct brcm_pcie *pcie, u32 val); > struct subdev_regulators *sr; > bool ep_wakeup_capable; > bool has_phy; > @@ -742,13 +742,18 @@ static void __iomem *brcm7425_pcie_map_bus(struct pci_bus *bus, > return base + DATA_ADDR(pcie); > } > > -static void brcm_pcie_bridge_sw_init_set_generic(struct brcm_pcie *pcie, u32 val) > +static int brcm_pcie_bridge_sw_init_set_generic(struct brcm_pcie *pcie, u32 val) > { > + int ret = 0; > + > if (pcie->bridge) { > if (val) > - reset_control_assert(pcie->bridge); > + ret = reset_control_assert(pcie->bridge); > else > - reset_control_deassert(pcie->bridge); > + ret = reset_control_deassert(pcie->bridge); > + if (ret) > + dev_err(pcie->dev, "failed to %s 'bridge' reset, err=%d\n", > + val ? "assert" : "deassert", ret); > } else { > u32 tmp, mask = RGR1_SW_INIT_1_INIT_GENERIC_MASK; > u32 shift = RGR1_SW_INIT_1_INIT_GENERIC_SHIFT; > @@ -757,9 +762,10 @@ static void brcm_pcie_bridge_sw_init_set_generic(struct brcm_pcie *pcie, u32 val > tmp = (tmp & ~mask) | ((val << shift) & mask); > writel(tmp, pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); > } In case you sending new version, please add a blank like here. Reviewed-by: Stanimir Varbanov ~Stan > + return ret; > } >