From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E149CAC58C for ; Tue, 9 Sep 2025 17:27:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zVTLuB5mPE9USyd5FN+v1V5IxPuPjuhHqdZpeodUNwI=; b=aOUUeOl+fz6hZE/FLrA8gFncbO gMVjK836eXDGkbm/SazYW1r1XMel/zIN3xu+c84LPvbMOUBlecPz8UstARDBcsqFdQH2mqZ4Fqusu 4RFWtQzeTzlD0v1VrnGoQvKTAKn5+NDTSXtoCt5ifUDGTkQpwGT8k8p9tONkYVxBpBpJGhttx6p4s MkAoEegIsNMi2l4Qn/vqIEfJMuufxd2yVxfqfnDypcHlarNwXzwSYXCZ46TmmrHc6D9Mxofpk0FNi KK9OOvl+8wC8bMtNS0Vpq8U7aHQZ51uySAv4DwOboyh0BXSYDwS6dHFOTPek2uvVFA2o52YssFnit VVs33O9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uw27T-000000096ky-1SCj; Tue, 09 Sep 2025 17:27:03 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uw1fV-00000008hE2-0jt4 for linux-arm-kernel@lists.infradead.org; Tue, 09 Sep 2025 16:58:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4775320E3; Tue, 9 Sep 2025 09:57:55 -0700 (PDT) Received: from [10.1.197.69] (eglon.cambridge.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BD3323F694; Tue, 9 Sep 2025 09:57:57 -0700 (PDT) Message-ID: Date: Tue, 9 Sep 2025 17:57:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 20/33] arm_mpam: Add a helper to touch an MSC from any CPU To: Ben Horgan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org Cc: shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Rex Nie , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250822153048.2287-1-james.morse@arm.com> <20250822153048.2287-21-james.morse@arm.com> <8635e616-79b7-4d7d-a8b8-aa76ba027bc4@arm.com> Content-Language: en-GB From: James Morse In-Reply-To: <8635e616-79b7-4d7d-a8b8-aa76ba027bc4@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250909_095809_263490_00DB7E5E X-CRM114-Status: GOOD ( 13.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ben, On 28/08/2025 17:13, Ben Horgan wrote: > On 8/22/25 16:30, James Morse wrote: >> Resetting RIS entries from the cpuhp callback is easy as the >> callback occurs on the correct CPU. This won't be true for any other >> caller that wants to reset or configure an MSC. >> >> Add a helper that schedules the provided function if necessary. >> Prevent the cpuhp callbacks from changing the MSC state by taking the >> cpuhp lock. > At first, I thought this was referring to something done in the patch. > Consider changing to something like: > > Callers should take the cpuhp lock to prevent the cpuhp callbacks from > changing the MSC state. Yes - that is better, > Regardless, this looks good to me. > > Reviewed-by: Ben Horgan Thanks! James