From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50E8DC433E0 for ; Mon, 25 May 2020 07:20:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C67952065F for ; Mon, 25 May 2020 07:20:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SeR+4lsD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C67952065F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DRYmbifDqygwZxBSwrF7oUrhiF32JOJ4WVhk16qAAV0=; b=SeR+4lsDrn0oHN clROSMrv4xN/akDnHaznk1ti/45DvZTRD1oUxZkYWSy549q2rZ0aeMm8FqTmNTMIvQJCfKPTtDGSo mMIb8KtedcOul8a4sSY37qSdbBpThwsUvPsJW096AjeLAO7rhlJI4hArnJfqEuzq1vGKMKOKhfzOy I52Ftu0FbM+C1YJW0IVYHnRpz9JVNbIGySttxHojMsW1E1SM+/0mx4aawkohkxItcuqBgkiQG1SkD WsreeTleTlKUasc4ka3laZ7h3EldVEAWWM7X2GqhfdQ/XC5K2qzskDG2L7ISSoi6rBZBlZvTNA/M+ 3GbYpEFgU9qLVG8WRxOg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jd7P2-00033u-7Z; Mon, 25 May 2020 07:20:04 +0000 Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jd7Oy-0002eC-IH for linux-arm-kernel@lists.infradead.org; Mon, 25 May 2020 07:20:02 +0000 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 9EC1B2FB3E70016EC513; Mon, 25 May 2020 15:19:52 +0800 (CST) Received: from [127.0.0.1] (10.173.220.25) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Mon, 25 May 2020 15:19:44 +0800 Subject: Re: [PATCH v2 5/6] mm: tlb: Provide flush_*_tlb_range wrappers To: Catalin Marinas References: <20200423135656.2712-1-yezhenyu2@huawei.com> <20200423135656.2712-6-yezhenyu2@huawei.com> <20200522154254.GD26492@gaia> From: Zhenyu Ye Message-ID: Date: Mon, 25 May 2020 15:19:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200522154254.GD26492@gaia> X-Originating-IP: [10.173.220.25] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200525_002000_773898_DBB2541E X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, peterz@infradead.org, linux-mm@kvack.org, guohanjun@huawei.com, will@kernel.org, linux-arch@vger.kernel.org, yuzhao@google.com, aneesh.kumar@linux.ibm.com, steven.price@arm.com, arm@kernel.org, Dave.Martin@arm.com, arnd@arndb.de, suzuki.poulose@arm.com, npiggin@gmail.com, zhangshaokun@hisilicon.com, broonie@kernel.org, rostedt@goodmis.org, prime.zeng@hisilicon.com, kuhn.chenqun@huawei.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, xiexiangyou@huawei.com, linux-kernel@vger.kernel.org, maz@kernel.org, akpm@linux-foundation.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020/5/22 23:42, Catalin Marinas wrote: > On Thu, Apr 23, 2020 at 09:56:55PM +0800, Zhenyu Ye wrote: >> diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c >> index 3d7c01e76efc..3eff199d3507 100644 >> --- a/mm/pgtable-generic.c >> +++ b/mm/pgtable-generic.c >> @@ -101,6 +101,28 @@ pte_t ptep_clear_flush(struct vm_area_struct *vma, unsigned long address, >> >> #ifdef CONFIG_TRANSPARENT_HUGEPAGE >> >> +#ifndef __HAVE_ARCH_FLUSH_PMD_TLB_RANGE >> + >> +#define FLUSH_Pxx_TLB_RANGE(_pxx) \ >> +void flush_##_pxx##_tlb_range(struct vm_area_struct *vma, \ >> + unsigned long addr, unsigned long end) \ >> +{ \ >> + struct mmu_gather tlb; \ >> + \ >> + tlb_gather_mmu(&tlb, vma->vm_mm, addr, end); \ >> + tlb_start_vma(&tlb, vma); \ >> + tlb_flush_##_pxx##_range(&tlb, addr, end - addr); \ >> + tlb_end_vma(&tlb, vma); \ >> + tlb_finish_mmu(&tlb, addr, end); \ >> +} > > I may have confused myself (flush_p??_tlb_* vs. tlb_flush_p??_*) but do > actually need this whole tlb_gather thing here? IIUC (by grep'ing), > flush_p?d_tlb_range() is only called on huge pages, so we should know > the level already. > tlb_flush_##_pxx##_range() is used to set tlb->cleared_*, flush_##_pxx##_tlb_range() will actually flush the TLB entry. In arch64, tlb_flush_p?d_range() is defined as: #define flush_pmd_tlb_range(vma, addr, end) flush_tlb_range(vma, addr, end) #define flush_pud_tlb_range(vma, addr, end) flush_tlb_range(vma, addr, end) So even if we know the level here, we can not pass the value to tlbi instructions (flush_tlb_range() is a common kernel interface and retro-fit it needs lots of changes), according to Peter's suggestion, I finally decide to pass the value of TTL by the tlb_gather_* frame.[1] [1] https://lore.kernel.org/linux-arm-kernel/20200331142927.1237-1-yezhenyu2@huawei.com/ Thanks, Zhenyu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel