From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91E4FC83F2C for ; Tue, 5 Sep 2023 10:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WXE7AXgLZeZ+zB65IAWi/E6d/teKjwYjwqEBWxMvmdM=; b=zCRpQCkpkYjCh5 J1giipbJjMM4SDKpzi1QW7cSGtCbL9fnPbqvyJCdsGA1mldZNKXhMkzClooFYWoKl9JHq3bK6lCyX Jo7y1fYBW1WXOY8Ig/Ru2o5JLexr7W23whKkSAvusNhb+SkopVhNwD8lKXMZ140v7/etSBJs7Iedv dWQ7POwYFt34axbrUPHdmLArZwQozooRKyC07+iEsuBk+SdF+muddNQkqDOkK/581h26EQC/h/xWU +Zup+tFc6Yu2pbhqjjyl3mwrzf8K2+3RBGzt7AsHoWkmElQmLDfyHPNzNNuXGti/SxpNLBs38woei 8svVqqYYaaTUKH6CSMYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdTPo-005psM-2T; Tue, 05 Sep 2023 10:36:12 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdTPk-005prY-2Q for linux-arm-kernel@lists.infradead.org; Tue, 05 Sep 2023 10:36:10 +0000 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-5008d16cc36so3894246e87.2 for ; Tue, 05 Sep 2023 03:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693910162; x=1694514962; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/U9siKDyazHDG6r3zqTARi8NY0BAa80rOt591lmpFyA=; b=Bj7GwDL+0Bfp+Vf1Uku6aIxBJICpGwzB7PKLVEdrybOJYd10lfy/ydoOXbnP7V+/eN bhDWs4XYlClVtvEz+lUhzvgfH6cqZq+gnyjtz15IDNDsAJugiAzVvMKRPS0kzy0ZiOAb QYiUqfd/z1Q6TYSFIbHAMYqH4EyUNOmHOEnqaBa7DHjfYE//V97eWFaWlX5LplP8/YHU QDZJ7ViTpaeeOHm/HjJpgYnqlA4zmGcFxLrXNWLHcyKykWapmXyEvaQTjHXzP/rG+8Qa LOLQBIeCUtqS1F2l3rYxADRUuMxYUWvwhirZIrDR/a+IHZvuZAxiAK2fNP6m69uacSXt 67VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693910162; x=1694514962; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/U9siKDyazHDG6r3zqTARi8NY0BAa80rOt591lmpFyA=; b=fbJltaYlk+ajt++LhO2nfjqbuBvFX8q1KuEpPTw49SWyPiIN3vpKzv60gne14BEbfs Xxx1mLTi/Nz6gzDGApst+adit3KZL3iybVRwMH+Dao3F7poG6rYhYuvj8C2lQnk/r3U6 A0hazima+B2sN/P+zlzoUeS2ioqtkyDMH1jdIpCkfCGKqbR8P6cvjOq8a4ieH27lODHw 87IOzHIMxzpZ0sfe8IRHq86KaqQqNjQFKikRbuRVonR1El4XocalUkkMOoLjr9DPWS++ u6Nlea0D2QOTskPpJecHCdLcLho/fPZDrrHhRQsxCbjTLZTjFjuvZT7jngNwqFZtUHhm 5ohA== X-Gm-Message-State: AOJu0YyMqcJmARhSh4CJL0ehBtWPC+BC+zuLMqI4vTR/jQ+pwnqWTQzo dFPav39+Oc33nJXdQ8Kq8g/B8w== X-Google-Smtp-Source: AGHT+IEEwILeUUAxmLD1NfgpOLlzLDQpUZMD+JAAHfLvTOal4CKjljt/zxapSOY7fQ7wrcKXF88iDA== X-Received: by 2002:a05:6512:3087:b0:500:9a45:62f with SMTP id z7-20020a056512308700b005009a45062fmr10157967lfd.8.1693910162221; Tue, 05 Sep 2023 03:36:02 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id f8-20020a1709067f8800b009a1a5a7ebacsm7282198ejr.201.2023.09.05.03.36.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 03:36:01 -0700 (PDT) Message-ID: Date: Tue, 5 Sep 2023 12:36:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 1/2] dt-bindings: arm64: dts: mediatek: Add mt8395-evk board To: Macpaul Lin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , =?UTF-8?Q?Bernhard_Rosenkr=c3=a4nzer?= , Sean Wang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: Bear Wang , Pablo Sun , Macpaul Lin , Chunfeng Yun References: <20230904092043.5157-1-macpaul.lin@mediatek.com> <00f0a1cf-6246-92e9-13b0-cf31bb292a94@mediatek.com> <97b82a16-8710-9430-35c8-673381aaa417@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230905_033608_805648_952CAB69 X-CRM114-Status: GOOD ( 19.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/09/2023 11:36, Macpaul Lin wrote: > > > On 9/4/23 20:11, Krzysztof Kozlowski wrote: >> >> >> External email : Please do not click links or open attachments until you >> have verified the sender or the content. >> >> On 04/09/2023 11:50, Macpaul Lin wrote: >>> >>> >>> On 9/4/23 17:33, Krzysztof Kozlowski wrote: >>>> >>>> >>>> External email : Please do not click links or open attachments until you >>>> have verified the sender or the content. >>>> >>>> On 04/09/2023 11:20, Macpaul Lin wrote: >>>>> Add bindings for the MediaTek mt8395-evk board. >>>>> The mt8359-evk board is also named as "Genio 1200-EVK". >>>>> MT8195 and MT8395 are the same family series SoC could share >>>> >>>> How can be the same and have different numbers? You sill need dedicated >>>> compatible. >>>> >>> >>> The SoCs mt8195 and mt8395 are designed for different market application >>> and physical characteristics, using different efuse values for >>> distinction. The booting flow and configurations are controllered by the >>> boot loaders, firmware, and TF-A. Therefore, the part numbers and >>> procurement channels are different. The detail information of these >>> efuse values is proprietary, so I cant disclose it futher. Hence the >>> most of peripheral drivers and base address are almost the same. >> >> 1. Drivers? So we talk about compatibility, not the same. >> 2. "almost the same" is not the same. Follow the guidelines for writing >> bindings. >> > > Thanks for the review. > > After internal confirmation and discussion, it can be confirmed that the > MT8195 and MT8395 are identical SoCs from to binding's perspective. I am sorry, but I really do not care what you internally discussed about bindings. I do not think your internal review respect existing guidelines. You talked about drivers, not "bindings perspective", so your internal discussion is clearly discussing something else. > MediaTek hope the mt8395 boards could directly use mt8195.dtsi, without > the need to create a separate mt8395.dtsi to include mt8195.dtsi. > Therefore, we hope to fully adopt the bindings of mt8195. However, I > will submit a revised patch for compatible since they are different boards. You can disagree but then I expect arguments from your side. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel