From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73562EB64DC for ; Tue, 11 Jul 2023 09:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kfVdyIBGQtujcXEcygjiJjCJrBJONndY/pLnYzRGIzM=; b=4o9NnuNXOYmxcT cP9Mf+19xRQH47vYyJeTKcX6AZMYaBg7a/Zp66TS/LeeLpl60KDe01XO3wWxApujJ4bdVrjt14S/e OWcbThyYovmZ3iJJhsjkK3RNZwM9JJr5z4WficWGwrQ2/zoxu8pNjzNb1SFxy8XR9PuBg6GOpJpIz uMavIST2hv315qt4uBtuwfZ0qmIQkNoqYou8VMZEgsHRZj6poCf5JvaTxSHcMqH4SJ684N5f0mLcl vYmoKh1Tsm1JFkr4Kn5/zaOZ+Xpsz9KUnyOPgx2damGbU2Kl1X9xxpAo0ddlyHS5uuYNDicO4lB3D GhnUlXfKHzpe6jZKzO6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJ9FA-00ECzZ-0L; Tue, 11 Jul 2023 09:01:12 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJ9F7-00ECxa-1u for linux-arm-kernel@lists.infradead.org; Tue, 11 Jul 2023 09:01:11 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-98de21518fbso708410366b.0 for ; Tue, 11 Jul 2023 02:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689066067; x=1691658067; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y0CkFjEb0OuX6JyslnIk0RBjlIpWepCB/X11vsuG/i8=; b=BfggbPHEM8qyNGf9X8z+x15SZn2y2QTAb7xh7ZQd48XBwYDhpfVXi02HZ+jYOcClBh KIjPUvvYorXEIL4Rf0eJN5pJoyE+HYozl4EjafDtxwx+v0AyUpcr7trCg0741fGzRmke QLaTaPToZo2L3jrucKqMddWIUmALa7Zgo3q4esHanSJxsM4REML7NDOSfJ0RSPPZm9uP AxpJBcfyp1JmbrYDFfVpq2VLyEJ6hRzkuiazVQS9o3n7dn9sw9fpozHxee9E3OMoGtTF EWBcsCp3bvoziCWmO1mLwUlqi305g24fMmWB8mmjZ3/QX/tmW5A2/0Nnno4ZFhsXgyQo jPKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689066067; x=1691658067; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y0CkFjEb0OuX6JyslnIk0RBjlIpWepCB/X11vsuG/i8=; b=jd3QWIRzmLtITuqsB2rwkZRKB4JUFGIlxOyhJ/Rs+izizXxLafFdWmYxdRnbgDJxdk OmEapImxQvZEnp1Z1xBRwK/sdWWYtbGh1j6RxKiPrMpEf7zdcoxevKJACzREw6nq9c5m SIlMMYq16HviSwuxucpFhOpBEuxKLvQlUExBMQYmBormQe/6+3RiPE7CdRoQSW2wVFaQ fGoDdFJ+0+wDJGqXtKAZsajVYLJUjesvZbiYFyx7HWGc4zlkyx5z6gf0t2PLZcSKso2f CuGhS3MaCzBPFxSXoutincV7kUVFbRgHLNDRF3sMSJHyIN0Xo7Kag18V/1JiUq9YeVcS 5/ZQ== X-Gm-Message-State: ABy/qLZqe2xi1UcW0LqHiCJxEii2ABDATEmr8mJ29iQsVbsDIAinleRG DgerAXeVq89HRmiau9iulM/5/g== X-Google-Smtp-Source: APBJJlEyytDgOjuuRyspI4qoYl7w3PtoRhH9wmrQr4+Yr8WOELXXVdjiF3Ro5xKRaNdqoK5aVuWpug== X-Received: by 2002:a17:906:77c7:b0:993:d782:a3db with SMTP id m7-20020a17090677c700b00993d782a3dbmr14084304ejn.16.1689066067522; Tue, 11 Jul 2023 02:01:07 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id y24-20020a17090629d800b0098822e05539sm869474eje.191.2023.07.11.02.01.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 02:01:07 -0700 (PDT) Message-ID: Date: Tue, 11 Jul 2023 11:01:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 4/6] arm64: dts: qcom: ipq5332: Add USB related nodes Content-Language: en-US To: Varadarajan Narayanan , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, arnd@arndb.de, geert+renesas@glider.be, neil.armstrong@linaro.org, nfraprado@collabora.com, broonie@kernel.org, rafal@milecki.pl, quic_srichara@quicinc.com, quic_varada@quicinc.org, quic_wcheng@quicinc.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <23b259b72c8f6faad99f09c37ac8b7b6b027cea1.1689065318.git.quic_varada@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <23b259b72c8f6faad99f09c37ac8b7b6b027cea1.1689065318.git.quic_varada@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230711_020109_633258_9010C89B X-CRM114-Status: GOOD ( 18.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/07/2023 10:51, Varadarajan Narayanan wrote: > Add USB phy and controller nodes. > > Signed-off-by: Varadarajan Narayanan > --- > v1: > Rename phy node I don't see any improvements. > Change compatible from m31,ipq5332-usb-hsphy -> qcom,ipq5332-usb-hsphy > Remove 'qscratch' from phy node > Fix alignment and upper-case hex no.s > Add clock definition for the phy > Remove snps,ref-clock-period-ns as it is not used. dwc3_ref_clk_period() > in dwc3/core.c takes the frequency from ref clock and calculates fladj > as appropriate. > --- > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 54 +++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > index 8bfc2db..c945ff6 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > @@ -405,6 +405,60 @@ > status = "disabled"; > }; > }; > + > + usbphy0: ipq5332-hsphy@7b000 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation "phy" > + compatible = "qcom,ipq5332-usb-hsphy"; > + reg = <0x0007b000 0x12c>; > + > + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>; > + clock-names = "cfg_ahb"; > + > + resets = <&gcc GCC_QUSB2_0_PHY_BCR>; > + > + status = "disabled"; > + }; > + > + usb2: usb2@8a00000 { It does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). > + compatible = "qcom,ipq5332-dwc3", "qcom,dwc3"; > + No need for blank line. > + reg = <0x08af8800 0x400>; > + > + interrupts =