From: Nikita Shubin <nikita.shubin@maquefel.me>
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Dan Carpenter <dan.carpenter@linaro.org>
Cc: Hartley Sweeten <hsweeten@visionengravers.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ep93xx: clock: Fix off by one in ep93xx_div_recalc_rate()
Date: Wed, 11 Sep 2024 19:28:03 +0300 [thread overview]
Message-ID: <ddf9785a0b6e8ddee0de327423cefb22d7aac71b.camel@maquefel.me> (raw)
In-Reply-To: <548605182873dadad9ee33dc6ed70e0eba4bf495.camel@gmail.com>
Hello Alexander, Arnd,
On Wed, 2024-09-11 at 16:59 +0200, Alexander Sverdlin wrote:
> Hi Arnd, Nikita,
>
> On Wed, 2024-09-11 at 14:54 +0000, Arnd Bergmann wrote:
> > On Wed, Sep 11, 2024, at 08:14, Nikita Shubin wrote:
> > > Hi Dan!
> > >
> > > Reviewed-by: Nikita Shubin <nikita.shubin@maquefel.me>
> > >
> > > Alexander, Arnd
> > >
> > > unfortunately, the ep93xx DT conversion series is also affected
> > > by this
> > > bug.
> >
> > Here is what I did now:
> >
> > 1. applied Dan's patch on a new branch
> > 2. applied the DT conversion series on top of that,
> > removing that file.
> > 3. applied the first patch (with minor context changes)
> > in drivers/clk/clk-ep93xx.c again, along with
> > the MODULE_LICENSE fix I did.
> > 4. finally, merged the entire branch into my for-next
> > branch so it actually makes it into linux-next
> >
> > My plan now is to keep the branch in linux-next for at
> > least a week and send all the other pull requests for
> > the merge window first. If no other problems show up
> > (either with this branch or my other 6.12 contents),
> > I hope to send it all later in the merge window. If
> > something goes wrong, I'll send only the bugfix as part
> > of my first fixes branch for 6.12 and we'll defer the
> > DT conversion once more.
> >
> > I should have merged it earlier, but wasn't sure about
> > interdependencies with the parts that already got merged
> > elsewhere and with the comments about DTC warnings.
> >
> > From what I can tell, the current state is as good as
> > it gets, as we'll always get more comments or conflicts
> > with new reversions of the series. Let's hope we can
> > address any other issues on top of what I've merged
> > now and stop rebasing.
>
> thanks Arnd for resolving this finally and Nikita for
> your relentless efforts!
>
> PS. I've archived Subject patch now in soc patchwork
> (because I think I've messed up the author info, but
> all of this seems to be obsolete now)
>
thank you for your work and support!
prev parent reply other threads:[~2024-09-11 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 7:39 [PATCH] ep93xx: clock: Fix off by one in ep93xx_div_recalc_rate() Dan Carpenter
2024-09-11 7:52 ` Alexander Sverdlin
2024-09-11 8:14 ` Nikita Shubin
2024-09-11 14:54 ` Arnd Bergmann
2024-09-11 14:59 ` Alexander Sverdlin
2024-09-11 16:28 ` Nikita Shubin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddf9785a0b6e8ddee0de327423cefb22d7aac71b.camel@maquefel.me \
--to=nikita.shubin@maquefel.me \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=hsweeten@visionengravers.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox