From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB9A6CCA462 for ; Fri, 16 Oct 2026 14:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=83Aj4f+5NsBgyuf5dIR6BTfkkLlq/tnMxmCVHEhCh2o=; b=xa+Cqt20k8cb4J/Fh/OdSMT89p GuSplgK0tJKUCmZcLQvpo9k2QkazO6P7fialeY/mISIhI9WJPRLBmJPiKpwT9S6oIKJrbN4TDeveD RFLP32vPZtj1WPYFOvxJrMsR3Z5216SwLQuBm8RjHPPrEQ8s0iJMzNBAoAXYgbHuA3UdoRe7W9/u1 pqwZCut87WEdQO328E/aM/+SCaHkE1Co9mIKAxRUfMIoiqSq8nuuFC5+Mx/fdo7M24UkqEI78byfs XXPTSV35l+5N47+0JhAQGXTQaMAVcjoDjVmfa/U73a+8S/uE8NAJSgIehIez2ZLSeKeeeqvu0niuh onJwgvqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHims-000000037yT-2FLX; Fri, 16 Oct 2026 14:19:58 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHimr-000000037yH-0YEM for linux-arm-kernel@lists.infradead.org; Fri, 16 Oct 2026 14:19:57 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id AED8543F2C; Fri, 16 Oct 2026 14:19:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6C741F000C4; Fri, 16 Oct 2026 14:19:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792160396; bh=83Aj4f+5NsBgyuf5dIR6BTfkkLlq/tnMxmCVHEhCh2o=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=GI6wISk0D5sX15J9jlwNWrQpqHxp5vfV8yO1GxDv18ZphrJKZ89A4pYjnyVFB98JK /y0j/lejHHUNn8+QXcP3C/NCYqGJzLsBeMg33KqN20iX80mIUEeJr0vV3FfJmB+QkZ cAD7oakhLjw4XVBk7EjTO8W2xMqEFFYdJtYFLufDTPLOOkPuP74V9V0sZaIOBmTs/b x4mgZmEGY326qwfbyHnB0myxhMbutUVFtN6wvpSWy2KF1TpPmqmLbxb92yHGlLE9we IC+UohPD3MRE5MNhl75r1vyYpoE5T4phVFvt2DeEm81t+4Zrh8bNHPhO6vr0wRq/EB QfBGnmHYuD+Lw== Message-ID: Date: Fri, 16 Oct 2026 16:19:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 1/5] dt-bindings: mfd: Describe the BCM6846 PMC complex To: Linus Walleij , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , William Zhang , Anand Gore , Kursad Oney , Florian Fainelli , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , Philipp Zabel Cc: mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20261014-xg6846b-bcmbca-xrdp-reset-v1-0-daf5d177e113@kernel.org> <20261014-xg6846b-bcmbca-xrdp-reset-v1-1-daf5d177e113@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20261014-xg6846b-bcmbca-xrdp-reset-v1-1-daf5d177e113@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/10/2026 11:48, Linus Walleij wrote: > The third generation Platform Management Controller (PMC3) has > different subdevices. > > Identify the parent with Broadcom's "brcm,bca-pmc-3-1" compatible > for the version 3.1 complex. > > Describe the complex as a simple-mfd with two system-controller children > and a bus child, each owning its register resource. That's RFC, but I skimmed cover letter and did not find what you actually ask us for and why this is not ready for review, thus few things to spare you one more cycle when this is ready for review: > > Assisted-by: LLM > Signed-off-by: Linus Walleij > --- > .../devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml | 98 ++++++++++++++++++++++ > 1 file changed, 98 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml b/Documentation/devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml > new file mode 100644 > index 000000000000..7ddf84b561aa > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/brcm,bcm6846-pmc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom BCM6846 Platform Management Controller > + > +maintainers: > + - Linus Walleij > + > +description: | Drop | > + The third generation Platform Management Controller (PMC3) contains > + separate register banks for PMC control and message queues, the > + Processor Monitor Bus (PMB) interface within Procmon, and the Maestro > + processor control registers. Each child owns its register bank. The > + parent provides address translation and does not own a register bank. > + > +properties: > + compatible: > + items: > + - const: brcm,bca-pmc-3-1 This should be rather SoC specific. > + - const: simple-mfd > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > + ranges: > + maxItems: 1 > + > +patternProperties: > + '^system-controller@[0-9a-f]+$': > + type: object > + additionalProperties: false > + description: > + PMC control and message queue registers, or Maestro processor > + control, status and interrupt registers > + > + properties: > + compatible: > + enum: > + - brcm,bcm6846-pmc-control > + - brcm,bcm6846-pmc-maestro > + > + reg: > + maxItems: 1 > + > + required: > + - compatible > + - reg No resources here except address space, so I question whether these are really separate devices. I guess address space is at least big enough to mark this as really separate device? > + > + '^bus@[0-9a-f]+$': > + $ref: /schemas/soc/bcm/brcm,bcm6846-pmb.yaml# No such file. Are you sure this passes tests? > + description: PMB configuration, keyhole and address mapping registers > + > +required: > + - compatible > + - '#address-cells' > + - '#size-cells' > + - ranges > + > +additionalProperties: false > + > +examples: > + - | > + system-controller@ffb00000 { > + /* Broadcom BCA Platform Management Complex version 3.1 */ > + compatible = "brcm,bca-pmc-3-1", "simple-mfd"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0xffb00000 0x21000>; ranges should be the second. Best regards, Krzysztof