From: Caleb James DeLisle <cjd@cjdns.fr>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, p.zabel@pengutronix.de,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
vadim.fedorenko@linux.dev, maxime.chevallier@bootlin.com,
dong100@mucse.com, wangruikang@iscas.ac.cn,
25181214217@stu.xidian.edu.cn, hkallweit1@gmail.com,
han.junyang@zte.com.cn, xuanzhuo@linux.alibaba.com,
enelsonmoore@gmail.com, jes@trained-monkey.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, naseefkm@gmail.com,
b.larsson@gmx.com
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: econet: add EN751221 ethernet
Date: Thu, 10 Sep 2026 11:06:38 +0200 [thread overview]
Message-ID: <de010064-a574-4da7-8307-30bd6359e506@cjdns.fr> (raw)
In-Reply-To: <a9eac625-f0f3-47db-ac2c-26c7df66f52a@lunn.ch>
On 10/09/2026 04:11, Andrew Lunn wrote:
>> + gmac1: mac@1 {
>> + compatible = "econet,eth-mac";
>> + reg = <1>;
>> + status = "disabled";
>> + phy-mode = "rgmii-rxid";
> That is a very unusual phy-mode. Is there a reason this is used in the
> example?
Mac 1 connects to an xPON or xDSL subsystem depending on chip package.
The phy-mode is not used by the driver and when the driver was written 6
months ago this was the best guess about the electrical protocol, left
for documentation purposes.
Your question made me re-investigate this, and I now note that both the
xPON and xDSL "upper halves" as well as the switch on gmac0 are all
on-die, so I think phy-mode = "internal" is more appropriate and I will
re-send as such, and with some light documentation about what this
ethernet connects to - since it's on the die so it'll always be the same.
Thanks,
Caleb
>
> Andrew
next prev parent reply other threads:[~2026-09-10 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 21:21 [PATCH net-next 0/2] net: econet: add EcoNet EN751221 ethernet driver Caleb James DeLisle
2026-09-09 21:21 ` [PATCH net-next 1/2] dt-bindings: net: econet: add EN751221 ethernet Caleb James DeLisle
[not found] ` <45cb6035-4d15-426d-bb3f-45d20b4201da@gmail.com>
2026-09-10 0:40 ` Caleb James DeLisle
2026-09-10 2:11 ` Andrew Lunn
2026-09-10 9:06 ` Caleb James DeLisle [this message]
2026-09-10 12:11 ` Matheus Sampaio Queiroga
[not found] ` <20260909212146.3184077-3-cjd@cjdns.fr>
2026-09-12 0:07 ` [PATCH net-next 2/2] net: econet: add EcoNet EN751221 ethernet driver Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de010064-a574-4da7-8307-30bd6359e506@cjdns.fr \
--to=cjd@cjdns.fr \
--cc=25181214217@stu.xidian.edu.cn \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=b.larsson@gmx.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dong100@mucse.com \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=han.junyang@zte.com.cn \
--cc=hkallweit1@gmail.com \
--cc=jes@trained-monkey.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=naseefkm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=wangruikang@iscas.ac.cn \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox