From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 367CBC433E7 for ; Fri, 16 Oct 2020 10:33:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AADBA207F7 for ; Fri, 16 Oct 2020 10:33:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nFo6TP0a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AADBA207F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FyxNe+LGt0PXjvR/MxQ8goTbdAbd+QRaLHKFjpzV0RI=; b=nFo6TP0aPceL9Ui5cjjiJVQ7j GAYNO+j9ErkhFSkaLEzUkny6qSfZHyBv4DiJ74q7SUGGpT+bi+hiEpgs7+0jT97f9JO3GxHYLDvEe nMYRSqNtYUBlRPab+l8LEIcw1oNwazXVqSd9SkxVxjlRr91JvtaV/0cRvAglitlDPXTweE+ly8S8O c5p6EXh5raqJp39xCuCKKTDI60QTCnDKVGg7f2VtqMGJTokMoGyAJKs/Z2Cv1PRNIywILfYWiBWOG HXvHl+dZetM3Jk9wkLXnvRN5Y9J8l7S5DMo7UIfoqq6VoMtIh5DIOT+SIMlhTWOQBb9Zn48gj9QTh 5KBQQAMeg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTN1v-00076I-UK; Fri, 16 Oct 2020 10:32:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTN1s-00075L-PX for linux-arm-kernel@lists.infradead.org; Fri, 16 Oct 2020 10:32:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5A52CD6E; Fri, 16 Oct 2020 03:32:03 -0700 (PDT) Received: from [10.57.21.20] (unknown [10.57.21.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 806413F719; Fri, 16 Oct 2020 03:32:02 -0700 (PDT) Subject: Re: [PATCH -next] firmware: arm_scmi: Add the trace_scmi_xfer_end To: Zhang Qilong , sudeep.holla@arm.com References: <20201016090815.28160-1-zhangqilong3@huawei.com> From: Lukasz Luba Message-ID: Date: Fri, 16 Oct 2020 11:32:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20201016090815.28160-1-zhangqilong3@huawei.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201016_063208_871818_D073CAD4 X-CRM114-Status: GOOD ( 19.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/16/20 10:08 AM, Zhang Qilong wrote: > Missing the trace_scmi_xfer_end in exception path of scmi_do_xfer. > > Signed-off-by: Zhang Qilong > --- > drivers/firmware/arm_scmi/driver.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 03ec74242c14..1a8661514a25 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -368,7 +368,7 @@ int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) > ret = info->desc->ops->send_message(cinfo, xfer); > if (ret < 0) { > dev_dbg(dev, "Failed to send message %d\n", ret); > - return ret; > + goto out; > } > > if (xfer->hdr.poll_completion) { > @@ -396,6 +396,7 @@ int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) > if (info->desc->ops->mark_txdone) > info->desc->ops->mark_txdone(cinfo, ret); > > +out: > trace_scmi_xfer_end(xfer->transfer_id, xfer->hdr.id, > xfer->hdr.protocol_id, xfer->hdr.seq, ret); > > I think it makes sense, the 'begin' trace entry will always be paired with 'end'. For the post processing the trace, it would be easier to reconstruct such transfer and mark immediately as 'not sent' (avoiding to bother about entries which only have 'begin'). Sudeep, in case you consider to take it, feel free to add: Reviewed-by: Lukasz Luba Regards, Lukasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel