From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6DC0C49ED7 for ; Mon, 16 Sep 2019 10:46:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 968F1206A4 for ; Mon, 16 Sep 2019 10:46:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V9eX7t2E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 968F1206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3LO4xjYGJUcTnmWCJXoP+jCmCli3bsR/dAdP+cahqF4=; b=V9eX7t2EDCvTA+QojPLfGhY7z CA1YzSVVXNohAqfx4MbFfFCE+tp220iOtywrDoIgSaB+Lc3eN43eQLwNJRcBj8LEN/r4Hkq875b+F ywYDacsWMORBALiVC57aholjeW+KVhCLSewNEWhwLO6aHDq2sykxMAqyqxV6o/5Y0Vd+hD/BdduXf lEwK5Dx/P6S4LQZoBKZoWu9M86HIwzhnxn7qdbs4B9XLWoyaA0YIMjNykVVznz6ggfxfTnjwQLI+n 0NOIEkWrkdf3dc2v/hkDNTRh2t6NQXEsV0SuBXUUrGl/WYEs9/MqhRb7cW1Q+XoXDjgFJMgoFr+uO SNNvBqqWw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9oWT-00022g-Gp; Mon, 16 Sep 2019 10:46:21 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9oWQ-00021p-6C for linux-arm-kernel@lists.infradead.org; Mon, 16 Sep 2019 10:46:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C462F1000; Mon, 16 Sep 2019 03:46:15 -0700 (PDT) Received: from [10.1.197.57] (e110467-lin.cambridge.arm.com [10.1.197.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DC62A3F59C; Mon, 16 Sep 2019 03:46:12 -0700 (PDT) Subject: Re: [PATCH] iommu/arm-smmu: Axe a useless test in 'arm_smmu_master_alloc_smes()' To: Christophe JAILLET , will@kernel.org, joro@8bytes.org References: <20190915193401.27426-1-christophe.jaillet@wanadoo.fr> From: Robin Murphy Message-ID: Date: Mon, 16 Sep 2019 11:46:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190915193401.27426-1-christophe.jaillet@wanadoo.fr> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190916_034618_283335_1516B91B X-CRM114-Status: GOOD ( 18.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: iommu@lists.linux-foundation.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/09/2019 20:34, Christophe JAILLET wrote: > 'ommu_group_get_for_dev()' never returns NULL, so this test can be removed. Nit: typo in the function name. Otherwise, there definitely used to be some path where a NULL return could leak out, so I would have had that in mind at the time I wrote this, but apparently I never noticed that that had already been cleaned up by the time this got merged. Reviewed-by: Robin Murphy Thanks, Robin. > Signed-off-by: Christophe JAILLET > --- > drivers/iommu/arm-smmu.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index c3ef0cc8f764..6fae8cdbe985 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1038,8 +1038,6 @@ static int arm_smmu_master_alloc_smes(struct device *dev) > } > > group = iommu_group_get_for_dev(dev); > - if (!group) > - group = ERR_PTR(-ENOMEM); > if (IS_ERR(group)) { > ret = PTR_ERR(group); > goto out_err; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel