From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4705C43458 for ; Fri, 3 Jul 2026 17:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Hk/XZj/t/sZk02q5rdFGudYc0NQp5y9BlulwILht4T0=; b=ET2FpI6y9S2lCV9CEf+FEIf11k IgLYz0SzJbIjMDVzIaZqdj/uuGdrxcQMai5/FmolRd3/opC2UGs80UBJB1x9pEfV03BpFQhC1UOoJ Brm11I4uvQ0jLBmAhDCD71tFP0/Mwqr1pJiCSKDnxAPIsua2SX9X0Pev1Hz4KmDY5+EQe4bZaj0pN 3oFb+4Aj0L7PyYRZmqm8Pp/+Fk0bvj1vN58kmCKXWYZ3iufqdH6eiZLglsEzwOcuFJPELu46p7MrE 7d5zf+bfdCBkqDAHe5j+6N/66mDrjCgoziaw7ZODcVxyoT2Qt/dNJ1iEO8HDDAZU4id+uz9s5HtMF m5h1t5cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfhF5-00000007Zri-0p7e; Fri, 03 Jul 2026 16:59:55 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfhF0-00000007Zpy-04sT; Fri, 03 Jul 2026 16:59:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1783097985; bh=Dhy4gvLT0RAnGvm4Qciq67SI7sUn4Qp1DNRguSA4Rcs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nJd6/ih40hiWEhn4ndj338VwFyT5SxADffzqSTjv1GQ5me0AH4Mj17WymraBfs+t/ r5GGKZ4aL8Tow2C+NPSJhmYYVE5jc8dNI+pq7pn2xeqyIqZaFc0+AT+VP4hhrndqmx RZH5/XifxgE5MXgQvzXY0bL00xaiScLbPsKviaa4biXtRCgtTWQ1LRbKxdaAO8vh4c vFeEhuh52yIuwJ9INcJJC/MsS0C0gxf7stzwfxbLzKvut59k3ZLy5XdVxXX7PCQpbq CBgkhxWhD17uony3610weO3dBkZHxQph+StpRo70GCInYK0K4cKEHlrvZ/jxJI/Bqj IFdD4qkXS6vNg== Received: from [100.64.0.241] (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id F3DB217E0521; Fri, 3 Jul 2026 18:59:44 +0200 (CEST) Message-ID: Date: Fri, 3 Jul 2026 19:59:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/9] dt-bindings: display: vop2: Add missing reset properties To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Diederik de Haas , Sandy Huang , Andy Yan , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli Cc: kernel@collabora.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260617-dw-hdmi-qp-yuv-v1-0-a665cfd06d7d@collabora.com> <8183064.gsGJI6kyIV@diego> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <8183064.gsGJI6kyIV@diego> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260703_095950_216585_72EA12AA X-CRM114-Status: GOOD ( 12.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/3/26 7:37 PM, Heiko Stübner wrote: > Am Donnerstag, 18. Juni 2026, 10:39:14 Mitteleuropäische Sommerzeit schrieb Cristian Ciocaltea: >> Hi Diederik, >> >> On 6/18/26 10:58 AM, Diederik de Haas wrote: >>> Hi Cristian, >>> >>> Thanks for this series :-) Just 1 nit (at the end) ... >>> >>> On Wed Jun 17, 2026 at 8:52 PM CEST, Cristian Ciocaltea wrote: >>>> Document the VOP2 resets corresponding to the AXI, AHB and DCLK_VP0..2 >>>> clocks, which are common to all supported SoCs, plus DCLK_VP3 which is >>>> provided only on RK3588. >>>> >>>> Signed-off-by: Cristian Ciocaltea >>>> --- >>>> .../bindings/display/rockchip/rockchip-vop2.yaml | 42 ++++++++++++++++++++++ >>>> 1 file changed, 42 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml >>>> index 93da1fb9adc4..d3bc5380f910 100644 >>>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml >>>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml >> [...] >> >>>> @@ -289,6 +321,16 @@ examples: >>>> "dclk_vp0", >>>> "dclk_vp1", >>>> "dclk_vp2"; >>>> + resets = <&cru SRST_A_VOP>, >>>> + <&cru SRST_H_VOP>, >>>> + <&cru SRST_VOP0>, >>>> + <&cru SRST_VOP1>, >>>> + <&cru SRST_VOP2>; >>>> + reset-names = "axi", >>>> + "ahb", >>>> + "dclk_vp0", >>>> + "dclk_vp1", >>>> + "dclk_vp2"; >>>> power-domains = <&power RK3568_PD_VO>; >>> >>> Place reset* props below power-domains (like in patch 9) ? >>> So everyone who copies your example has the correct sorting order. >> >> The example doesn't strictly follow that ordering either — see e.g. the iommus >> property — so I placed the resets right after the clocks, which keeps the >> related properties grouped together. >> >> That said, I don't have a strong preference. >> >> Heiko, is there a convention you'd like the Rockchip bindings to follow here? >> Happy to reorder if so. > > Please just use standard devicetree ordering, as described in the > documentation. We generally don't want to invent new diverging things :-) Ack. For consistency, let's also move the iommus property up into the expected position. Thanks, Cristian