From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63ECDC43603 for ; Wed, 11 Dec 2019 14:50:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FBC82077B for ; Wed, 11 Dec 2019 14:50:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rL30aHlO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FBC82077B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZiJx3eyXf2i/NiivM+kajbFMTZD7Dq2ny+4KAV00zA0=; b=rL30aHlOb17m+DT0ubMRc/ahi xi/EqI6kVH7ZG0cPaHRgZERyIMw0/uJXXVDBlAPsxiHYC+dU62bs9Wr4ph5MW0eMxO2Zp8tRI4Fk/ Hcv7RmySJkxqFXqxvEY5wfGgE7HQfrsIDnwtmYaJLQjeb5f9WeFsYKiSJ8Mq0mtrICNUnERV4lsO7 rUgxvYqR+gIEcHVBh9jH+k81rKb1vP1DlmxFgdCv3FeKVkQ50SFav80SRPX+S+2I6Jcq5zSXzLtVd W92/GIP10+yJNTsaZJmS1h9fUXohljIZt2onbgnf1F6/4/je6kKERAh/glYfVx70wGGoYWc86Atmy 6yJjipt1A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1if3Jg-0006eu-DG; Wed, 11 Dec 2019 14:50:16 +0000 Received: from lhrrgout.huawei.com ([185.176.76.210] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1if3Jc-0006av-9r for linux-arm-kernel@lists.infradead.org; Wed, 11 Dec 2019 14:50:14 +0000 Received: from lhreml707-cah.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id C7EB851606058E11F8C7; Wed, 11 Dec 2019 14:50:06 +0000 (GMT) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by lhreml707-cah.china.huawei.com (10.201.108.48) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 11 Dec 2019 14:50:06 +0000 Received: from [127.0.0.1] (10.202.226.46) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 11 Dec 2019 14:50:06 +0000 Subject: Re: [PATCHES] Fix 'perf top' breakage on architectures not providing get_cpuid() Re: perf top for arm64? To: Arnaldo Carvalho de Melo , Jiri Olsa References: <1573045254-39833-1-git-send-email-john.garry@huawei.com> <20191106140036.GA6259@kernel.org> <418023e7-a50d-cb6f-989f-2e6d114ce5d8@huawei.com> <20191210163655.GG14123@krava> <952dc484-2739-ee65-f41c-f0198850ab10@huawei.com> <20191210170841.GA23357@krava> <9a31536b-f266-e305-1107-2f745d0a33e3@huawei.com> <20191210195113.GD13965@kernel.org> <20191211133319.GA15181@kernel.org> From: John Garry Message-ID: Date: Wed, 11 Dec 2019 14:50:05 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20191211133319.GA15181@kernel.org> Content-Language: en-US X-Originating-IP: [10.202.226.46] X-ClientProxiedBy: lhreml728-chm.china.huawei.com (10.201.108.79) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191211_065012_494367_454039FE X-CRM114-Status: GOOD ( 23.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , Peter Zijlstra , "linux-kernel@vger.kernel.org" , Linuxarm , "linux-perf-users@vger.kernel.org" , Alexander Shishkin , Namhyung Kim , "will@kernel.org" , Ingo Molnar , "linux-arm-kernel@lists.infradead.org" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > >> Right, I need to make that just a pr_debug() message and then check in >> the annotation code when that is needed to see if it is set, if not, >> then show a popup error message and refuse to do whatever annotation >> feature requires that. > >> Anyway, your patch should make sense and provide info that the ARM64 >> annotation may use now or in the future. > > So can you take a look at the two patches below and provide me Acked-by > and/or Reviewed-by and/or Tested-by? > > >>>From 53c6cde6a71a1a9283763bd2e938b229b50c2cd5 Mon Sep 17 00:00:00 2001 > From: Arnaldo Carvalho de Melo > Date: Wed, 11 Dec 2019 10:09:24 -0300 > Subject: [PATCH 1/2] perf arch: Make the default get_cpuid() return compatible > error > > Some of the functions calling get_cpuid() propagate back the error it > returns, and all are using errno (positive) values, make the weak > default get_cpuid() function return ENOSYS to be consistent and to allow > checking if this is an arch not providing this function or if a provided > one is having trouble getting the cpuid, to decide if the warning should > be provided to the user or just a debug message should be emitted. > > Cc: Adrian Hunter > Cc: Jiri Olsa > Cc: John Garry For both patches: Tested-by: John Garry #arm64 I'll still look to get the arm64 version of get_cpuid() patch sent. > Cc: Mark Rutland > Cc: Namhyung Kim > Cc: Will Deacon > Link: https://lkml.kernel.org/n/tip-lxwjr0cd2eggzx04a780ffrv@git.kernel.org > Signed-off-by: Arnaldo Carvalho de Melo > --- > tools/perf/util/header.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c > index becc2d109423..4d39a75551a0 100644 > --- a/tools/perf/util/header.c > +++ b/tools/perf/util/header.c > @@ -850,7 +850,7 @@ int __weak strcmp_cpuid_str(const char *mapcpuid, const char *cpuid) > */ > int __weak get_cpuid(char *buffer __maybe_unused, size_t sz __maybe_unused) > { > - return -1; > + return ENOSYS; /* Not implemented */ > } > > static int write_cpuid(struct feat_fd *ff, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel