From: skannan@codeaurora.org (Saravana Kannan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/11] clk: Add a generic clock infrastructure
Date: Tue, 13 Sep 2011 19:22:17 -0700 (PDT) [thread overview]
Message-ID: <decbd6943536eae1bddda9765ac5b267.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <1314191759-16941-1-git-send-email-broonie@opensource.wolfsonmicro.com >
On Wed, August 24, 2011 6:15 am, Mark Brown wrote:
> diff --git a/include/linux/clk.h b/include/linux/clk.h
> index 1d37f42..93ff870 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> -struct clk;
> +static inline int clk_prepare(struct clk *clk) { return 0; }
> +static inline void clk_unprepare(struct clk *clk) { }
> +
You should add might_sleep() inside these stubs. That way, if any device
driver developers wants to move over to the new APIs before their arch
does, they get to see the warnings when they call prepare/unprepare in
atomic context.
Thanks,
Saravana
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-09-14 2:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 13:13 [PATCH 0/11] generic struct clk patches Mark Brown
2011-08-24 13:15 ` [PATCH 01/11] clk: Add a generic clock infrastructure Mark Brown
2011-08-24 13:15 ` [PATCH 02/11] clk: Implement clk_set_rate Mark Brown
2011-08-26 8:53 ` Sascha Hauer
2011-08-26 8:55 ` Mark Brown
2011-08-26 8:58 ` Sascha Hauer
2011-08-26 9:01 ` Mark Brown
2011-08-26 23:45 ` Turquette, Mike
2011-09-13 19:03 ` Stephen Boyd
2011-08-24 13:15 ` [PATCH 03/11] clk: Add fixed-rate clock Mark Brown
2011-08-24 13:15 ` [PATCH 04/11] clk: Add simple gated clock Mark Brown
2011-08-25 13:17 ` Jamie Iles
2011-09-13 19:03 ` Stephen Boyd
2011-08-24 13:15 ` [PATCH 05/11] clk: Prototype and document clk_register() Mark Brown
2011-09-13 19:03 ` Stephen Boyd
2011-08-24 13:15 ` [PATCH 06/11] clk: Provide a dummy clk_unregister() Mark Brown
2011-08-25 11:12 ` Jamie Iles
2011-08-24 13:15 ` [PATCH 07/11] clk: Constify struct clk_hw_ops Mark Brown
2011-08-24 13:15 ` [PATCH 08/11] clk: Avoid clock name collisions Mark Brown
2011-09-13 19:03 ` Stephen Boyd
2011-08-24 13:15 ` [PATCH 09/11] clk: Add Kconfig option to build all generic clk drivers Mark Brown
2011-08-24 13:15 ` [PATCH 10/11] clk: Add initial WM831x clock driver Mark Brown
2011-08-24 13:15 ` [PATCH 11/11] x86: Enable generic clk API on x86 Mark Brown
2011-09-13 19:03 ` [PATCH 01/11] clk: Add a generic clock infrastructure Stephen Boyd
[not found] ` <1314191759-16941-1-git-send-email-broonie@opensource.wolfsonmicro.com >
2011-09-14 2:22 ` Saravana Kannan [this message]
2011-09-14 9:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=decbd6943536eae1bddda9765ac5b267.squirrel@www.codeaurora.org \
--to=skannan@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).