From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EAB6C433EF for ; Mon, 13 Dec 2021 09:31:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MkNw/ol+s15W2f6kwd8Kkhl33/cyHlylzA2KtVNmbAg=; b=3NRo+CR/fDDS4E 3vSVmiAmYQZGfGTvYb9hPmfe2QAEx4eHl91divcdCjN/YVekSn2nbSTwT13yfXyxRw/oXtxXoXjHi G571YtlU/TpSKd+kU+Toq0jim3zyyTLpFMu1wd4AQ6eA+pYgf7d2ljOzq8+nYmcV5Eky5v/X7XuIV +eEHkLpw4FUpI23AAO2bs2mmeZXsPryVJOep6fXkcWhtBQQxXl8LeJqdJfH8ebxkaBJacnpStAORI Qp0xIOCp7D4jQLLTLN4bGdPYXJDa2ni1wBPWEexI5l2EAE5ddwSJiOph3E8eyyaVhFU9X5PLD5Sen ExVRqoZSySefIAbuxQYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwhdo-008dYL-SP; Mon, 13 Dec 2021 09:29:07 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwhce-008d6g-3f for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 09:27:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1639387672; x=1670923672; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=reS0kdiGrNca1DG1v4rmFK0BVyO7s/UdfNQFdmGVzsU=; b=VSENVQ36hXbsDpoe1A7XAF/6R00o06MqFqJUE/kqmf16g1Nu0GTtNce0 whxwX0yUAm42rZv0DLuUuMCRfSGWDRKpQRNcYkFZ4nq3WJUcjJWqvLOGA X+sBY0iUfruSDmjftg5xAzBSITmpU4pIq7n8BAm7CTko9KaExKxtP30Gf UYSclHoRhoAJxTnF9ImfZrvbXkUAuYcfi3m+9OxBYJa+olw4mmWvWIrN+ RnoO7i9eylKDrKhOgKcB1bD77+lcfUH5JBWA8c0uLlvfzuyY2JAefeQWr B8VJ7JuvMN0LuBbah69U2V5UJRBXFttNcypGAWZ6dcDR/bu7rGMZFlu+R g==; IronPort-SDR: ErsteK1ID/FcUzj7FU7OEYFoDYIfdqLl5e2e4AQmjoZE+0IzfTGt1SngwP0fAOwcuG18NgAprE nD8Aa45atGQEiIobWq4WxbeS1BAH0yWSVf3WtMIsYULgkbYn3AbImm2f+KAk3Dr2tMHV/XdnYW PoZbm5PIwPJinM4XA4ND8RH5SV7Lyhrr+NAAJDjMsDicAl3BOxbB976/QANYh2z358/jkaBu3S hr5etA+fqe1o1aGpPQLUMLk+j60iraB1dCx77J+vxRfTTpWSXdVmoicqaVWre3gjz4nquCqpyu vtL8FATX7db6u8+DqjgSPk/J X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="155246667" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Dec 2021 02:27:51 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 13 Dec 2021 02:27:50 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Mon, 13 Dec 2021 02:27:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n5kpZ9kq39dWT2IH5W/oQGxF2HSvQ9wysK0+ndv/+6exNH34AX+ulo5lYUdzEtpFwpTXPtVQYDcfPtWjTqqjRfBF8jA4Q//NAVpwcLaZYNdOfIkg2k8Ug5MjK1jGQ2X3KMLj8Vh2Vs/1FnmKGXe10KS5xjySiNRN13c7xovReBN04htwwTloUe7OK5Va0MM8tuFZ7GXGWV8cBD3eYERInfT6yVvRLRiQG9WmrSERdjmm816nVM9wyr2zHY/xsJm/G1XyJ4/9TBY/rD1s9pMWWG+3mXfa94DUlTraoolz5qbHU2Pf4UbJYLBWMII9i9sJ02jMGheQpfWJMu3piWxWag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=reS0kdiGrNca1DG1v4rmFK0BVyO7s/UdfNQFdmGVzsU=; b=LnH6t5RQDS8qMJrxNKi96Qd1HPBL3rC0VYypBTaDWHwCJD0WZTfql7ZL4aPsvoXToFxaWGDGERxXfbIscyNjoIKCSjXClchku4f3v+fFD3iaZnUAZp7vvyD+iQ2nU1wxV6vUdhrKU2Ql6bTb5ACzcmP709rT0MpfXGZvNwohA+RDAPgvkdk3a7gk11eRjr9kKmsksmCnacCW+wL9VGTJE1zovDlBdJYHy9Ib/ZITVtjwgqsGqQq2vlxKm5nL59QB4xrH/Fs9GfX/Z3jXj0e4Ln0Rncp1XhOdLRXfu6vkoysSb72T5p/pa2VKX0UupaBuuk9FaOQxioRh8W4CSFiYBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=reS0kdiGrNca1DG1v4rmFK0BVyO7s/UdfNQFdmGVzsU=; b=mMiVHuROAzp4DUQLrksNVTu2qgnenr1C4yjPG8UYksdzsAuaodEeAMkHn/V7s/S0Bsy3Unwr903449DuN5Xa/2vtG2hvVSYrVVo8GNP9h6IFaMHGx+H5WSsfZDCU7CW49IPOjbjr1A/49wk4/h8nqxJXA5YiZQ+2hd3Hyx7MSDY= Received: from SA2PR11MB4874.namprd11.prod.outlook.com (2603:10b6:806:f9::23) by SN6PR11MB3533.namprd11.prod.outlook.com (2603:10b6:805:cc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Mon, 13 Dec 2021 09:27:46 +0000 Received: from SA2PR11MB4874.namprd11.prod.outlook.com ([fe80::5c96:23c3:4407:d3b1]) by SA2PR11MB4874.namprd11.prod.outlook.com ([fe80::5c96:23c3:4407:d3b1%9]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021 09:27:45 +0000 From: To: Subject: Re: [PATCH v2 08/13] dmaengine: at_xdmac: Move the free desc to the tail of the desc list Thread-Topic: [PATCH v2 08/13] dmaengine: at_xdmac: Move the free desc to the tail of the desc list Thread-Index: AQHX7/6cGW4RS1ZeJkC0M7VpsR3jOKwwJ2GA Date: Mon, 13 Dec 2021 09:27:45 +0000 Message-ID: References: <20211125090028.786832-1-tudor.ambarus@microchip.com> <20211125090028.786832-9-tudor.ambarus@microchip.com> <8523ca32-d36f-6e0b-0115-5e07553396f1@microchip.com> <3d57524a-6d88-3027-d8fb-94417ae0b4f6@microchip.com> In-Reply-To: <3d57524a-6d88-3027-d8fb-94417ae0b4f6@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7267c9b0-b47f-4bcc-658e-08d9be1ad27f x-ms-traffictypediagnostic: SN6PR11MB3533:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HTGWYxSrI7RRjTja9uSYiwHdfsZtOrSO2tye6t0K8dmLZXAoX9M2ihf1fWxyAkgaFwhzLcoXknPcURXcyowKIHWI3iG5egph9XWqzw9bWwXXF1EmHEvq73jBi07AN5Sf99dN4Bq9lamreWzgWmuXcDgoiB/gK8iDyLkGbas0TcfwMkK1T7zaVxw7Dq9r/tGwlju2igBLwAypizoeOTAcwNPctiyyy6bNnbCMA+eC0NE6WqL43wz+jCReXkKmQH1TENxK/Cj4VH8H8bsVjC3+92kVqu75aZKCjVUi0p4lCVUq76r0+PxeFxUUhBv3iy4RMicbIcdnYf+9rlweGxeuLVEsTemXyr8PwLFt05zVCdCpcZk6AhjTkUblSMwu2j0+E84KqXyuXajVejRKnS3r9HcoRcQvBCGbS/r35yA6c4oxksOjJ/CcLSaZphzb5TV5yx7s0lXPHL8sd8Nmf5+WulCtlx/SnPPC9e8rmZyc2ALOWCLFBiQMgpPZ3ke7DqnCUfyNPk4x12VAi5ukhXxbEBEINFV2tCDRFe9D1W02lEyJCfnJKFedoRi7Yh4cAQDyoVpdfM3s93imb/XS5BzO4y4GZ5+R0NC9M3qXzy6KXcQtfbQMhk6+kR6G/YMdXXzLo7UXoGlymhl4+wS7r5BOe6Dm5YElT8ySrNQGh3dYrYHPwEEC2gxStggWYO7YHGrLcGDYIhJgHcT6MrfdLJ82JEYB/uo+ydkIqE7Vspb43C4798Is7ztAPSt5G6pv8aXxMvk9ltNX+4WLIbc+kWcH+w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB4874.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(91956017)(66556008)(6512007)(66476007)(2616005)(6486002)(66946007)(76116006)(6916009)(71200400001)(8936002)(31696002)(316002)(66446008)(36756003)(2906002)(64756008)(83380400001)(38070700005)(4326008)(26005)(54906003)(186003)(86362001)(508600001)(122000001)(38100700002)(6506007)(7416002)(31686004)(8676002)(5660300002)(53546011)(45980500001)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q2g3dzlpV0lkNm5QbWFOcU1ZOXV5WlNZeVlhWEZzRzJjM2d1YkxhTHpkOWtE?= =?utf-8?B?VmdXc241cDNtNGpvRG5LRTByOUt5RjVFZm1XYTBKN0VNOXREVytFU091dC9a?= =?utf-8?B?TXRtUUxBWGtma0Y3T0xHcy8yZWFvdk9UajJ4OUxNcktucDYvcFJFSkdwSEwy?= =?utf-8?B?bGdTTUVTazNrMFJid3grYzFiOXU1VVdWQm96UUJwL09kVSt0c3ZLK29nMmZI?= =?utf-8?B?Z3NNTmZHandSZE5hTnk0elZTTzRLVXQxdEpvL05VVWd4c05uN3ozdm1vUUFw?= =?utf-8?B?MmpicElhdGRRRU5KZW5uVkJMQW4xWFpqZk1FOWpsY01iUGJKeWlzbEY2UTgw?= =?utf-8?B?U0ZmVHRKWkVQTG5UdHplVDkrR1hveEJlVkExYm5ZMnQvTTNQenFaeGhQdzdr?= =?utf-8?B?VEVlRE9uYi9CTUdTbmpsMjJONlYvMzVPRUtuYVZ0YTJOZTJtSVd6Q09vMGto?= =?utf-8?B?M1ZTK0J4R3dlRk5oeDFqMm1YRHp5T1VkZC9oR2MxL3ZhWXJvSlVNenJqdkNX?= =?utf-8?B?dTM3WFp1L08zcjVxVHBtZmNUWVR1N0tMRGpGL0pWem1sZ2l3MGxXUVNIQ0N0?= =?utf-8?B?OExlSDhtTlhaakdQL3lFL3M5aG9PdVBzaWIzOE1MM1hweWFYcFlVWTFEWkYy?= =?utf-8?B?eGRkWk5Yd3dUa2hpL1lDM1E2VGF6NEg4YzM3THlURW9laVMyKzFjUUIvRy9R?= =?utf-8?B?dXZURHloVFlIR01zNmxjeHZQVFJWOW9NVXZIam01TVd6bnRrVlN5aHJIeFFG?= =?utf-8?B?MjRESjBxM3JNMGtVY0FEZlhhSUZuUlQvaklCSXNPbnpUekx2VDg1R0U0eVpu?= =?utf-8?B?MjR6V3NwY3IrNWxKV3cxM2srWWRheE8yU29pa2k0ZHFTQ3gzZEF6emtLQmQr?= =?utf-8?B?UmxlamVLWElHNlNOeU5sT2lPRmVQL3JlSi9VWkNLZlJMcFB5dWF5a0RNZjR3?= =?utf-8?B?TDlvYk14M253dW5ySE5aVG1xMm5YWVJVN3RHMFFvUDQzY0hwZEQ3dmVDaEhK?= =?utf-8?B?cFpGa0hnSW5sZ2dRclBMWmFhRFBaOHVUU1Qyb1lRNTF6UXZRTHYvVTZLVjZy?= =?utf-8?B?WThXOENReG9qQWhQc29rbWF1VWx5VDVNU3Z4Ym1wZHVIS0NxaHA3ZWU2OXRK?= =?utf-8?B?NDhNdmY4NjBla2c1a2cyMWtkZVk5VGRadmc2eDNzN05Bd3dSRnB5QWZrdk5G?= =?utf-8?B?ZENSZCtTOGhCZGVVcVgzS3pPbVNDZDF3S2N0U2dWVVhMbktxQ1BvRldrSWs2?= =?utf-8?B?WkJocXVpQVBqSmZqQ25Ldk5LVEp6T1ozQ0tMclE2dXFJTVZnSlVValJRK1hB?= =?utf-8?B?ZHplNlE4b0Z2YlVSUGFwN2tmcCtNZ01aeEs1QTFHU3FkTG9DWXVNQ2dScVUv?= =?utf-8?B?QktIejRUQkxBeXRFcElpRmEweTBFV2xUU1Vxc1J4Vm5hYXNodmdzVXJXOFRx?= =?utf-8?B?Uk9mc2tmVzM0ejgvdlVCSXQrMGQwQjdvZjE5eitLdlFiNnJCMDJnTFBWcUo5?= =?utf-8?B?WmFRdEF4bkh1QVI2YUdWeXNtSS9CcFN5YVVaU0dqeGtsRFdOTk1rUzdvTlNp?= =?utf-8?B?a2t6TnhMUitidHdwYitGN3kvTE5JdkpRRFo1MnRTYjNzMGQ2UGs3OTVoWEJq?= =?utf-8?B?RVA5SmRubjQwQXNCQ2t3eE9RZkFxWVFOUk1KV0ZLMlM4bkdsN0Zsa1RiUFc5?= =?utf-8?B?K1g5NmpaRlk1eEVIYlByeUg1azh3WU41WFNnMDhmd0gxNkx6TWF4T21qanlz?= =?utf-8?B?Tzc5bUQwS084b1JOckxrbGoxQ2QzZ2tzaTMrTHlvOEZSRkF1dUZ3ZitMVjBi?= =?utf-8?B?SXU0YzRVbUt2dzJINy82ZmpyMkRlazZlWFRINlVCcVJ1YzY1Y2pGNlpNNTFl?= =?utf-8?B?RHVwZkJBZFp2bko2U3p6anhsM2FpMGt6K1hGZkh3eXJUNS9aeXhZeUk4dDI3?= =?utf-8?B?WUZRUCsyL1dqZkxRWUY4U04rM0VkUTF2Njk3aE1nNis5R0pxbVdSUVZvV0RS?= =?utf-8?B?a1E0WEUvNFZJYkdpUUN5UVVRcTNSMjJ1ZEovYWM1ZFBITWNVNktEN3ExQzF5?= =?utf-8?B?Q3V5WEZjbEtIRUJaTWlLd3pPVUdld1pFdEJ1TVJmZjNpdTdFNC9udnhISjl5?= =?utf-8?B?SG5yVFN4WlZjaEVvZ2dMTE9VeDd5UXZvaEgwT3V4dlZpVzg0UFNEOCtWODlD?= =?utf-8?B?Mk9EU1hCYnBCaURHSmtHRURHL1pPWExnWW1tWmw1bmd4V2NJMEFhSWJQek1v?= =?utf-8?B?L09OeHpydUw4dUxOdmoyNVFLSVdRPT0=?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4874.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7267c9b0-b47f-4bcc-658e-08d9be1ad27f X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2021 09:27:45.8721 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M1ly+KiAoRfUgRNM4FSgJcxIk9TsJ/ERwf/8sKEW6/JgmkPEJek+iYMP762obGWI3Q/FbGp1sAiTVi+BOFas9mOSIifRQMMO+GRXGdghJ9Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3533 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_012752_284226_1E811065 X-CRM114-Status: GOOD ( 18.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, richard.genoud@gmail.com, gregkh@linuxfoundation.org, mripard@kernel.org, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, linux-serial@vger.kernel.org, dmaengine@vger.kernel.org, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/13/21 11:22 AM, Tudor Ambarus wrote: > On 12/13/21 11:00 AM, Vinod Koul wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 13-12-21, 14:29, Vinod Koul wrote: >>> On 13-12-21, 08:51, Tudor.Ambarus@microchip.com wrote: >>>> Hi, Vinod, >>>> >>>> On 12/13/21 10:07 AM, Vinod Koul wrote: >>>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>>>> >>>>> On 25-11-21, 11:00, Tudor Ambarus wrote: >>>>>> So that we don't use the same desc over and over again. >>>>> >>>>> Please use full para in the changelog and not a continuation of the >>>>> patch title! >>>> >>>> Ok, will add a better commit description. Here and in other patches where >>>> your comment applies. >>> >>> Great! >>> >>>>> >>>>> and why is wrong with using same desc over and over? Any benefits of not >>>>> doing so? >>>> >>>> Not wrong, but if we move the free desc to the tail of the list, then the >>>> sequence of descriptors is more track-able in case of debug. You would >>>> know which descriptor should come next and you could easier catch >>>> concurrency over descriptors for example. I saw virt-dma uses >>>> list_splice_tail_init() as well, I found it a good idea, so I thought to >>>> follow the core driver. >>> >>> Okay, I would be good to add this motivation in the change log. I am >>> sure after few you would also wonder why you did this change :) > > Sure. > >> >> Also, pls submit serial patches to Greg separately. I guess he saw the >> title and overlooked those... > > I received a private message from Greg informing me that he applied the for clarity: Greg applied just the 2 tty patches, not the entire series. > patches to tty-next and that they will be merged during the merge window. > So I'll drop the tty patches in v3. v3 will follow and it will contain just the at_xdmac patches. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel