From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42B24C3DA4A for ; Tue, 20 Aug 2024 12:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yRXFvGiTIgNAw3onPOAc3UTwAgo7ubvAn9a6lT9hgBE=; b=mylFC3/RQgXoNRnGzFQoB6jUEa NZxybUYxdhY9z3E9UIMxMJ768Rs3SldZox3NoyIhTPV2PVfw38NIoUhGXoBtILEdWCnnSQfJa199c kweNWeTnD7EO7ytGxmbkAvv8FDDg1IiIw8MDP3I7P1Eb//MBrKVhrxunnva9r6A400E7qyQ+f4yQW 7fhQOlMp0j4n4ZoavMnFkZM0CAEdhvqRYmpLT2+Exc4WA46bQ3ejmqViD9Nd06JIlUMJkrknhhrej LLGFQ/Wlc66hYX1XYF2EC9bi4NXQDz+k4/dhJQjjfe7uTJixvUC7aLpZOBxOFV6Oen3q3Saz28oZ/ r98KbPGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgORD-00000005HGw-2Ur3; Tue, 20 Aug 2024 12:58:15 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgOQV-00000005HCg-3hqJ for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 12:57:33 +0000 Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Wp8Zm1n0Bz1xvTv; Tue, 20 Aug 2024 20:55:28 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 575C2140361; Tue, 20 Aug 2024 20:57:22 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 20 Aug 2024 20:57:21 +0800 Message-ID: Date: Tue, 20 Aug 2024 20:57:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v3 2/3] arm64: Prepare to switch to generic entry Content-Language: en-US To: Kevin Brodsky CC: , , , , , , , , , , , , , , , , References: <20240629085601.470241-1-ruanjinjie@huawei.com> <20240629085601.470241-3-ruanjinjie@huawei.com> <32a3bb02-59b2-432d-a75b-d7951971cda6@arm.com> From: Jinjie Ruan In-Reply-To: <32a3bb02-59b2-432d-a75b-d7951971cda6@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemh500013.china.huawei.com (7.202.181.146) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_055732_214305_C30794A2 X-CRM114-Status: UNSURE ( 5.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024/8/20 19:42, Kevin Brodsky wrote: > On 29/06/2024 10:56, Jinjie Ruan wrote: >> -#define on_thread_stack() (on_task_stack(current, current_stack_pointer, 1)) >> +static __always_inline bool on_thread_stack(void) >> +{ >> + return on_task_stack(current, current_stack_pointer, 1); >> +} > > This looks reasonable but I wonder why this change is required (as the > commit message suggests)? There seems to be a compilation problem, but rolling back this function is ok now. > > Kevin >