From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76E3FC433F5 for ; Tue, 12 Apr 2022 12:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EizDK1EAxNFSyp3sKKWvr/tRowYzga0e4lSDEV7rBoM=; b=sCwZYOuw8nBEqa PeN/rr8ZxLizl2aOWB/RznDW/L3rRHFCPpJG1VLHs4VwPrUsyeHdqjS7RpFDGyWLKKOhMdLVhqGqi ZyYCziJhYzgOl5r689196YX+B2R2fpwrVbAZX4MGWVZvmhKNuSnziICSIZAUBpHkknjnBsdZEFWUc kFQYQS2VMGCyCz3CBqm4X+/De5Fj2lgNpIQqv0qe0DKgNxBa6qQwaECmuHd6zp9nA9aD9MmjkymGY d6Xb4KI6rH1xbGcXp263Kd/qgwwq5JK1HhJd/FF7wfKXAA7cy/1OFyAI344NF0jaGYbHkDmCe5IxX PP3fpiWcpKS9teIawpGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neFII-00Dxvc-3W; Tue, 12 Apr 2022 12:06:50 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neFIC-00DxsS-M7 for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 12:06:46 +0000 Received: by mail-ed1-x534.google.com with SMTP id b24so22041138edu.10 for ; Tue, 12 Apr 2022 05:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hc3hJzzcC4rxfq/Wm1m02VMwP6AM+k8j0LB5pY+4um8=; b=Kkrkl9jK9ioUkCwZ8J7Ws81Yvys20F3b57Rkqr36ePxZTE4if+64SKIq2JFxYAoBIB IXHl8reCWkS2mQ/Ov3b+s3ZSeRmOvzOnPu2CxiohJ0l+eOMB6IIif337JxQjbkZJUCig b/vEEKSNw294cuJt6NPxKfTOa1RTK+LHbOeL9iz0ib8dTKAMKFMfqZ/pNHMHAp8xxm/d YAs1Seuy9FrR6kcMIsJy9rBxCYhz857ozhsEeAwCVjjaUDbAo3TJE+ydwzFxI7IvYY1K zoq8qznpV/nXNTL3TQ6uiYm3IDhw8UgPBjv0RnYaDZCacUv2G8MU1fAl4XWy1gnqIGX4 9aIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hc3hJzzcC4rxfq/Wm1m02VMwP6AM+k8j0LB5pY+4um8=; b=gJq01bmWhILe/kbLFn6tbfR//zn+PO74fgk+h/2b8o1uR/oKhqlBVwLUUh9muTA9Ie M3aUUsoygaCQ+kQEPF7Izjr26IUE8cPFb391PPKyDbsjAuAn5UsRKzITQ4aSzSZnbonp hTRquZuHGUgje28hqTNsIirt4So4rDJvXnKrsunQYWGg+f8cQuVTly0Mum+wEah4Zxy+ zq+1+YBbT7O0WwPTRs3tYPoNcUfFBktpZq1PXAZLxY4LpCG1ltNPspoy9DPLYej8okeo P/rbgYzjsAFujXNENLkS3WxT7SDS+wdj4Y0MqW4U4m23Fyrgt1vXw++dR+Z5ARCuxgPz fF+w== X-Gm-Message-State: AOAM533b0YWjE5iwJpewkMhrBf+DTeH8jfp6iR/dTBu3/GHSlWeEKKWV gvdU6cQ7O2/BFZo6/VX9FKKjJw== X-Google-Smtp-Source: ABdhPJw1+fn4L3/9KnSUAOGZMWbMxDlB6+K6ZqEZZgJu2zH/gn+0JE6RHZnqYBHYxnu0m3IYGndO0g== X-Received: by 2002:a05:6402:14b:b0:418:d06e:5d38 with SMTP id s11-20020a056402014b00b00418d06e5d38mr37384606edu.90.1649765202629; Tue, 12 Apr 2022 05:06:42 -0700 (PDT) Received: from [192.168.0.195] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id a18-20020a170906671200b006e05929e66csm13079003ejp.20.2022.04.12.05.06.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 05:06:42 -0700 (PDT) Message-ID: Date: Tue, 12 Apr 2022 14:06:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/2] dt-bindings: rtc: Add TI K3 RTC devicetree bindings documentation Content-Language: en-US To: Nishanth Menon , Krzysztof Kozlowski , Rob Herring , Alexandre Belloni , Alessandro Zummo Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vignesh Raghavendra References: <20220412073138.25027-1-nm@ti.com> <20220412073138.25027-2-nm@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20220412073138.25027-2-nm@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_050644_781457_228734C9 X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/04/2022 09:31, Nishanth Menon wrote: > This adds the documentation for the devicetree bindings of the Texas > Instruments RTC modules on K3 family of SoCs such as AM62x SoCs or > newer. > Thank you for your patch. There is something to discuss/improve. (...) > +properties: > + compatible: > + items: No need for items. Just enum under the compatible. > + - enum: > + - ti,am62-rtc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: VBUS Interface clock > + - description: 32k Clock source (external or internal). > + > + clock-names: > + items: > + - const: "vbus" > + - const: "osc32k" No quotes. > + > + power-domains: > + maxItems: 1 > + > + assigned-clocks: > + description: | > + override default osc32k parent clock reference to the osc32k clock entry > + maxItems: 1 > + > + assigned-clock-parents: > + description: | > + override default osc32k parent clock phandle of the new parent clock of osc32k > + maxItems: 1 Usually assigned-clockXXX are not needed in the bindings. Is here something different? They are put only to indicate something special. > + > + wakeup-source: true > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + rtc@2b1f0000 { > + compatible = "ti,am62-rtc"; > + reg = <0x2b1f0000 0x100>; > + interrupts = ; > + power-domains = <&bar 0>; > + clocks = <&foo 0>, <&foo 1>; > + clock-names = "vbus", "osc32k"; > + wakeup-source; > + }; > + > + - | > + #include > + rtc@2b1f0000 { > + compatible = "ti,am62-rtc"; > + reg = <0x2b1f0000 0x100>; > + interrupts = ; > + power-domains = <&bar 0>; > + clocks = <&foo 0>, <&foo 1>; > + clock-names = "vbus", "osc32k"; > + wakeup-source; > + assigned-clocks = <&foo 1>; > + assigned-clock-parents = <&foo 2>; > + Unneeded blank line. > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel