From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89206C4345F for ; Sun, 14 Apr 2024 06:12:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/bJShD4/mqgmWtsZfUCpzMIiV+VpjDxwrnGnwgqsD2A=; b=Rk4S0UkGfBNFo6 J/rjRLhGse6zFuW9rji9EV9fiDJC4BHWG4kWb5JqHdPBh0NnaPiQjhM6H3O4qmVgPCERIgXLYv1xb V2wlCIctssXs0Jbg91ljGzQj8hvlPrbmGgJzYtDtXLDZg1RKIyJuJjFZPy/q3JPvOYsuJUUUeX0lv boi6+J+O6LOs7yRzrAoU+YNnZ4COyIKmjZgQXvrGRDdkZ8tvCrREAKRNQF1YtGraC/W4Sj9QuuCWt vZpoDGMzpcMH/fKXIu/7v838ATpQnan0OuBLzHsXXeQmwVDtQLUk+OCO9aVCmFLO5fgraR7FpCEoo b+GctOqi5KnWVhlHzD4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvt5o-00000004k4f-3hrd; Sun, 14 Apr 2024 06:11:56 +0000 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvt5l-00000004k48-3O6Q for linux-arm-kernel@lists.infradead.org; Sun, 14 Apr 2024 06:11:55 +0000 Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2d485886545so32865411fa.2 for ; Sat, 13 Apr 2024 23:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713075111; x=1713679911; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=cd1B/deojel3okqrmPvn65KeF4SUoVm8wG0roldbzJ8=; b=aIpC0zu3o1xn7n2paaG/WpGjj4gHD1F5dYRitV5y8MQjTGg3ymhUjhbOLCEOM5Tay7 pxXxNo6D4WC1TJernLR0Lq9B78eqPXb5eM5CVy3B4r21u55wb1kB6/JU+IflEfvXeDtH nUTRnTNT7SLs1n2m0hYHB3cYAvAZdKuQlKRklUX1fW5S6ljUxrJcli0OoDdiheFZP4m6 68LcBAVv1a7sCISxnofdH41jX4ewpSvb+3IpWiWQKRwz93TBaaleZ4IGF2It0PkJ54N1 Ppi/GbtU+6aAXgQ3rXpcu/4NrizK+V/BS2GzJisMYqHS5y3LOa1RB+AZYAMsmHHbvbVK w/0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713075111; x=1713679911; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cd1B/deojel3okqrmPvn65KeF4SUoVm8wG0roldbzJ8=; b=PC/5QDJ7rw5ZSP2qgkmMYqiWZyAG7opql11jEAtr8a0IMnByZcScXFNBszgNKXyW+D hpKYWlqHQwdSMEu7VcIljDw1FA692HwwyKQFzg+DpuRnIj4KyXmstMBcPdSrNJ/aiBtg 3AnRqzlPB6PilqSQHDxX8Ch7dKzJWqvNPqV5q/Br5wSUqUw0A61/WaXddhG3QjJjCC8T SIlNdZF12BggsibnqVfzYn8oRvcCPz7tHMFruyH/5evRQbCKS1vAwBFd3bj9la0gPijW w3cX21phY9XTzCzCam58EXKfbes9TzvInNMm0km1RQ3uN14E9Jj3422c2AWcqdGP5k/x HKYg== X-Forwarded-Encrypted: i=1; AJvYcCXEL5NwzjXH6tE4zQitZUu2TXv+zlLLHKPxmI6t5afeu3Tt3usia/X4U6i5cPJbYmFzPmfC6mHkRwzs6KgFdfLfOngFzk4vHrC2BCshE8MHxTe9vZM= X-Gm-Message-State: AOJu0YyFxrGk+K8F9n3/L2nyfol2vcz5+RN+vtqwkGxLfcjKDMKoSk6i tuschMuX3gfF00yAvWRjqTQlwdnZ+MHr1mgh6S+oFrEdYb4j9Ba0MzpkqyYxsg8= X-Google-Smtp-Source: AGHT+IGatFcyjx4ZoKtHo2CnivNndKMYuB3RNG73Saq12WIxXbSVKNPi4KmUQ8kkEUebJL5Z4b4fCQ== X-Received: by 2002:a2e:8e88:0:b0:2d8:6ca7:2165 with SMTP id z8-20020a2e8e88000000b002d86ca72165mr4875055ljk.46.1713075111114; Sat, 13 Apr 2024 23:11:51 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id kf20-20020a17090776d400b00a51e9b299b9sm3805488ejc.55.2024.04.13.23.11.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Apr 2024 23:11:50 -0700 (PDT) Message-ID: Date: Sun, 14 Apr 2024 08:11:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] dt-bindings: mmc: Add support for BCM2712 SD host controller To: Andrea della Porta , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Adrian Hunter , Kamal Dasu , Al Cooper , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Jonathan Bell , Phil Elwell References: Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240413_231153_898290_3CCDA5ED X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/04/2024 00:14, Andrea della Porta wrote: > Signed-off-by: Andrea della Porta ? And what is being done here and why? > --- > .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 51 ++++++++++++++++++- > 1 file changed, 50 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > index cbd3d6c6c77f..6aa137d78e4f 100644 > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > @@ -13,6 +13,7 @@ maintainers: > properties: > compatible: > oneOf: > + - const: brcm,bcm2712-sdhci > - items: > - enum: > - brcm,bcm7216-sdhci > @@ -26,12 +27,16 @@ properties: > - const: brcm,sdhci-brcmstb > > reg: > - maxItems: 2 > + minItems: 2 > + maxItems: 4 > > reg-names: > + minItems: 2 > items: > - const: host > - const: cfg > + - const: busisol > + - const: lcpll > > interrupts: > maxItems: 1 > @@ -60,6 +65,7 @@ properties: > description: Specifies that controller should use auto CMD12 > > allOf: > + - $ref: sdhci-common.yaml > - $ref: mmc-controller.yaml# Why? Anyway, this replaces mmc-controller, doesn't it? > - if: > properties: > @@ -71,6 +77,28 @@ allOf: > required: > - clock-frequency > > + - if: > + properties: > + compatible: > + contains: > + const: brcm,bcm2712-sdhci > + > + then: > + properties: > + reg: > + maxItems: 4 > + clock-names: > + const: "sw_sdio" Not tested. > + > + else: > + properties: > + reg: > + minItems: 2 > + maxItems: 2 > + reg-names: > + minItems: 2 > + maxItems: 2 > + > required: > - compatible > - reg > @@ -114,3 +142,24 @@ examples: > clocks = <&scmi_clk 245>; > clock-names = "sw_sdio"; > }; > + > + - | > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + mmc@fff000 { > + compatible = "brcm,bcm2712-sdhci"; > + reg = <0x10 0x00fff000 0x0 0x260>, > + <0x10 0x00fff400 0x0 0x200>, > + <0x10 0x015040b0 0x0 0x4>, // Bus isolation control > + <0x10 0x015200f0 0x0 0x24>; // LCPLL control misc0-8 > + reg-names = "host", "cfg", "busisol", "lcpll"; > + interrupts = <0x0 0x111 0x4>; Use proper defines. > + clocks = <&clk_emmc2>; > + sdhci-caps-mask = <0x0000C000 0x0>; > + sdhci-caps = <0x0 0x0>; > + mmc-ddr-3_3v; > + clock-names = "sw_sdio"; names *always* follow property. In every DTS. Please fix youro DTS. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel