From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFA9EC433EF for ; Wed, 20 Apr 2022 06:50:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gV6LOFYwWTl+FQ3WibjzLKIHXEdqjEKVc32SxMRkz1M=; b=HvxvjWMYMqt1pP VxY6uA5pa1AVLcCCKsdWWnjjq8wz+whRSJIlL4YFq+OCm8Yqw7Vjcs871WvLYPlLrXSNI2tS1fZMP +vmqE3ibf/BVvoEAYDU2Q1uLzhEWgf45+e730hxvDdu0fkronLOTykgmzxw73QdHrTMe1GfmwBwfW mq3M8JOoF8TdlwsVcB4v1dfMgoS7zhEnZGp9QSLqc+g//SYnvG0pV0Hgcu4CzxVkujXfYfz0S8oyE 28w5UIFXQT+69asoW10/pLAqMMDy6PQTESpmMrBEmlWxrcTRSHarxbInIY6dqSrKM32D2urCrq4bL iDlyX7LBZXZ2SyPOdLPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh494-007d0V-9Q; Wed, 20 Apr 2022 06:48:58 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh48y-007cy9-Id for linux-arm-kernel@lists.infradead.org; Wed, 20 Apr 2022 06:48:54 +0000 Received: by mail-ej1-x633.google.com with SMTP id g18so1447053ejc.10 for ; Tue, 19 Apr 2022 23:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=9uzVgdbnNBXZaj+xly+bx359WI4zRoQI5FjtgADEBW0=; b=S1hEIoiDmJQ5F60K6iW2OrVRkegrcBBnOiVG/QccBRbUzlvLB7dozEncz0TnysxDv2 FNqn0DTAOA4Q2I7V8GVKaw1i2NPEeQXKphyrqggpzxaDYUSClbIhcQp0+9i6iYSFu7bS 3izRWeFlXNNCXQssXVTHnL4FoKkdgGPoQ2vQMrWlaKAobfQmVkpSXD8j7qGeGRSANGYD qSiNfQSnN7UgnguVZfXmP7KljNKkZ8YHOB98cA5LtbxLKR3AUqxhR2xNu8ZcjoeWHIOB keopxTJEGVgV6/z+1eDrgrEgVnXYMJyKfXrVB7Uyf5nlhLCH30oUjauesWLm7jKti+aS VafA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=9uzVgdbnNBXZaj+xly+bx359WI4zRoQI5FjtgADEBW0=; b=QxLpz5wNe+VZSo5jzUu5/nFqiFTyMLZPGnnHSdrpdD9o8ALrVlV0xPI/2NFRbju3pQ zFq33cUV3V9Uzo6RRESGpvgE1+j0ZUNgjDTvuT3rn0tVag8+arnP4PspUs0aot+Vnwto 9eG0Ic+iduOp+bzmie1rej98yJH4CO0z9jb3QlI5PFZykdewtpSN99KRC8colFECYeSa bORQ2WWFFo35cm6AkLfO4r+hk8mKqoMKE9ltFC9gVZVtRSlWVT+FgmzMVTR565FU3v5n IQs7aMvidik4SYTeH8AM5Bm9DFEM2G25tjHOYl3CBjWR2/+KOGTjumyV1JLGAm191zND i6Qw== X-Gm-Message-State: AOAM533X2y6zdiKjBCu+ovxgJpETfAZOaX9vK1s21N1DwKPAYqYuPiC8 R2d1QPUEj6v/6pFxn7ilAnZemA== X-Google-Smtp-Source: ABdhPJwWVmNshJAW0tGWYuRLU9jbNedM/km5ShG0Ei7YXEVHAQ+JyhA9HCOy1DRMF98ygrtJdvPgvg== X-Received: by 2002:a17:907:d16:b0:6d6:e3b6:9cd8 with SMTP id gn22-20020a1709070d1600b006d6e3b69cd8mr16733035ejc.94.1650437331372; Tue, 19 Apr 2022 23:48:51 -0700 (PDT) Received: from [192.168.0.222] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id d6-20020a170906304600b006ef5da1b1besm5171288ejd.221.2022.04.19.23.48.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 23:48:50 -0700 (PDT) Message-ID: Date: Wed, 20 Apr 2022 08:48:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/3] dt-bindings: arm: mediatek: topckgen: Convert to DT schema Content-Language: en-US From: Krzysztof Kozlowski To: Yassine Oudjana , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: Sam Shih , Stephen Boyd , Ryder Lee , Yassine Oudjana , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220419180938.19397-1-y.oudjana@protonmail.com> <20220419180938.19397-2-y.oudjana@protonmail.com> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_234852_668541_DF2FC9D6 X-CRM114-Status: GOOD ( 17.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/04/2022 08:47, Krzysztof Kozlowski wrote: > On 19/04/2022 20:09, Yassine Oudjana wrote: >> From: Yassine Oudjana >> >> Convert topckgen bindings to DT schema format. MT2701, MT7623 and >> MT7629 device trees currently have the syscon compatible without >> it being mentioned in the old DT bindings file which introduces >> dtbs_check errors when converting to DT schema as-is, so >> mediatek,mt2701-topckgen and mediatek,mt7629-topckgen are placed >> in the last items list with the syscon compatible, and syscon is >> added to the mediatek,mt7623-topckgen list. >> > > Thank you for your patch. There is something to discuss/improve. > >> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml >> new file mode 100644 >> index 000000000000..9ce9cf673cbc >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml >> @@ -0,0 +1,60 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,topckgen.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: MediaTek Top Clock Generator Controller >> + >> +maintainers: >> + - Matthias Brugger >> + >> +description: >> + The Mediatek topckgen controller provides various clocks to the system. >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: > > These are not a list, so skip items. Just enum. Rest looks good. Actually one more through - this looks like clock-controller, so please move the binding to ../bindings/clock/ directory. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel