From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D41BC32771 for ; Mon, 26 Sep 2022 14:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LWU24S1Iz4eeOK27Kjcg2MF4nfbZzmnhPb89g39PqTQ=; b=FbyF/aMB+V4Wz0 2fjTiEeKpSayrfjyDIaM1/Z56wS0A28mAQ51lCE/2yD0oTssaW9jC/wXPROvodrGGk2+s6hSiyUee aH9qnRNkynNugZWstIAy0KrDbPjnZt6JxlAKhuou/l3Nq9aSRvofEacbrzbh3IRylJMuIG6R1zEcb SHoKCuZDZbw1I52/ECZVrwIy6hO8Ag2F64PiHP5fljlcwIUq6mbGIH8tXfpTNaTqQfcMQCVgNi0d1 7WIvV11gZ2C5Fuvwxs6n0N79nlFaeqEpAQuKXTnbPFtIDSQgJVsnqmi6M8tOWMeQTEcJHe5wDDdhl zRVeUE9rK6C+DCAA9/ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocpTK-005Vim-72; Mon, 26 Sep 2022 14:52:38 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocpTD-005Vg1-DJ for linux-arm-kernel@lists.infradead.org; Mon, 26 Sep 2022 14:52:33 +0000 Received: by mail-pj1-x102d.google.com with SMTP id j6-20020a17090a694600b00200bba67dadso7047658pjm.5 for ; Mon, 26 Sep 2022 07:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date; bh=XqslfmbW07ju9IFhgHQRoaxnh119HB9GroIqSODrifE=; b=R65VQeSNaeE0CR46yxIyKozGRffTNT9NvActVqL+W122uFMn/u0sS/Oq2m+NeQ7cRQ BoWvzm5oYiKlbnMHm2dnAV+3RNcY4JyDoBM++1PfCCA8bltRVdm4B0vtWXYWyXxsdlTX lupND7PqhU3qPCkgqUH6yv+ncilEkFhgr3/isz8JhdyFumeKDfRIPdU6Y4aRjIFkMRxO HOxZWS5TTPOA6lwb+d/FpfD3Ew2lgqm+GYGiiK3db5FwJYWenkwWWeSUgRbXJKyHYmxj t7ulmLy0rFLbpFMxvUJ3RwFqOswChA+TPdmSm27sd5aM1rOlmmUaiMtws4vbRniMi5Av nJoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date; bh=XqslfmbW07ju9IFhgHQRoaxnh119HB9GroIqSODrifE=; b=H8BVtRQlHrVHjtLwDZAguyiQp+jw3ZVam4BXCS/v25tcHFHNLpgXyEK6QdgbNspHGw oomZceAlYgmy2p9AGQLBPyjp7qtmFOy4BVpwjSexH4uxcTojB79da8IwvP4M5lXHv+xx 5qVtLb6E/hFWXFkCXW691oW01+y0pqdGsMmvySMm3x7itRNUOLBd/G8QD9dRWOGfR+X/ 3mehBkzIlKHZveo0J3TgGZvMH9dlPuBc8j0xpKYw7ojYn/EYL8jNjNTdwMUmKEfZqxPa qjtWvfjxijCknfUdWt5aSXfc4gRGZQuKNyXnMqc1uuLvo3ywjvZq5RmemP+iKZvDHVlX h3OA== X-Gm-Message-State: ACrzQf1kDPAlUo/lTdyjHHDrpp3fEx0JfyxR6rJIkQ+QakRg3KZEZefn B/Q07sI2RFHYcDcGUgxQqXM= X-Google-Smtp-Source: AMsMyM4ub4gfuQcnvKuWIFAZSMIE6mm0hvcAR6kHiRsk2FgaosM/ZyMENPKmotKiaR+PgbB6VpS5uQ== X-Received: by 2002:a17:902:8c81:b0:178:1701:cd with SMTP id t1-20020a1709028c8100b00178170100cdmr22755171plo.138.1664203949831; Mon, 26 Sep 2022 07:52:29 -0700 (PDT) Received: from [0.0.0.0] ([2a11:3:200::30d3]) by smtp.gmail.com with ESMTPSA id 141-20020a621493000000b0053dfef91b0bsm12160710pfu.205.2022.09.26.07.52.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 07:52:29 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 22:52:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [RESEND PATCH v7 0/2] sched/fair: Scan cluster before scanning LLC in wake-up path To: peterz@infradead.org Cc: gautham.shenoy@amd.com, vincent.guittot@linaro.org, tim.c.chen@linux.intel.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, prime.zeng@huawei.com, yangyicong@hisilicon.com, jonathan.cameron@huawei.com, ego@linux.vnet.ibm.com, srikar@linux.vnet.ibm.com, linuxarm@huawei.com, 21cnbao@gmail.com, juri.lelli@redhat.com, mingo@redhat.com, guodong.xu@linaro.org, hesham.almatary@huawei.com, john.garry@huawei.com, shenyang39@huawei.com, kprateek.nayak@amd.com, yu.c.chen@intel.com, wuyun.abel@bytedance.com, Yicong Yang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220915073423.25535-1-yangyicong@huawei.com> From: Yicong Yang In-Reply-To: <20220915073423.25535-1-yangyicong@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220926_075231_525998_386857DC X-CRM114-Status: GOOD ( 19.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peter, Does it still have a chance for 6.1? It should be stable for now since I got no new comment for this whole review cycle and it can still be applied cleanly on tip/sched/core. However appreciation for any comment if there're! Thanks. On 9/15/2022 3:34 PM, Yicong Yang wrote: > From: Yicong Yang > > This is the follow-up work to support cluster scheduler. Previously > we have added cluster level in the scheduler for both ARM64[1] and > X86[2] to support load balance between clusters to bring more memory > bandwidth and decrease cache contention. This patchset, on the other > hand, takes care of wake-up path by giving CPUs within the same cluster > a try before scanning the whole LLC to benefit those tasks communicating > with each other. > > [1] 778c558f49a2 ("sched: Add cluster scheduler level in core and related Kconfig for ARM64") > [2] 66558b730f25 ("sched: Add cluster scheduler level for x86") > > Change for RESEND: > - Collect tag from Chen Yu and rebase on the latest tip/sched/core. Thanks. > Link: https://lore.kernel.org/lkml/20220822073610.27205-1-yangyicong@huawei.com/ > > Change since v6: > - rebase on 6.0-rc1 > Link: https://lore.kernel.org/lkml/20220726074758.46686-1-yangyicong@huawei.com/ > > Change since v5: > - Improve patch 2 according to Peter's suggestion: > - use sched_cluster_active to indicate whether cluster is active > - consider SMT case and use wrap iteration when scanning cluster > - Add Vincent's tag > Thanks. > Link: https://lore.kernel.org/lkml/20220720081150.22167-1-yangyicong@hisilicon.com/ > > Change since v4: > - rename cpus_share_resources to cpus_share_lowest_cache to be more informative, per Tim > - return -1 when nr==0 in scan_cluster(), per Abel > Thanks! > Link: https://lore.kernel.org/lkml/20220609120622.47724-1-yangyicong@hisilicon.com/ > > Change since v3: > - fix compile error when !CONFIG_SCHED_CLUSTER, reported by lkp test. > Link: https://lore.kernel.org/lkml/20220608095758.60504-1-yangyicong@hisilicon.com/ > > Change since v2: > - leverage SIS_PROP to suspend redundant scanning when LLC is overloaded > - remove the ping-pong suppression > - address the comment from Tim, thanks. > Link: https://lore.kernel.org/lkml/20220126080947.4529-1-yangyicong@hisilicon.com/ > > Change since v1: > - regain the performance data based on v5.17-rc1 > - rename cpus_share_cluster to cpus_share_resources per Vincent and Gautham, thanks! > Link: https://lore.kernel.org/lkml/20211215041149.73171-1-yangyicong@hisilicon.com/ > > Barry Song (2): > sched: Add per_cpu cluster domain info and cpus_share_lowest_cache API > sched/fair: Scan cluster before scanning LLC in wake-up path > > include/linux/sched/sd_flags.h | 7 +++++++ > include/linux/sched/topology.h | 8 +++++++- > kernel/sched/core.c | 12 ++++++++++++ > kernel/sched/fair.c | 30 +++++++++++++++++++++++++++--- > kernel/sched/sched.h | 3 +++ > kernel/sched/topology.c | 25 +++++++++++++++++++++++++ > 6 files changed, 81 insertions(+), 4 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel