From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2ABAC433EF for ; Fri, 18 Mar 2022 11:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lvE2rZHDM9UTi7/vTQUY3N5z5uFLP+t7SjQ0tnmDzxk=; b=Sti5wBBIAho/R2 0XJ3bfdnKcDeJHKbdwHlowE+7G0Gt69JJ5Cqzo+DPzQmh/GOkrWOf7w6Y7gky1Db5zZzQ8elInOzi +EoVXSFp6K3ya+gINtoHZzHW4qgQvc1LGdLvCBTJxWJru5SA/AX0EYJQ0rwEqv3SL7kwoM21nroP/ IMjRQpJtd9nJ3XsiecwOQsgHehSDqCoCc8Rw/hkkWC26hEb+CWVSHoGnrsGoVmKs4oMh63vpZ20Xn jmsrJwoWpF5uBXVn5TcrI9QfnUeAnDagcIFxkHq4f/v5mWu5SKyNv0x+QoKQNNP/6OUxyLh/uENT6 A/+MvD32sICkFk0zYE8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVBDI-001VCS-Q9; Fri, 18 Mar 2022 11:56:13 +0000 Received: from mail-lj1-f169.google.com ([209.85.208.169]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVBDD-001VBq-Kh for linux-arm-kernel@lists.infradead.org; Fri, 18 Mar 2022 11:56:10 +0000 Received: by mail-lj1-f169.google.com with SMTP id q5so10949261ljb.11 for ; Fri, 18 Mar 2022 04:56:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LpBDuSYRfhCjN2rL91mRm+RnyEuqAx1X5cQe2gIQXvU=; b=tXMts2qoPQQ7MuvIBtD+lUSDXjwliQAnDnTDJGsTyG74w2DsQsnuZ5K8VJywViJY75 /Efo0xVrWsdqw4Parwv6LNqya0TsHQ3H1F1gKed/NwRshQW0Ea4k6NTWa5UF1HUXZ4wT U70u8vl5MQqNMJiVh9ObazNJjWHCKoHC2dJ+DP1EMo4fIEYm5JrjDjgc2c9yVdaJeGB7 Z4CFmGqGqBmv97Y3RtfxCHb7B/SaeuiTWcMshsUHg/5wr05/zr09G8o9SYh3hBbDGXmf BWaA6/2DchN1Lx92D28O45mf/VvfR8LcLtwt78iiobxs50fykEHZUGw+Mj0EtCJkGmbV NasA== X-Gm-Message-State: AOAM531VQFVViskPk/VdWOAEWZzeHRCN6EysAVIWntpzGSAQcYcJuFR8 ZNRXOTxEo/efo9G6EDfl0ooNSVheArA= X-Google-Smtp-Source: ABdhPJwXxt19VE3E+LR/+1rHtFn/71OmpD0icPdohgbhWWTOiDk8Ulkt/mFgVGq4Zi2NlGCvJlo+Uw== X-Received: by 2002:a2e:9bd7:0:b0:248:ca3:ecf1 with SMTP id w23-20020a2e9bd7000000b002480ca3ecf1mr6179171ljj.66.1647604564930; Fri, 18 Mar 2022 04:56:04 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id a11-20020a194f4b000000b004482e94a3b1sm819762lfk.19.2022.03.18.04.56.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Mar 2022 04:56:04 -0700 (PDT) Message-ID: Date: Fri, 18 Mar 2022 12:56:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] arm64: dts: imx8mp: add ddr controller node to support EDAC on imx8mp Content-Language: en-US To: Sherry Sun , robh+dt@kernel.org, krzk+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, Dinh Nguyen References: <20220318113526.15986-1-sherry.sun@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220318113526.15986-1-sherry.sun@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_045607_712932_37BE3C2A X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/03/2022 12:35, Sherry Sun wrote: > i.MX8MP use synopsys V3.70a ddr controller IP, so add edac support > for i.MX8MP based on "snps,ddrc-3.80a" synopsys edac driver. > > Signed-off-by: Sherry Sun > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 794d75173cf5..a6124a11d6ee 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -902,6 +902,12 @@ > interrupt-parent = <&gic>; > }; > > + edacmc: memory-controller@3d400000 { > + compatible = "snps,ddrc-3.80a"; > + reg = <0x3d400000 0x400000>; > + interrupts = ; This is not correct according to the bindings. Dinh's commit adding the compatible might not be correct, so please first fix bindings. While fixing bindings, order the compatibles by name (s goes before x). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel