From: leonard.crestez@nxp.com (Leonard Crestez)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"
Date: Tue, 24 Jul 2018 11:34:48 +0000 [thread overview]
Message-ID: <dfad19eec11f7f3affc51f1ecc41d3f6eaa65e7c.camel@nxp.com> (raw)
In-Reply-To: <CAHQ1cqF7u2gjwYt1-16u-uimXHZ2SWsquabZSDftQn_yRurhSQ@mail.gmail.com>
On Mon, 2018-07-23 at 11:38 -0700, Andrey Smirnov wrote:
> On Mon, Jul 23, 2018 at 5:41 AM Leonard Crestez <leonard.crestez@nxp.com> wrote:
> > On Fri, 2018-07-20 at 08:33 -0700, Andrey Smirnov wrote:
> > > On Fri, Jul 20, 2018 at 5:48 AM Leonard Crestez <leonard.crestez@nxp.com> wrote:
> > > >
> > > > This reverts commit 1c86c9dd82f859b474474a7fee0d5195da2c9c1d.
> > > >
> > > > That commit followed the reference manual but unfortunately the imx7d
> > > > manual is incorrect.
> > >
> > > I'd also add similar comment to DT file to prevent people from trying
> > > to "fix" this in the future.
> >
> > I'll try to see if I can follow up internally with docs team to get
> > this updated in the next revision of the reference manual.
>
> Not sure if we are on the same page here, but what I meant is adding
> the same explanation that is in your commit message to Device Tree
> file as well so that if anyone looks at DT code and goes "Huh?" in the
> future, they wouldn't have to research commit history to see the
> reason why things the way they are.
OK, I will add a comment on irq mappings in the next version explaining
that the reference manual is incorrect.
> > > Also, this change is going to break QEMU's mapping found here:
> >
> > I had no idea that existed, I guess somebody needs to fix that as well.
>
> I take it it's a no to my "any chance you can fix that as well?" ;-).
> I'll see if I can find time to do that this week.
Sorry, I'm not familiar with qemu source at all.
next prev parent reply other threads:[~2018-07-24 11:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 12:47 [PATCH v2 0/3] PCI: imx: Initial imx7d pm support Leonard Crestez
2018-07-20 12:47 ` [PATCH v2 1/3] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping" Leonard Crestez
2018-07-20 15:33 ` Andrey Smirnov
2018-07-23 12:41 ` Leonard Crestez
2018-07-23 18:38 ` Andrey Smirnov
2018-07-24 11:34 ` Leonard Crestez [this message]
2018-07-20 12:47 ` [PATCH v2 2/3] reset: imx7: Fix always writing bits as 0 Leonard Crestez
2018-07-23 9:41 ` Lucas Stach
2018-07-23 11:02 ` Philipp Zabel
2018-07-20 12:47 ` [PATCH v2 3/3] PCI: imx: Initial imx7d pm support Leonard Crestez
2018-07-20 13:38 ` Fabio Estevam
2018-07-23 9:38 ` Lucas Stach
2018-07-23 12:37 ` Leonard Crestez
2018-07-24 10:09 ` Lucas Stach
2018-07-24 12:04 ` Leonard Crestez
2018-07-24 12:28 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfad19eec11f7f3affc51f1ecc41d3f6eaa65e7c.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).