From mboxrd@z Thu Jan 1 00:00:00 1970 From: leonard.crestez@nxp.com (Leonard Crestez) Date: Tue, 24 Jul 2018 11:34:48 +0000 Subject: [PATCH v2 1/3] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping" In-Reply-To: References: <221deb47d7d38ecd6e0c7636f9a87ab693a3c539.1532090446.git.leonard.crestez@nxp.com> <42ff53eeea3067b19e3e16bed8392706502c8f23.camel@nxp.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 2018-07-23 at 11:38 -0700, Andrey Smirnov wrote: > On Mon, Jul 23, 2018 at 5:41 AM Leonard Crestez wrote: > > On Fri, 2018-07-20 at 08:33 -0700, Andrey Smirnov wrote: > > > On Fri, Jul 20, 2018 at 5:48 AM Leonard Crestez wrote: > > > > > > > > This reverts commit 1c86c9dd82f859b474474a7fee0d5195da2c9c1d. > > > > > > > > That commit followed the reference manual but unfortunately the imx7d > > > > manual is incorrect. > > > > > > I'd also add similar comment to DT file to prevent people from trying > > > to "fix" this in the future. > > > > I'll try to see if I can follow up internally with docs team to get > > this updated in the next revision of the reference manual. > > Not sure if we are on the same page here, but what I meant is adding > the same explanation that is in your commit message to Device Tree > file as well so that if anyone looks at DT code and goes "Huh?" in the > future, they wouldn't have to research commit history to see the > reason why things the way they are. OK, I will add a comment on irq mappings in the next version explaining that the reference manual is incorrect. > > > Also, this change is going to break QEMU's mapping found here: > > > > I had no idea that existed, I guess somebody needs to fix that as well. > > I take it it's a no to my "any chance you can fix that as well?" ;-). > I'll see if I can find time to do that this week. Sorry, I'm not familiar with qemu source at all.