From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB181C4332F for ; Sat, 5 Nov 2022 03:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Subject:From:References:Cc: To:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EUNA+qke2NyrLQnOBUpLWhAwJYQ6nPloypKF8QdRb4g=; b=S7ZOcp8LzBZFGm naIZb5XheOo2Vx+7qMSp1wNduGM+awZ7Nv/murlqpO3MDdwnObzKX1C4PRzJo64c9P1o4g0gQazfj cr29Tm6tkqYZcS1PBkocr1NylTgQFjH3deeIlQuuF01ZKQHki3H+pk8X1ZTLUQXVmT+vVeH8aT7FX 3GWBygaUcUSWwHUC9QAr9qKOtGc6w1cW89B19l51AA0RzCSDLWDuMrZx9HliJr1xaaSBlErDIG2B/ lg2q8nINJp3qXn7FcmaqSUN07lxuDENLVdxYsQU64a+dK9As8nzzTJcXVd3bEA6zNP0AnEFubIxgG dRXcHKg2kgUISUR37grA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1or9R1-005lj1-Ea; Sat, 05 Nov 2022 03:01:27 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1or9Qy-005liW-CO for linux-arm-kernel@lists.infradead.org; Sat, 05 Nov 2022 03:01:26 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 7FC5E3200495; Fri, 4 Nov 2022 23:01:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 04 Nov 2022 23:01:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1667617282; x= 1667703682; bh=GTr14r/DVhxNa3bUaiw/EiUiPI9nxDfEqOF6MtdTq9k=; b=W ++oHusbnm1iB8F5T+3bq13FIUYbiULNqX7ToFr6kSTvh7WBzGh3b0A03YvtCZ2VZ w3/jk6QsfSBfEnz62DX0wYKlC+uXVcqWsd74LrQqtD84R8LNFjf+Bql4nlMHfgvL Kv+GYQiBGRUObqT2sOHzXP32/03bOD+2roKYJ6lAWIZjuyD/NPKDpin1KNLBQy+Z 6zWleCcKmefdPKHYcUtzD2bTmwKIbvz/7VVcZ5LuTd17DAB/PlVl1Foh43HVHjn2 WjYQSHF23i/gdtrqbrjlBli0azNCHBOi1JdiQYo2Td3U7wHhhSFvYBXxo8fx7d2s /uzUEU/bU6Wr1i5DGbjYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1667617282; x= 1667703682; bh=GTr14r/DVhxNa3bUaiw/EiUiPI9nxDfEqOF6MtdTq9k=; b=d ew4Fdx5Q4G3U6oQ5VR92/9j88MiSzaKHhAe5QlwFd6uYv1UlgsOl3KvHd1GySYXc 6euNBbqQEtHV2GWgOkcd07F4dqVECZQUvYgOI35XxgkhmLKAN4HJO0lvbfxci3qG 6AMfQWcMUC9tDYtph+JGqYr1bdzczuq+3gTjRHf8yMo+MkAFcSW/RaS7A6UXRKBp oth5kw2k/qqhceCf3ttBeDtJnTuDQ0sb6qQKmLPy0d7DQoQnRJz/2y2rfjkeWBzn Hjt/fqryBbUldBRXHh2ZCls2L1SlfWF+nUA2LJ1pF53VkxYi8KUPv5kmdqIBoL5J Aha0A+NZrGxLXRX19scbA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrvddvgdehfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfvvehfhffujggtgfesthejredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepjefgfffhudejfedtuedugeeutdetgfeiteffffehjeeugfeuvdeh jeetfedtffdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 4 Nov 2022 23:01:19 -0400 (EDT) Message-ID: Date: Fri, 4 Nov 2022 22:01:18 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Content-Language: en-US To: Jernej Skrabec , mchehab@kernel.org, hverkuil-cisco@xs4all.nl Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, wens@csie.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20221101123201.3021129-1-jernej.skrabec@gmail.com> <20221101123201.3021129-4-jernej.skrabec@gmail.com> From: Samuel Holland Subject: Re: [PATCH 3/3] arm64: dts: allwinner: h6: Add deinterlace node In-Reply-To: <20221101123201.3021129-4-jernej.skrabec@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221104_200124_750039_4972F422 X-CRM114-Status: GOOD ( 13.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/1/22 07:32, Jernej Skrabec wrote: > H6 has deinterlace core. Add a node for it. > > Signed-off-by: Jernej Skrabec Reviewed-by: Samuel Holland > --- > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > index 0aa6dfafc197..badc6afd6941 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > @@ -154,6 +154,18 @@ mixer0_out_tcon_top_mixer0: endpoint { > }; > }; > > + deinterlace@1420000 { > + compatible = "allwinner,sun50i-h6-deinterlace"; > + reg = <0x01420000 0x2000>; Not that it matters, as long as the range is big enough, but how did you come up with this size? The only thing I find in the vendor devicetrees is 0x20c, the offset of the last documented register. Regards, Samuel > + clocks = <&ccu CLK_BUS_DEINTERLACE>, > + <&ccu CLK_DEINTERLACE>, > + <&ccu CLK_MBUS_DEINTERLACE>; > + clock-names = "bus", "mod", "ram"; > + resets = <&ccu RST_BUS_DEINTERLACE>; > + interrupts = ; > + iommus = <&iommu 2>; > + }; > + > video-codec-g2@1c00000 { > compatible = "allwinner,sun50i-h6-vpu-g2"; > reg = <0x01c00000 0x1000>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel