Re: [PATCH v3 5/5] arm64: dts: lx2162a-clearfog: set sfp connector leds function and source

[Josua Mayer <josua@solid-run.com>]

Am 04.03.26 um 12:21 schrieb Josua Mayer:
> LX2162A Clearfog has four LEDs attached physically to the 4-port SFP
> connector. They are intended to show information relating to network
> interface status.
>
> Select "netdev" as default trigger for each LED, and link each one to
> the respective dpmac instance as trigger-source.
>
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts b/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
> index 8920326a06735..9d50d3e2761da 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
> @@ -41,21 +41,29 @@ leds {
>  		led_sfp_at: led-sfp-at {
>  			gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; /* PROC_IRQ5 */
>  			default-state = "off";
> +			linux,default-trigger = "netdev";
> +			trigger-sources = <&dpmac3>;
I wasn't sure about this one, due to how the dpaa2 driver is designed,
the parent to the linux netdev is a dpni object, not a dpmac object.

So I still need udev rules, and the trigger-source is not set automatically.

If this description is correct, then I still prefer to add it.

>  		};
>  
>  		led_sfp_ab: led-sfp-ab {
>  			gpios = <&gpio2 11 GPIO_ACTIVE_HIGH>; /* PROC_IRQ11 */
>  			default-state = "off";
> +			linux,default-trigger = "netdev";
> +			trigger-sources = <&dpmac4>;
>  		};
>  
>  		led_sfp_bt: led-sfp-bt {
>  			gpios = <&gpio2 13 GPIO_ACTIVE_HIGH>; /* EVT1_B */
>  			default-state = "off";
> +			linux,default-trigger = "netdev";
> +			trigger-sources = <&dpmac5>;
>  		};
>  
>  		led_sfp_bb: led-sfp-bb {
>  			gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* EVT2_B */
>  			default-state = "off";
> +			linux,default-trigger = "netdev";
> +			trigger-sources = <&dpmac6>;
>  		};
>  	};
>  
>