Re: [PATCH v2 2/2] ARM: dts: aspeed: yosemite5: Add Meta Yosemite5 BMC

[Andrew Jeffery <andrew@codeconstruct.com.au>]

Hi Kevin,

On Wed, 2025-09-24 at 20:28 +0800, Kevin Tung wrote:
> Add device tree for the Meta (Facebook) Yosemite5 compute node,
> based on the AST2600 BMC.
> 
> The Yosemite5 platform provides monitoring of voltages, power,
> temperatures, and other critical parameters across the motherboard,
> CXL board, E1.S expansion board, and NIC components. The BMC also
> logs relevant events and performs appropriate system actions in
> response to abnormal conditions.
> 
> Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
> ---
>  .../dts/aspeed/aspeed-bmc-facebook-yosemite5.dts   | 1068 ++++++++++++++++++++
>  1 file changed, 1068 insertions(+)

This misses adding the devicetree to the dtb target in
arch/arm/boot/dts/aspeed/Makefile. Consequently I don't expect this was
tested with `make DTBS_CHECK=y ...`. Fixing the make target and
checking the DTB yields the following among the usual concerns:

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dtb: ethernet@1e670000 (aspeed,ast2600-mac): Unevaluated properties are not allowed ('ncsi-package' was unexpected)
        from schema $id: http://devicetree.org/schemas/net/faraday,ftgmac100.yaml#

Can you please address that? You may need to update or introduce a
binding document as part of doing so if it's not a matter of removing
the property from the devicetree.

Andrew