From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 936BA606A323 for ; Mon, 16 Nov 2026 08:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=doBsOmHc; dkim=pass (2048-bit key) header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=ZL9lQ+Ij DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=YsacxGE14wOKz6Pg8TZXlOHyLRTqOTqtvBl+xKa/O2U=; b=doBsOmHcDa5lgUv+XRwAxzHI35 HNJpwjy1AoimFYuOhMn/rC1u6ZsayEEHm7wOJPy0I12HqB5IiKCUnsfcy4RzQ7xvJv2EP3TCi5H54 siqN0S9JZzi1q4NOSPxOj+oLbf+mhotQab0l5m7xGvkXj4ZqQS+vc/qLTXOokpaXf13K5a5pbyCia LuUyetrwtp86GPFcOTidY/efNMor/o1RKlUosR9tGNJ5hgzLZDuGK38etZvSVqQTEJ2sg94MPbFDV 4bUoDTPtq6Y0t7YGV6qGhvpEtdFqeDe3ekkrX2ztVSIYxf731WjFsdpGRUCJCrsYre80oYOC55gkR mwhg0GFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSrer-00000001VpU-2D4O; Mon, 16 Nov 2026 08:01:45 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSreo-00000001VnN-3nq2 for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2026 08:01:44 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-c50e26763a4so55821866b.1 for ; Mon, 16 Nov 2026 00:01:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amutable-com.20260707.gappssmtp.com; s=20260707; t=1794816100; x=1795420900; darn=lists.infradead.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=YsacxGE14wOKz6Pg8TZXlOHyLRTqOTqtvBl+xKa/O2U=; b=ZL9lQ+Ij/OHBOtOQ/43LNApMmnlCsRCqo1I9FM9QB7yoe9Y0Jc2twTqTJlSTAhGuVl S2uSvCnydGkcqC1T64WuEI8t1zrzHEO8T7pa76UM1ezXZszIUU5yqsOj6AV9mLvZOEMV lThdg+xxom4pfNA5pyONynvNSyW/4WTBi0vTV/X4W+J3LheAoQk6+Gt1eYB0VXB+mzsT pFkCDXsh+DqSluCX3Sd7c+b/pCRIyc4DTdu4B3H3Hfy7iEkAnbJm30SyYuuKtUweXsLr hKBsTcChRaAidYZ8gLc8Y186xazoi6UwZMo8+SWe7CVFOOHu4FPmQJTPydT9Ce4N9P0R qBqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794816100; x=1795420900; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YsacxGE14wOKz6Pg8TZXlOHyLRTqOTqtvBl+xKa/O2U=; b=ezG/s4sLfLz/ItILdHJF5r9EAvUtM5ZlK7ZKR80q+G62hzK5hKlpRtj05v7MxbShti DvpLb2od4JHVEl2s7iqRAFGH4caZJV1lCz5Lej2zuuw0NZ6JLcqf2daRgQJAPwINW3Fp yBSiuQpN4nWiaHpcTFX0H1qIt8ZGdhMTUlDgDgEkd/qAHfqtEcYJeBTqZIi2RYXC0dO8 dLd7fJF4oOhD+4g7fkYTk62OXyBNCo8r1BWfcUBZkY5EES/wXJnvWMVOQSLVghCDrdVV aGhD9eMOIFBbtxwhRGYPBvqnabgKAL0YcuvoDHqPBBpRR3FpCz/a5csQnOut69YNB6IX uLMw== X-Forwarded-Encrypted: i=1; AL+hErGaWepTVY0BjoD/0dBDzfxyhpAsdL5a+oR2lbbOxhLcr8q5txfOXNAfZLlK1BwMCXrB/s51TYRr4VIZN36KOhXy@lists.infradead.org X-Gm-Message-State: APuU4Z//vlHK6cIYreGXt+R/HjfFNnkdoE2WwBEsbf/Q6G2+arwMVYqt 9If5idr1BoA5mGYNZ9+V9g7CkeopdDfbwqm7dXsGAkcjuXINmiSUgi6sHDMghvZmfFQc X-Gm-Gg: AYBFou1Y0/SdHFHh8uRQguljRTeqBGKzy+YL415LCwhzFxl8PJzdcYxygMrlDmx0b3z RzjKPmQg8u0YobCyT886pJzD0miExv9EW4I7ngl0+JDuJcCZXqss5n6jTYc2xBiYJy46oxXh2tp HOS+RaWM13DOyGHPXijKpocmqah0Qb4Ubat8Qk4BUYyjLbEPDE9XZZZ6jLnwOaft0b4z3n3JSWk 3T9hPKLI7JG+k/DPQpmbcUzDyTF1S5hIA6Ga3HVQN3h1JbgD/AHKnFfFKMrLMsttArFCn7odxU+ hJ1niJeALMQX7ssb3zhGNh/+Svhifp/MvB+kx7ueuRjoAMcq9iikoAfYU5EhiOzX1c4G+Q9USK1 4HGrRX+DrLhGl+HpjuehfR5MrJ8Q7QlQmVLbSlUPybLnVxCppD5n6A915C7PwMlEhXuz660KCBo uIRczDJpVVop1hbK7KVcgjPHEX0KoRWghEzZQga088JgAvSJmq1y4UKbJAtnGHU4k75KLXBJAWw kpaX2wnjJe2umwZ6trpHfO+m1F0T2mSdXXGSylqXZ0Ue1kPefA2bXceWndE4hwp9Rym1PdzMjhA REHsPW0qs+FlBKfnWac0e/Wz9Z4RCvyu2N6SaCgBOBd6xlPNmS297sR8UnNlues= X-Received: by 2002:a17:907:1c90:b0:c2e:63ba:1f90 with SMTP id a640c23a62f3a-c50963bc4f0mr777600066b.48.1794816099924; Mon, 16 Nov 2026 00:01:39 -0800 (PST) Received: from [10.0.0.233] (tmo-086-54.customers.d1-online.com. [80.187.86.54]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c5095b7b2c9sm385795866b.73.2026.11.16.00.01.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 00:01:39 -0800 (PST) Message-ID: Subject: Re: [PATCH RFC 4/4] crash_dump: use copy_oldmem_to_iter() everywhere From: Alexander Mikhalitsyn To: Christian Brauner , linux-fsdevel@vger.kernel.org Cc: Linus Torvalds , Breno Leitao , Chris Mason , Thomas Gleixner , x86@kernel.org, kexec@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, David Hildenbrand Date: Mon, 16 Nov 2026 09:01:37 +0100 In-Reply-To: <20261112-work-procfs-oldmem-v1-4-ecdcafd99265@kernel.org> References: <20261112-work-procfs-oldmem-v1-0-ecdcafd99265@kernel.org> <20261112-work-procfs-oldmem-v1-4-ecdcafd99265@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261116_000142_983051_C7737F38 X-CRM114-Status: GOOD ( 18.74 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, 2026-11-12 at 17:37 +0100, Christian Brauner wrote: > Make the remaining copy_oldmem_page() implementations copy the page > of > the crashed kernel with copy_oldmem_to_iter() like x86_64 and powerpc > do. None of these architectures has a machine check safe copy today, > so > for them this is copy_to_iter() under another name. But the copy of a > page of the old kernel is in one place now, and an architecture that > gains ARCH_HAS_COPY_MC later gets the recovery without touching its > crash dump code. >=20 > s390 stays as it is. It copies the old kernel's memory through its > real > address mode window in memcpy_real_iter(), and an uncorrected storage > error is fatal on s390 anyway (cf. s390_handle_damage()). >=20 > No functional changes. >=20 > Signed-off-by: Christian Brauner (Amutable) Reviewed-by: Alexander Mikhalitsyn > --- > =C2=A0arch/arm/kernel/crash_dump.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | = 2 +- > =C2=A0arch/arm64/kernel/crash_dump.c=C2=A0=C2=A0=C2=A0=C2=A0 | 2 +- > =C2=A0arch/loongarch/kernel/crash_dump.c | 2 +- > =C2=A0arch/mips/kernel/crash_dump.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 2 +- > =C2=A0arch/riscv/kernel/crash_dump.c=C2=A0=C2=A0=C2=A0=C2=A0 | 2 +- > =C2=A0arch/sh/kernel/crash_dump.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 | 2 +- > =C2=A0arch/x86/kernel/crash_dump_32.c=C2=A0=C2=A0=C2=A0 | 2 +- > =C2=A07 files changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/arch/arm/kernel/crash_dump.c > b/arch/arm/kernel/crash_dump.c > index 938bd932df9a0..0f2628872b00c 100644 > --- a/arch/arm/kernel/crash_dump.c > +++ b/arch/arm/kernel/crash_dump.c > @@ -28,7 +28,7 @@ ssize_t copy_oldmem_page(struct iov_iter *iter, > unsigned long pfn, > =C2=A0 if (!vaddr) > =C2=A0 return -ENOMEM; > =C2=A0 > - csize =3D copy_to_iter(vaddr + offset, csize, iter); > + csize =3D copy_oldmem_to_iter(vaddr + offset, csize, iter); > =C2=A0 > =C2=A0 iounmap(vaddr); > =C2=A0 return csize; > diff --git a/arch/arm64/kernel/crash_dump.c > b/arch/arm64/kernel/crash_dump.c > index 670e4ce818223..c774b3aba107d 100644 > --- a/arch/arm64/kernel/crash_dump.c > +++ b/arch/arm64/kernel/crash_dump.c > @@ -24,7 +24,7 @@ ssize_t copy_oldmem_page(struct iov_iter *iter, > unsigned long pfn, > =C2=A0 if (!vaddr) > =C2=A0 return -ENOMEM; > =C2=A0 > - csize =3D copy_to_iter(vaddr + offset, csize, iter); > + csize =3D copy_oldmem_to_iter(vaddr + offset, csize, iter); > =C2=A0 > =C2=A0 memunmap(vaddr); > =C2=A0 > diff --git a/arch/loongarch/kernel/crash_dump.c > b/arch/loongarch/kernel/crash_dump.c > index e559307c10929..03a136b8be8da 100644 > --- a/arch/loongarch/kernel/crash_dump.c > +++ b/arch/loongarch/kernel/crash_dump.c > @@ -15,7 +15,7 @@ ssize_t copy_oldmem_page(struct iov_iter *iter, > unsigned long pfn, > =C2=A0 if (!vaddr) > =C2=A0 return -ENOMEM; > =C2=A0 > - csize =3D copy_to_iter(vaddr + offset, csize, iter); > + csize =3D copy_oldmem_to_iter(vaddr + offset, csize, iter); > =C2=A0 > =C2=A0 memunmap(vaddr); > =C2=A0 > diff --git a/arch/mips/kernel/crash_dump.c > b/arch/mips/kernel/crash_dump.c > index 6e50f49024094..078c0d1e8df46 100644 > --- a/arch/mips/kernel/crash_dump.c > +++ b/arch/mips/kernel/crash_dump.c > @@ -12,7 +12,7 @@ ssize_t copy_oldmem_page(struct iov_iter *iter, > unsigned long pfn, > =C2=A0 return 0; > =C2=A0 > =C2=A0 vaddr =3D kmap_local_pfn(pfn); > - csize =3D copy_to_iter(vaddr + offset, csize, iter); > + csize =3D copy_oldmem_to_iter(vaddr + offset, csize, iter); > =C2=A0 kunmap_local(vaddr); > =C2=A0 > =C2=A0 return csize; > diff --git a/arch/riscv/kernel/crash_dump.c > b/arch/riscv/kernel/crash_dump.c > index ea2158cee97b3..0820e3db12603 100644 > --- a/arch/riscv/kernel/crash_dump.c > +++ b/arch/riscv/kernel/crash_dump.c > @@ -21,7 +21,7 @@ ssize_t copy_oldmem_page(struct iov_iter *iter, > unsigned long pfn, > =C2=A0 if (!vaddr) > =C2=A0 return -ENOMEM; > =C2=A0 > - csize =3D copy_to_iter(vaddr + offset, csize, iter); > + csize =3D copy_oldmem_to_iter(vaddr + offset, csize, iter); > =C2=A0 > =C2=A0 memunmap(vaddr); > =C2=A0 return csize; > diff --git a/arch/sh/kernel/crash_dump.c > b/arch/sh/kernel/crash_dump.c > index 85c0e58f1a59f..2a5988b6e9d7a 100644 > --- a/arch/sh/kernel/crash_dump.c > +++ b/arch/sh/kernel/crash_dump.c > @@ -23,7 +23,7 @@ ssize_t copy_oldmem_page(struct iov_iter *iter, > unsigned long pfn, > =C2=A0 if (!vaddr) > =C2=A0 return -ENOMEM; > =C2=A0 > - csize =3D copy_to_iter(vaddr + offset, csize, iter); > + csize =3D copy_oldmem_to_iter(vaddr + offset, csize, iter); > =C2=A0 iounmap(vaddr); > =C2=A0 > =C2=A0 return csize; > diff --git a/arch/x86/kernel/crash_dump_32.c > b/arch/x86/kernel/crash_dump_32.c > index 5f4ae5476e193..cb202d4e1f703 100644 > --- a/arch/x86/kernel/crash_dump_32.c > +++ b/arch/x86/kernel/crash_dump_32.c > @@ -40,7 +40,7 @@ ssize_t copy_oldmem_page(struct iov_iter *iter, > unsigned long pfn, size_t csize, > =C2=A0 return -EFAULT; > =C2=A0 > =C2=A0 vaddr =3D kmap_local_pfn(pfn); > - csize =3D copy_to_iter(vaddr + offset, csize, iter); > + csize =3D copy_oldmem_to_iter(vaddr + offset, csize, iter); > =C2=A0 kunmap_local(vaddr); > =C2=A0 > =C2=A0 return csize;