From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E09B5C2D0A3 for ; Wed, 4 Nov 2020 10:23:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64AB7223BD for ; Wed, 4 Nov 2020 10:23:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pVGVtuFs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="S1x0Bm9J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64AB7223BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: References:MIME-Version:Message-ID:In-Reply-To:Date:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iMB+pnyKgl8tf/Qh1yH2gbTEStzzaF1SLfKcnh63U/g=; b=pVGVtuFsOjnD6riQJ5WSenWJ1 MVwU0W2WWOWqLw/C5+J08fUtbq6xH3CZNvWHfQfVeLVpiUIsLxmuqqqTD7SIP2UxFKwbFx9xOfoKD +1L5q+RbFIW2r3MiHMuJbtnXWSfZsSOcGSS9tAkamoP6nmktmjsSpNDjjqA3mZJ7xWLF7vJnX9wwS d7foNTnOaWBdcW10jUN8I9gQiNd7PJCGt+jDHHBSmqHRrZlzgURG0iXURs2wmCnb/YWjuSVkSTr0c exOOXYlc+i2u3RcP6MWKylUmdN9tNOwo8Se7vgOZrt9AU5/5wNDJaNNkMnC/m8HNb9+zcq4cvaQTN 9y8stb7rg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaFur-0007zN-Pm; Wed, 04 Nov 2020 10:21:21 +0000 Received: from mailout1.w1.samsung.com ([210.118.77.11]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaFuj-0007yW-IA for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 10:21:17 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20201104102055euoutp017e70806b10090a4d1a9cf867bcfed04e~ERtat2ZFw2502425024euoutp01H; Wed, 4 Nov 2020 10:20:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20201104102055euoutp017e70806b10090a4d1a9cf867bcfed04e~ERtat2ZFw2502425024euoutp01H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1604485255; bh=tAi+6eLpYGgM6NQaLyk8KzwgohfMuiPjvqb2EyAkySw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S1x0Bm9JMM+KKFZ/TRKzy5Ix3sdDI4PU8lFlwT+vgop2IS8IIIEgEQeWRb7Vl6n30 xRjQnFHzpv/tMd4GPMuViTdKa4yhgIpcQmhRdFIF3igZWMkko5ddkIb7d6lk60m5rA 7DnJUFhON6EuNV2v5ZzpBIrrHhnCsHy8cpiHngzA= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20201104102049eucas1p130cef7ee3b80fefcee8d058f60be375c~ERtVeyrC30494004940eucas1p1L; Wed, 4 Nov 2020 10:20:49 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 44.AC.06456.18082AF5; Wed, 4 Nov 2020 10:20:49 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20201104102048eucas1p1e3b29b66c497ee38656acf9ba5df10eb~ERtU-RHj80494004940eucas1p1K; Wed, 4 Nov 2020 10:20:48 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20201104102048eusmtrp2666027ea81ad0a6d0f9e01605733bd66~ERtU_c0q22072420724eusmtrp2k; Wed, 4 Nov 2020 10:20:48 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-02-5fa28081e643 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 04.71.06017.08082AF5; Wed, 4 Nov 2020 10:20:48 +0000 (GMT) Received: from localhost (unknown [106.120.51.46]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201104102048eusmtip18dc222cb21125f7540565cbaba6d8fc0~ERtUwY4XC2324823248eusmtip1j; Wed, 4 Nov 2020 10:20:48 +0000 (GMT) From: Lukasz Stelmach To: Andrew Lunn Subject: Re: [PATCH v5 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver Date: Wed, 04 Nov 2020 11:20:37 +0100 In-Reply-To: <20201104024211.GS933237@lunn.ch> (Andrew Lunn's message of "Wed, 4 Nov 2020 03:42:11 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0hTYRjm2zln57iafC7TN5OwaUEXTSvqi0oq+nF+RERBV8xWHpy5zdi0 sj8paJTkJU3SYVliZhteG6tVRh1NM9GjWWaiFd3zgpGLNNJyngX9e973eZ73e96Xj6M0k0wQ l2BKFswmnUGrVNHO5gkpPD2tLDbSnTuPSAMiReqKahhSImXQpLSpgyFlo0UM6RnpZ0ju+yGK SFItSzqdOQypf9/DkO67JUpSJD1QELGwAZGqpgGWNF8NIJkNTewmzHf3dFG84+YrBe+yDrB8 ve2ckr9Vfpp33RlT8DkOG+LH6hfs4ParNsQJhoTjgnlF9CGV/nlhIXvMFnBS+tDCpqEmTRby 4QCvhsbLP1AWUnEaXIngaZaVlgs3gi+9Ewq5GEPwczyD/We5PZyhlIkbCD7dKvD6PyMYrXs5 reI4JY6Aqqq9HoM/DoGLrb8Zj4bCL2h4ab/CeIg5eDc8sLmRB9N4EfSLt2ewDzbADVfljEaN 10JFo13hwXPxOnB8ecPKfT9oLf5AezCFjVAsDc+EAHydA7F5QilH3QrZOe8YGc+BwRaHd4Vg +OMqVXiCAj4NBflrZO95BM6ScVrWrIf+jl/eOZsh/eZXr94Xekf85Hd9Id95iZLbajh7xnvT MKjOve+dEgTZg5VIlvDQ03VYPlU6AsfEc2UeCrH+t431v22s0xYKL4Gauyvk9jKouDZEyXgj VFeP0lcRY0OBQorFGC9YokzCiQiLzmhJMcVHHEky1qPpj9g21fL9Dvrx7LCIMIe0s9UPnddi NYzuuCXVKKKw6Unvau2dKIg2JZkErb96S3vbQY06Tpd6SjAnxZpTDIJFRPM5WhuoXlX2NUaD 43XJQqIgHBPM/1gF5xOUhsp+ji6Ma49JDM+oude6Jl/vP6vOMLVYHD4lfdu58mNjaldML+/L Boe6a6vNvouCr0Tmldu/i4SntZejA3e7I5YnR0UGbBlxpdD73HtGGvYceXwhdNuBbFLZd+Zt Z17fvvEslXuy++jSo2Edqx+pnYlc9JO+/kx93lCBvXT76116LW3R66KWUmaL7i8SLyCYkAMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsVy+t/xu7oNDYviDb63GFucv3uI2WLjjPWs FnPOt7BYzD9yjtVi0fsZrBbX3t5hteh//JrZ4vz5DewWF7b1sVpsenyN1eLyrjlsFjPO72Oy ODR1L6PF2iN32S2OLRCzaN17hN1BwOPytYvMHltW3mTy2DnrLrvHplWdbB6bl9R77Nzxmcmj b8sqRo/Pm+QCOKL0bIryS0tSFTLyi0tslaINLYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLL Uov07RL0Mq5MncpesEqs4vyT4+wNjEeEuhg5OSQETCS2v2lh62Lk4hASWMoosXnhXcYuRg6g hJTEyrnpEDXCEn+udUHVPGWUaJs7hxmkhk1AT2Lt2giQGhEBBYkpJ/+wgtQwC9xgkdjcfJkF JCEsECJxe/lvdhBbSEBXonn3fmYQm0VAVeLOoe1guzgFciRW/okDCfMKmEssO7yaCcQWFbCU 2PLiPjtEXFDi5MwnYCOZBbIlvq5+zjyBUWAWktQsJKlZQFOZBTQl1u/ShwhrSyxb+JoZwraV WLfuPcsCRtZVjCKppcW56bnFRnrFibnFpXnpesn5uZsYgbG87djPLTsYu94FH2IU4GBU4uE9 sG1hvBBrYllxZe4hRhWgMY82rL7AKMWSl5+XqiTC63T2dJwQb0piZVVqUX58UWlOavEhRlOg NycyS4km5wPTT15JvKGpobmFpaG5sbmxmYWSOG+HwMEYIYH0xJLU7NTUgtQimD4mDk6pBsbV QeHmRl5r3hTJaB3mYJdZuFa6fv77m1+KdO3n/fLw26qy/EXX45se+x5ZmX/yWjpd+66CWeXx AN+EM1PPOJVL9N5imJQ08ffP72uyeRduvKlvOHdxLt8kpkk5nVHb6+696To5w+HSZBPLeumN UhwHLDYfnKMw5/5OK+Y+/z27b/DpVSWfl7NWYinOSDTUYi4qTgQAA52AgQcDAAA= X-CMS-MailID: 20201104102048eucas1p1e3b29b66c497ee38656acf9ba5df10eb X-Msg-Generator: CA X-RootMTR: 20201104102048eucas1p1e3b29b66c497ee38656acf9ba5df10eb X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20201104102048eucas1p1e3b29b66c497ee38656acf9ba5df10eb References: <20201104024211.GS933237@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_052116_194418_D2E2B7D7 X-CRM114-Status: GOOD ( 21.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, =?utf-8?Q?Bart=C5=82omiej_=C5=BBolnierkiewic?= =?utf-8?Q?z?= , jim.cromie@gmail.com, netdev@vger.kernel.org, Russell King , Rob Herring , linux-kernel@vger.kernel.org, Kukjin Kim , Krzysztof Kozlowski , Jakub Kicinski , Marek Szyprowski , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: multipart/mixed; boundary="===============3297571348716340630==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3297571348716340630== Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256"; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It was <2020-11-04 =C5=9Bro 03:42>, when Andrew Lunn wrote: >> +config SPI_AX88796C_COMPRESSION >> + bool "SPI transfer compression" >> + default n >> + depends on SPI_AX88796C >> + help >> + Say Y here to enable SPI transfer compression. It saves up >> + to 24 dummy cycles during each transfer which may noticably >> + speed up short transfers. This sets the default value that is >> + inherited by network interfecase during probe. It can be > > interface > Done. >> + changed in run time via spi-compression ethtool tunable. > > changed _at_ run time... > Done. >> +static int >> +ax88796c_set_tunable(struct net_device *ndev, const struct ethtool_tuna= ble *tuna, >> + const void *data) >> +{ >> + struct ax88796c_device *ax_local =3D to_ax88796c_device(ndev); >> + >> + switch (tuna->id) { >> + case ETHTOOL_SPI_COMPRESSION: >> + if (netif_running(ndev)) >> + return -EBUSY; >> + ax_local->capabilities &=3D ~AX_CAP_COMP; >> + ax_local->capabilities |=3D *(u32 *)data ? AX_CAP_COMP : 0; > > You should probably validate here that data is 0 or 1. That is what > ax88796c_get_tunable() will return. > > It seems like this controls two hardware bits: > > SPICR_RCEN | SPICR_QCEN > > Maybe at some point it would make sense to allow these bits to be set > individually? If you never validate the tunable, you cannot make use > of other values to control the bits individually. Good point. What is your recommendation for the userland facing interface, so that future changes will be least disruptive? ax_local->capabilities |=3D ((*(u32 *)data) & SPICR_RCEN) ? AX_CAP_COMP : 0; or rather ax_local->capabilities |=3D ((*(u32 *)data) & (SPICR_RCEN | SPICR_QCEN)) ? = AX_CAP_COMP : 0; and possibly in the future (or now) split it into=20 ax_local->capabilities |=3D ((*(u32 *)data) & SPICR_RCEN) ? AX_CAP_COMP_R := 0; ax_local->capabilities |=3D ((*(u32 *)data) & SPICR_QCEN) ? AX_CAP_COMP_Q := 0; (and appropriate masking abve and proper handling in ax88796c_soft_reset()). Kind regards =2D-=20 =C5=81ukasz Stelmach Samsung R&D Institute Poland Samsung Electronics --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl+igHUACgkQsK4enJil gBDpnQf/cbn9zvVOSpwY+Yl0IedAqG6YyKtEcI+wgKi8WGod8AlkCjEiaWFllLGw pLRiQz56g3mF0yTitLwdY9mA6Q2joEFPaJguJeVI6GhV9W3uoeWXl68DT5OtiHvp 21BtS2RqBzGahVGMRwqt7jDMsLBV2PiqymA0UeFCspWHqjpqRw5s7vy5ySBS+qkp 23g8vTpxXhKjLdogK0S2bL8kZT3kcpdVSIw39LxuTHscA3jxuFDX1sVoYpn30nRM 9sNj5SQC6i0ja+Uoaeju4kLbeIU8IxrwfpiHKU8G7zZqmSb2F0RUIpRBNxJoK897 dlH3+R8pzTOpDSFM29eRFfVPDQIZog== =2VnL -----END PGP SIGNATURE----- --=-=-=-- --===============3297571348716340630== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3297571348716340630==--