From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62913C433E1 for ; Wed, 19 Aug 2020 13:35:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EF7A204EC for ; Wed, 19 Aug 2020 13:35:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oCN2i7zR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="g4TujdAt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EF7A204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: References:MIME-Version:Message-ID:In-Reply-To:Date:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=84Xtdpxn3TjHfqHDQXVWbLwWxxWv+yFi3tnqyJGRtB0=; b=oCN2i7zRoyEuw6YLxvWzyb5JZ LhxzqtOURa6vqwyN5GH95+FQex1DxwpudzQlTMivOd/N2lIsBfZD+PPOiHN+Fq5Q37pDKBawuQX3d ZZKeBauFWtDmq6/hZuE7RCcGHKQEOQP20B9OdRHCh4QfWPIwnM4ZiNZw2QNhoY3nFh4lpMjrCrFdM 1GBVJZr0VaSbovmxNamg4Xp31NGTOkfbC3ZtN4j5ztS1LxPwbtDXL2E7SZpXs5lgBSVnGkHDUyGXo 3eFiZHCySM9PZzj0jG4qzxcdPm0kz1a8R1cq9fwcH1ria5y8HyBJc+ASrYPtd3IMUxlyV2TMReVN0 J9CzLlcUA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8OEB-0000YF-7T; Wed, 19 Aug 2020 13:34:08 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8ODg-0000Ka-C8 for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 13:33:39 +0000 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200819133334euoutp020352fc292c3a0a4b7842c4ce98e59e21~srqpyMS4g2309023090euoutp02f; Wed, 19 Aug 2020 13:33:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200819133334euoutp020352fc292c3a0a4b7842c4ce98e59e21~srqpyMS4g2309023090euoutp02f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597844014; bh=zMUXHTYnB1hgtZY2XvkgLJVtoSLdRUf02CsOMq63azA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g4TujdAtKT1hJBUUldquFdcXVAuB1/TPrjijPQS1inPxRSYdTLabRE2xEFoHCj26h XRtNcfVzNCP2SWrIxNWYGfD2nY3QCjKu8u0DzLonFODKTI3TMV1EG5NbBEikAwX+n+ j8VBsnDHMzo8pXNfnyTc71CwzoFYBAC0mUQHJoAs= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200819133334eucas1p2bec685af8a447f39e5d4dce3ebd8a7a7~srqpafQAP0913009130eucas1p2k; Wed, 19 Aug 2020 13:33:34 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 19.4E.06318.E2A2D3F5; Wed, 19 Aug 2020 14:33:34 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200819133334eucas1p2080182850c7ba84829e3304a1172afff~srqpD9EQX2464024640eucas1p24; Wed, 19 Aug 2020 13:33:34 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200819133334eusmtrp139a84cc966efd7a9c8916ba67936c34c~srqpDR8M42440924409eusmtrp1n; Wed, 19 Aug 2020 13:33:34 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-1e-5f3d2a2ead1b Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 78.A9.06314.D2A2D3F5; Wed, 19 Aug 2020 14:33:34 +0100 (BST) Received: from localhost (unknown [106.120.51.46]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200819133333eusmtip17fe7df747953e9d82e146ca09dafa358~srqo3fPiz0082100821eusmtip1d; Wed, 19 Aug 2020 13:33:33 +0000 (GMT) From: Lukasz Stelmach To: Krzysztof Kozlowski Subject: Re: [PATCH 8/8] spi: spi-s3c64xx: Turn on interrupts upon resume Date: Wed, 19 Aug 2020 15:33:33 +0200 In-Reply-To: <20200819125301.GI18122@kozik-lap> (Krzysztof Kozlowski's message of "Wed, 19 Aug 2020 14:53:01 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIKsWRmVeSWpSXmKPExsWy7djPc7p6WrbxBnOmy1gs/vGcyWLjjPWs FlMfPmGz6H/8mtni/PkN7BabHl9jtbi8aw6bxYzz+5gsGj/eZLdYe+QuuwOXx/Uln5g9Nq3q ZPPYvKTeo2/LKkaPz5vkAlijuGxSUnMyy1KL9O0SuDImvz3PVHCSt6JvUgtrA+Mb7i5GTg4J AROJX2eWMnUxcnEICaxglPizazMLSEJI4AujxKrGIIjEZ0aJey9escN0zL04kREisZxRou/j MWYI5zmjxO+974GqODjYBPQk1q6NAGkQEdCUuP73OytIDbPAciaJpbcbGUESwgKeEi0z1rKC 2CwCqhL7n5wBszkFyiS2ft4FZvMKmEu0zl0FdpKogKXElhf32SHighInZz4BizML5ErMPP8G 7CIJgVvsEttaV0Gd6iJx7scvRghbWOLV8S1QcRmJ05N7WEAOlRCol5g8yQyit4dRYtucHywQ NdYSd879YoOwHSV+X53HDFHPJ3HjrSDEXj6JSdumQ4V5JTrahCCqVSTW9e+BmiIl0ftqBdQF HhJXj2xgh4RVEzCs5i5mm8CoMAvJO7OQvDMLaCwzMOzW79KHCGtLLFv4mhnCtpVYt+49ywJG 1lWM4qmlxbnpqcXGeanlesWJucWleel6yfm5mxiBiev0v+NfdzDu+5N0iFGAg1GJhzdAyTZe iDWxrLgy9xCjCtCkRxtWX2CUYsnLz0tVEuF1Ons6Tog3JbGyKrUoP76oNCe1+BCjNAeLkjiv 8aKXsUIC6YklqdmpqQWpRTBZJg5OqQbG66/jfnVp/lh3emt5oajRebcT/Zn+i9jTzzNq+e+6 GCG/RqroeMB57kCfJS2mkSf+GTB/+3h1tmn27fX1YdY/ZnbVyq8Jmayov+ABUwKb8ZMnofNX mVusljLUPVh9WDNcve7hXrntM9b+frb9p7e1p1rzXuPZkcksd+zKr/jkKd1OOyfCG/VKiaU4 I9FQi7moOBEANZ0ISGQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsVy+t/xu7p6WrbxBjMWMFks/vGcyWLjjPWs FlMfPmGz6H/8mtni/PkN7BabHl9jtbi8aw6bxYzz+5gsGj/eZLdYe+QuuwOXx/Uln5g9Nq3q ZPPYvKTeo2/LKkaPz5vkAlij9GyK8ktLUhUy8otLbJWiDS2M9AwtLfSMTCz1DI3NY62MTJX0 7WxSUnMyy1KL9O0S9DImvz3PVHCSt6JvUgtrA+Mb7i5GTg4JAROJuRcnMnYxcnEICSxllHj1 /AV7FyMHUEJKYuXcdIgaYYk/17rYQGwhgaeMEm0fPEBK2AT0JNaujQAJiwhoSlz/+50VxGYW mM8k8fuXB4gtLOAp0TJjLStEq57E7wu3mUBsFgFVif1PzrCCjOEUKJP4tcYEJMwrYC7ROncV C4gtKmApseXFfXaIuKDEyZlPWCDGZ0t8Xf2ceQKjwCwkqVlIUrOApjIDXbR+lz5EWFti2cLX zBC2rcS6de9ZFjCyrmIUSS0tzk3PLTbUK07MLS7NS9dLzs/dxAiMt23Hfm7ewXhpY/AhRgEO RiUe3gAl23gh1sSy4srcQ4wqQGMebVh9gVGKJS8/L1VJhNfp7Ok4Id6UxMqq1KL8+KLSnNTi Q4ymQG9OZJYSTc4Hpoi8knhDU0NzC0tDc2NzYzMLJXHeDoGDMUIC6YklqdmpqQWpRTB9TByc Ug2MKhJGpk5S50R7VFZLnTx8fbuE9NlYw/yUtvbPIXfLWNv2JvFtPeZXPFMuOfEpH/PpSX7L F2lMDjvu1TD/h9FPKSvXbXk+m3ne1h7KDejpSg1VFp7WcDlRIcUpXbHa+5RB0ZdUxUfXA1r2 hU55dalGUYehr2TWtuDeD6mt8Xyu3r1F1kIpLUosxRmJhlrMRcWJAK9wU9nZAgAA X-CMS-MailID: 20200819133334eucas1p2080182850c7ba84829e3304a1172afff X-Msg-Generator: CA X-RootMTR: 20200819133334eucas1p2080182850c7ba84829e3304a1172afff X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200819133334eucas1p2080182850c7ba84829e3304a1172afff References: <20200819125301.GI18122@kozik-lap> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_093336_653761_C28A0B2D X-CRM114-Status: GOOD ( 18.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , Kukjin Kim , Andi Shyti , linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: multipart/mixed; boundary="===============3581862270345337071==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3581862270345337071== Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256"; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It was <2020-08-19 =C5=9Bro 14:53>, when Krzysztof Kozlowski wrote: > On Wed, Aug 19, 2020 at 02:32:08PM +0200, =C5=81ukasz Stelmach wrote: >> Signed-off-by: =C5=81ukasz Stelmach >> --- >> drivers/spi/spi-s3c64xx.c | 4 ++++ >> 1 file changed, 4 insertions(+) >>=20 >> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c >> index 27db1e0f6f32..5dcad43fb847 100644 >> --- a/drivers/spi/spi-s3c64xx.c >> +++ b/drivers/spi/spi-s3c64xx.c >> @@ -1356,6 +1356,10 @@ static int s3c64xx_spi_runtime_resume(struct devi= ce *dev) >>=20=20 >> s3c64xx_spi_hwinit(sdd); >>=20=20 >> + writel(S3C64XX_SPI_INT_RX_OVERRUN_EN | S3C64XX_SPI_INT_RX_UNDERRUN_EN | >> + S3C64XX_SPI_INT_TX_OVERRUN_EN | S3C64XX_SPI_INT_TX_UNDERRUN_EN, >> + sdd->regs + S3C64XX_SPI_INT_EN); >> + > > Makes sense but you should explain in the commit msg what happens > without this (or why they are not enabled). Done, thanks. =2D-=20 =C5=81ukasz Stelmach Samsung R&D Institute Poland Samsung Electronics --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl89Ki0ACgkQsK4enJil gBBkUQgAqFQPlbvtADVT26WER/P36D2GP9WOAK7ktgcjfzcGS36/m+SConShb6V/ 5HcENMhHWwTMXzFHYmMiUVtv0+nuzsDKKNbeTsb5qI5CX3fGa8DFueJA7WpBXBrl IGR7wkYTYY+KhPmea67VhHaW8a2+e3RhJ6g+VZ59ucpl/Cz7mQ5Yebxsys2fXnVY 5tTMFJ2tCzWn9hryxDY3elEIPyWB+1ST/GVRRyjDgbuzhkK3K9zl12wIiE/kXIqN voCk9xJz53nKW4rXZ6IYvF9Rz9X2XDCexBlJuX3681ClAxFpmLyUqENA0dxDps2z QchFYMvRLXdlNdO3WJ+w9LeEL8lHtw== =Lvij -----END PGP SIGNATURE----- --=-=-=-- --===============3581862270345337071== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3581862270345337071==--