From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 337D8C531DC for ; Fri, 23 Aug 2024 08:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9cyUaWQ/RfElk/9t5oBKQMBDU3FsVlRw3b+jDEVNsQM=; b=iG9BEGF0/SIrZGwf3kogxzBoSN ZyYeKhpDxnthF8qpcF//+9B7ba2xyh6vL/f4gHnRRGAuSUiqp9l+jdb+KI5LTKmD/HSatOX9wLrX0 2iREZWglW3f0ORzrTrTUiLjeulZi0u/7O8OkfP499xsAGf8bsJR4huYvpfPSTpIqAWK1DLnf1g3m0 EluyY/D1j/s1cSHqnnQdVRVCAjPCpFdIo3N17spyG7BqHou+81Yf/HUKnh+US4tyLLtBPJasBOYJA JJlA30YKoMRi/gy7zSixNg7cXsyhrVSkqxWN/ykwcmcGEG16ZCq6ObK56c3kFg2YPXbR0dfotsiPU sdQvr8iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shPDj-0000000FjrA-1OHe; Fri, 23 Aug 2024 08:00:31 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shPCy-0000000FjiM-1wBk for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2024 07:59:45 +0000 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a8682bb5e79so242174566b.2 for ; Fri, 23 Aug 2024 00:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1724399983; x=1725004783; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9cyUaWQ/RfElk/9t5oBKQMBDU3FsVlRw3b+jDEVNsQM=; b=H40Nm1c15+goOMjkUfKGUsNv0NAu1t6plMwFSol4ZYKoiMHRG3hZZl4MP4hw/830EX 9VncGvmd1cQz8U0UolSbbYRheFcY8wCmuAmunBHEUoYX6chBl2Ie8zVE3QMGRbL/UldW 8RIP1XmzEC+Ao71MY6JDdPss0Xh2no/x7R1zFWovzQa88IAxyUVqelhNhSeY7kBqqDJm GGiztDfhcPJ+zeu+DcLjxG1IU/2In9so7P/QhDCcbn0KAkkc9gfbiRCEzNZSDHLB5wGB kxZbIWeSy8tSHIMNoDVMwlJyh3yeDD4N5dxHFHoczaPaUo2U+XbMG5lAKa+n9nGQM+He +K3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724399983; x=1725004783; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9cyUaWQ/RfElk/9t5oBKQMBDU3FsVlRw3b+jDEVNsQM=; b=VFMrzosVO4hXF01z/VhyL2P0m57n937drd2fcZXTo1PUU21H+EVLgj4BYsiABVSQhI Vkml1nw9d1XyMPTWyYYgzvZ5XtHaRWL0EqzNiKULPOnBExI3G3ONgM4c6Hz5AVgaickW qB1SKuNt7X3Eavy0xwE5xYu4QRcA0hpeloXsP4t8jzvF2Gg4nsVLLPzrM4OnGUhi1+7I QOFv9vPg6N/0+MXltNtBf+HSRMlUNvli+AYpOAmfj+yK7595H0O9UrV7pKhoSmtbvXte DzkcnbBLAPI0Jok23oxcWn7mxW4YWSFHOCPnU1Oqx6bzU8lNkQpcESj8LuB3cbAR/vPx L3vg== X-Forwarded-Encrypted: i=1; AJvYcCV1Jam7764pkTbBufV9NZerphU+Lp/xbC8o3xAcQ4bedBNxDtRTN599cpnKAa34KudzUNagEb0i/6Nc3YQ5xall@lists.infradead.org X-Gm-Message-State: AOJu0YxCt9Uw8tGdeTJZJEPdDcMujuNLxyR4WIgvoRDiK6pjPmmVMYnu N50/YWMhUaberijO8L5NQnbTOEQQm6l35V/g8jP2JumiCMxTtq7RHRdlRJrLJQ0= X-Google-Smtp-Source: AGHT+IFALanES9BGD/uHrel10X5aoBTS5/4uaV/A+E4WAJMOHgg5/BTkzR0yFcRw4eCRtDATN+BsLQ== X-Received: by 2002:a17:907:6d0d:b0:a86:938f:e84c with SMTP id a640c23a62f3a-a86a54df8d3mr78450566b.66.1724399982571; Fri, 23 Aug 2024 00:59:42 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f48aac4sm219597466b.185.2024.08.23.00.59.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Aug 2024 00:59:42 -0700 (PDT) Message-ID: Date: Fri, 23 Aug 2024 10:59:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/16] dt-bindings: soc: renesas: renesas,rzg2l-sysc: Add #reset-cells for RZ/G3S Content-Language: en-US To: Conor Dooley Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, yoshihiro.shimoda.uh@renesas.com, biju.das.jz@bp.renesas.com, ulf.hansson@linaro.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Claudiu Beznea References: <20240822152801.602318-1-claudiu.beznea.uj@bp.renesas.com> <20240822152801.602318-3-claudiu.beznea.uj@bp.renesas.com> <20240822-vanilla-enigmatic-f0b05ecca4b6@spud> <20240822-mountain-hurdle-dd1f08b96f64@spud> From: claudiu beznea In-Reply-To: <20240822-mountain-hurdle-dd1f08b96f64@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_005944_538586_FF15413C X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22.08.2024 19:44, Conor Dooley wrote: > On Thu, Aug 22, 2024 at 05:42:57PM +0100, Conor Dooley wrote: >> On Thu, Aug 22, 2024 at 06:27:47PM +0300, Claudiu wrote: >>> From: Claudiu Beznea >>> >>> The RZ/G3S System controller has registers to control signals that need >>> to be de-asserted/asserted before/after different SoC areas are power >>> on/off. This signals are implemented as reset signals. For this document >>> the #reset-cells property. >>> >>> Signed-off-by: Claudiu Beznea >>> --- >>> .../bindings/soc/renesas/renesas,rzg2l-sysc.yaml | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >>> index 4386b2c3fa4d..6b0bb34485d9 100644 >>> --- a/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >>> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >>> @@ -42,12 +42,28 @@ properties: >>> - const: cm33stbyr_int >>> - const: ca55_deny >>> >>> + "#reset-cells": >>> + const: 1 >>> + >>> required: >>> - compatible >>> - reg >>> >>> additionalProperties: false >>> >>> +allOf: >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + const: renesas,r9a08g045-sysc >>> + then: >>> + required: >>> + - "#reset-cells" >> >> Given this is new required property on an existing platform, I'd expect >> some mention of why it used to be okay to not have this but is now >> required. Did firmware or a bootloader stage take things out of reset? > > Reading a bit more into the series, the peripherals in question were > just never used nor did a driver for the sysc exist, so there's neither Exactly. > explanation of prior behaviour nor concerns about compatibility? The newly introduced sysc driver is probed only for RZ/G3S and used to control the USB, PCIe signals though reset control driver (registered by sysc driver on auxiliary bus) and to identify the chip. The intention is to later migrate the chip identification support for the rest of RZ/G2 devices to this new driver and add more functionalities, when/if needed. Thank you, Claudiu Beznea > >> >>> + else: >>> + properties: >>> + "#reset-cells": false >>> + >>> examples: >>> - | >>> #include >>> -- >>> 2.39.2 >>> > >