From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C36CCA1013 for ; Wed, 3 Sep 2025 23:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s6a+7N6ArmIO8gfNCZN2Buz0DFgaDEocS2fUuFljnFo=; b=wLEKMBFX7nB8G+bPgWgwNpqom8 kw+qpeKNa/vIyY7qycdgp4+n6JGFfOF6YRaZLdR2XKDCh/irlh4UgI2+3C9Qdv/t7eqjCmSb/d67P p+MqdC0P6m0ebCNq7uWqhQl9kr3XOp2ZFfQianikyD0GgWjZ38kh+2DfmwHlX3YCQfqQLV8lLp/II 6y0L0nmOFu0uQYqaF3FtdT7BX1Y8FvU93OWx/o7HNYLSykfBFlIkI8aSSlqomyNsgL6mBlP2K2No6 NUtJMbGj55dJj7x561lNCKMV9pl1BfNhQzL59NzORB0YVySj4Xm1aUCWd9FEWmPXi8ILhfN/3N4r9 OAKmRCxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1utwnM-00000007u99-41SC; Wed, 03 Sep 2025 23:21:40 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uttXA-00000007UMn-301e; Wed, 03 Sep 2025 19:52:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1756929162; bh=xfQ1osEND/adCgoCa/Hw96I9E3HfyCuqMHFBC6Nm9so=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=YwOZ+rlMx3z3JPOd5ujeK9FPCcK4Fo9BggEEieTK14S1oy5PlJcuw92i/FhQsAm0S 4GL53AtFknTfuHcl0vfhe//+1rdDMRzBwzDtMn0uGu9syDu1rLRezFRQgBgFl95utR LWElPCjTxWJM10JSPL78T6XUZNAgIowdxQP/GeoB6+UOnS2EutrFrnhe+SJ7B49ZcV 3Zjz/GIiYkRAM1vl1neEeLODILGS7Azr0ZuODmXTOXxninpX14XgqcpLJE9JPgJJeD e7uPrauGbpNnR+qV+JPLkQXdeXxKE2sconu/0xc5an0sPFRUDtzuCGKs44K2FMggip fDrLmZW0kvR7g== Received: from [192.168.1.90] (unknown [82.79.138.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 75B8017E0DC8; Wed, 3 Sep 2025 21:52:41 +0200 (CEST) Message-ID: Date: Wed, 3 Sep 2025 22:52:40 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/6] Add HDMI CEC support to Rockchip RK3588/RK3576 SoCs From: Cristian Ciocaltea To: Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Dmitry Baryshkov , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Catalin Marinas , Will Deacon Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Algea Cao , Derek Foreman , Daniel Stone References: <20250903-rk3588-hdmi-cec-v4-0-fa25163c4b08@collabora.com> Content-Language: en-US In-Reply-To: <20250903-rk3588-hdmi-cec-v4-0-fa25163c4b08@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250903_125244_915605_3AC8037F X-CRM114-Status: GOOD ( 21.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Heiko, On 9/3/25 9:50 PM, Cristian Ciocaltea wrote: > The first patch in the series implements the CEC capability of the > Synopsys DesignWare HDMI QP TX controller found in RK3588 & RK3576 Socs. > This is based on the downstream code, but rewritten on top of the CEC > helpers added recently to the DRM HDMI connector framework. > > The second patch is needed for RK3576 in order to fixup the timer base > setup according to the actual reference clock rate, which differs > slightly from RK3588. > > The following three patches setup platform data with the new information > expected by the HDMI QP transmitter library, while improving the error > handling in the probe path. > > Please note the CEC helpers were affected by a resource deallocation > issue which could crash the kernel and freeze the system under certain > test conditions. This has been already fixed in v6.17-rc1 via commit > 19920ab98e17 ("drm/display: hdmi-cec-helper: Fix adapter > unregistration"). > > Signed-off-by: Cristian Ciocaltea > --- > Changes in v4: > - Fixed the bisect-related issues reported by Daniel by implementing > the following operations in dw_hdmi_qp_bind(): > * Disable CEC support when the related IRQ is not available > * Set ref_clk_rate to vendor default in case it was not provided by > the platform driver > * In both scenarios, also print a warning message to highlight the > need for fixing the platform driver > - Simplified dw_hdmi_qp_cec_init() a bit > * Removed the now obsolete cec->irq validation test > * Removed the superfluous error checking and logging around > devm_request_threaded_irq() call (it already handles all that) > - Collected R-b tags from Daniel > - Rebased series onto next-20250903 I forgot to mention that luckily there are no conflicts with the patches introducing the hw-specific bitfield operations in next-20250903, which this revision is based on. I verified the series still applies cleanly onto drm-misc-next, while commit ad24f6e10a5f ("drm/rockchip: dw_hdmi_qp: switch to FIELD_PREP_WM16 macro") responsible for the macro conversion can be further cherry-picked without issues on top of all that. The resulting file content of drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c is identical to what's expected after applying this patch set onto next-20250903. Regards, Cristian