From: Lukasz Luba <lukasz.luba@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: catalin.marinas@arm.com, will@kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
daniel.lezcano@linaro.org, mhiramat@kernel.org,
rui.zhang@intel.com, linux-trace-kernel@vger.kernel.org,
vschneid@redhat.com, bristot@redhat.com, mgorman@suse.de,
bsegall@google.com, rostedt@goodmis.org,
dietmar.eggemann@arm.com, juri.lelli@redhat.com,
peterz@infradead.org, mingo@redhat.com, konrad.dybcio@linaro.org,
andersson@kernel.org, agross@kernel.org, viresh.kumar@linaro.org,
sudeep.holla@arm.com, rafael@kernel.org, amit.kachhap@gmail.com,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 3/4] thermal/cpufreq: Remove arch_update_thermal_pressure()
Date: Fri, 15 Dec 2023 15:38:46 +0000 [thread overview]
Message-ID: <e034144d-fff6-490f-889f-1114a2f779c6@arm.com> (raw)
In-Reply-To: <20231212142730.998913-4-vincent.guittot@linaro.org>
On 12/12/23 14:27, Vincent Guittot wrote:
> arch_update_thermal_pressure() aims to update fast changing signal which
> should be averaged using PELT filtering before being provided to the
> scheduler which can't make smart use of fast changing signal.
> cpufreq now provides the maximum freq_qos pressure on the capacity to the
> scheduler, which includes cpufreq cooling device. Remove the call to
> arch_update_thermal_pressure() in cpufreq cooling device as this is
> handled by cpufreq_get_pressure().
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> drivers/thermal/cpufreq_cooling.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c
> index e2cc7bd30862..e77d3b44903e 100644
> --- a/drivers/thermal/cpufreq_cooling.c
> +++ b/drivers/thermal/cpufreq_cooling.c
> @@ -448,7 +448,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev,
> unsigned long state)
> {
> struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata;
> - struct cpumask *cpus;
> unsigned int frequency;
> int ret;
>
> @@ -465,8 +464,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev,
> ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency);
> if (ret >= 0) {
> cpufreq_cdev->cpufreq_state = state;
> - cpus = cpufreq_cdev->policy->related_cpus;
> - arch_update_thermal_pressure(cpus, frequency);
> ret = 0;
> }
>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-15 15:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 14:27 [PATCH 0/5] Rework system pressure interface to the scheduler Vincent Guittot
2023-12-12 14:27 ` [PATCH 1/4] cpufreq: Add a cpufreq pressure feedback for " Vincent Guittot
2023-12-13 7:17 ` Viresh Kumar
2023-12-13 8:05 ` Vincent Guittot
2023-12-14 0:41 ` Tim Chen
2023-12-14 5:36 ` Viresh Kumar
2023-12-14 5:43 ` Viresh Kumar
2023-12-14 7:57 ` Vincent Guittot
2023-12-14 9:08 ` Lukasz Luba
2023-12-14 9:40 ` Rafael J. Wysocki
2023-12-14 10:41 ` Lukasz Luba
2023-12-14 9:21 ` Lukasz Luba
2023-12-14 11:06 ` Vincent Guittot
2023-12-12 14:27 ` [PATCH 2/4] sched: Take cpufreq feedback into account Vincent Guittot
2023-12-15 16:03 ` Lukasz Luba
2023-12-12 14:27 ` [PATCH 3/4] thermal/cpufreq: Remove arch_update_thermal_pressure() Vincent Guittot
2023-12-15 15:38 ` Lukasz Luba [this message]
2023-12-12 14:27 ` [PATCH 4/4] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure Vincent Guittot
2023-12-14 8:31 ` Lukasz Luba
2023-12-14 8:36 ` Vincent Guittot
2023-12-14 8:54 ` Lukasz Luba
2023-12-14 8:54 ` Vincent Guittot
2023-12-14 8:22 ` [PATCH 0/5] Rework system pressure interface to the scheduler Lukasz Luba
2023-12-14 8:29 ` Vincent Guittot
2023-12-14 8:32 ` Lukasz Luba
2023-12-15 15:54 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e034144d-fff6-490f-889f-1114a2f779c6@arm.com \
--to=lukasz.luba@arm.com \
--cc=agross@kernel.org \
--cc=amit.kachhap@gmail.com \
--cc=andersson@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox