From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DA42C35274 for ; Fri, 15 Dec 2023 15:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:Cc:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iqd9cxQVrEDguFF5rc1p0Qmn/vFOAfsiMH3sBIdn3UE=; b=Bq/UmKJ8JeXMb4 TPTJpjp6ADqxQ3mZCFtcfrOC7LQa7F1aGUATqBQMf8TCh+3lggUWtO4Yudtfg1K5WfFavPuEFtY36 0v+uKfouE4vntiAHsYwjmvzFDys/UarQ2m7IsXE4Dq+P4qzi3QnfxKdK3eIUO6+txLPGLdr/kIU2D Of87vVu+kyrQQZ4VFCe9HEQLDAL5eczPKHZ7po9BfLJPIeyGEWW/hzCcglV4fZ9Bj7UIG0oYGj4i7 GmQWe/aLMSA4N2Z8TgVhuBOabOk/bN4NLmi8B9r33o5OegmG5YIPp/JimFX9a0HQl26FQNt+RZZEU 4olpi4YdLBEqDZTFrIiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rEAGC-003kb0-1Z; Fri, 15 Dec 2023 15:37:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rEAG8-003kZl-2X for linux-arm-kernel@lists.infradead.org; Fri, 15 Dec 2023 15:37:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B94FEC15; Fri, 15 Dec 2023 07:38:32 -0800 (PST) Received: from [10.57.85.151] (unknown [10.57.85.151]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5D6883F5A1; Fri, 15 Dec 2023 07:37:43 -0800 (PST) Message-ID: Date: Fri, 15 Dec 2023 15:38:46 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] thermal/cpufreq: Remove arch_update_thermal_pressure() Content-Language: en-US To: Vincent Guittot References: <20231212142730.998913-1-vincent.guittot@linaro.org> <20231212142730.998913-4-vincent.guittot@linaro.org> Cc: catalin.marinas@arm.com, will@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, mhiramat@kernel.org, rui.zhang@intel.com, linux-trace-kernel@vger.kernel.org, vschneid@redhat.com, bristot@redhat.com, mgorman@suse.de, bsegall@google.com, rostedt@goodmis.org, dietmar.eggemann@arm.com, juri.lelli@redhat.com, peterz@infradead.org, mingo@redhat.com, konrad.dybcio@linaro.org, andersson@kernel.org, agross@kernel.org, viresh.kumar@linaro.org, sudeep.holla@arm.com, rafael@kernel.org, amit.kachhap@gmail.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org From: Lukasz Luba In-Reply-To: <20231212142730.998913-4-vincent.guittot@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231215_073752_894787_E88A18B2 X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/12/23 14:27, Vincent Guittot wrote: > arch_update_thermal_pressure() aims to update fast changing signal which > should be averaged using PELT filtering before being provided to the > scheduler which can't make smart use of fast changing signal. > cpufreq now provides the maximum freq_qos pressure on the capacity to the > scheduler, which includes cpufreq cooling device. Remove the call to > arch_update_thermal_pressure() in cpufreq cooling device as this is > handled by cpufreq_get_pressure(). > > Signed-off-by: Vincent Guittot > --- > drivers/thermal/cpufreq_cooling.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c > index e2cc7bd30862..e77d3b44903e 100644 > --- a/drivers/thermal/cpufreq_cooling.c > +++ b/drivers/thermal/cpufreq_cooling.c > @@ -448,7 +448,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, > unsigned long state) > { > struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata; > - struct cpumask *cpus; > unsigned int frequency; > int ret; > > @@ -465,8 +464,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, > ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency); > if (ret >= 0) { > cpufreq_cdev->cpufreq_state = state; > - cpus = cpufreq_cdev->policy->related_cpus; > - arch_update_thermal_pressure(cpus, frequency); > ret = 0; > } > Reviewed-by: Lukasz Luba _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel