From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1550C636CD for ; Fri, 10 Feb 2023 15:45:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nGaVWECve/+uueKw9DzewZ6g85Lq3yhxBOO4GTWiWv8=; b=nY11aZKhGZu0Ou njHB5aMRWoVIysQNEU8E0b8taejPUSyvrgg/IP3jTSfSjGyIGiTDJvmJHlrVHdX/4G3epIn2t0grD 5eO2QkMoSjtBmPjlVJi5JUWQF5XUfB85u9bKrFRZ8vMIWEMkDryKHOL5hMdz03211r3H/pJZeNhzy ITne5sWxqj8IEPWRlTBj0mbGdilvxFzVOUcO4mHj+3OiJO8TLz6rdEj3BZG+XvZ1EqaJfiJyos9qF or/CUZS/5zFDSHr483Au4M4mhznO9BcVycK3EiPbY/O5iCHX9cTEqnp9NZv9noVYa/xDToQNgZnub LO7jtuyGm6PC7R397Z9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQVZm-006P80-SM; Fri, 10 Feb 2023 15:44:39 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQVZj-006P7L-Nu for linux-arm-kernel@lists.infradead.org; Fri, 10 Feb 2023 15:44:37 +0000 Received: by mail-ej1-x630.google.com with SMTP id lu11so16978942ejb.3 for ; Fri, 10 Feb 2023 07:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=opBAKiJAaUbXJ8f0Fh0jXM9OPqOfnIFIHrb6jeC+I0c=; b=VC2iGg+GzpJRixykUCYMZW0UfYHovv8kIa2ONla0Py2CwzwKrBta3tMIfxqZfbX1bT 5+zv35DUorBzkjOHUPF+ZTwx9awnL5X0zwwZR6OpGuWaHaldxvCliGQSefRgd1WRt+FH wQ+LciuTNLxILi9M+af0w8uwGTY5kkjdKUZ1ARZ3rk0az0NZbb2tULwtEq+wzcWkhg0g lunPMPVm7uPJZInfow9dfMMFrQiorpUmTuIi1Vi7aGxFUQBydxb4XrzKu55mSUUf/hmC /z/xcQAba9SdSPr0wRxYD6e4f0o0hS5IMMUG2NrTKyGS4s25/xLqbTn8xcJCn57S4l/z YHqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=opBAKiJAaUbXJ8f0Fh0jXM9OPqOfnIFIHrb6jeC+I0c=; b=7pqttk2Fb6OgkQeQj5uj8boebjkqrY7f4HhbqVlL/pyOQBHWFFt6CQPET3LQhQWuEy GSeZcig/knEMWLryrRp/RBRrfd/0Nccbc8hTJgv1mRN/+obvLbz7qA4dNYwdi4DJDCL3 YXy4L3+KNK5q9Xrz/TrndNhjReMFlas1KHIJTrP/2Z2zWN7FVuxBkfgkSVWInuEeCnGM RwCzGAF4YlRic5CppI+Xto+Uv3XHq8sW1pLeIPjmgtq2TfvMeVueTk3D62eF1iIYArIX 4YmOcCrj1wxndZUV6ueQMlQOISTmi7U7IOMDvEP7EykCZt/rOU64PJa0lqIEewn0aDab dITA== X-Gm-Message-State: AO0yUKXLTfwwGvSRnOXX1w4VjKxk/dhmIkscJOVOCYRirGiluXmtovlI IOJEjpvO+KmElF13WxGiedgZxQ== X-Google-Smtp-Source: AK7set9G2NFedcRvsqYyG2U+9/VJ93t/MwQNwlIRGUSVuLpenKc9AW+17f/c1lGphiIeWQp+GdJzdA== X-Received: by 2002:a17:907:6d8a:b0:88f:8a5:b4cd with SMTP id sb10-20020a1709076d8a00b0088f08a5b4cdmr21470525ejc.1.1676043872092; Fri, 10 Feb 2023 07:44:32 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id a11-20020a170906684b00b008aea5e0938esm2504211ejs.183.2023.02.10.07.44.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Feb 2023 07:44:31 -0800 (PST) Message-ID: Date: Fri, 10 Feb 2023 17:44:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 08/11] arm64: dts: qcom: sm8350-hdk: add pmic glink node Content-Language: en-GB To: Neil Armstrong , Heikki Krogerus , Greg Kroah-Hartman , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230130-topic-sm8450-upstream-pmic-glink-v2-0-71fea256474f@linaro.org> <20230130-topic-sm8450-upstream-pmic-glink-v2-8-71fea256474f@linaro.org> From: Dmitry Baryshkov In-Reply-To: <20230130-topic-sm8450-upstream-pmic-glink-v2-8-71fea256474f@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230210_074435_816896_FB8D1957 X-CRM114-Status: GOOD ( 17.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/02/2023 17:02, Neil Armstrong wrote: > Add the pmic glink node linked with the DWC3 USB controller > switched to OTG mode and tagged with usb-role-switch. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 77 ++++++++++++++++++++++++++++----- > 1 file changed, 65 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > index 54654eb75c28..28fc9a835c5d 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > @@ -31,6 +31,40 @@ hdmi_con: endpoint { > }; > }; > > + pmic-glink { > + compatible = "qcom,sm8350-pmic-glink", "qcom,pmic-glink"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + connector@0 { > + compatible = "usb-c-connector"; > + reg = <0>; > + power-role = "dual"; > + data-role = "dual"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + pmic_glink_hs_in: endpoint { > + remote-endpoint = <&usb_1_dwc3_hs>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + pmic_glink_ss_in: endpoint { > + remote-endpoint = <&usb_1_dwc3_ss>; > + }; > + }; > + }; > + }; > + }; > + > vph_pwr: vph-pwr-regulator { > compatible = "regulator-fixed"; > regulator-name = "vph_pwr"; > @@ -666,23 +700,42 @@ &usb_1 { > }; > > &usb_1_dwc3 { > - /* TODO: Define USB-C connector properly */ > - dr_mode = "peripheral"; > -}; > + dr_mode = "otg"; I could not verify UCSI / OTG on sm8350-HDK, see the GET_PDOS issue. Unless it is fixed, I suggest fixing this to "host" to get DP to work. > + usb-role-switch; > > -&usb_1_hsphy { > - status = "okay"; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > > - vdda-pll-supply = <&vreg_l5b_0p88>; > - vdda18-supply = <&vreg_l1c_1p8>; > - vdda33-supply = <&vreg_l2b_3p07>; > + port@0 { > + reg = <0>; > + > + usb_1_dwc3_hs: endpoint { > + remote-endpoint = <&pmic_glink_hs_in>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + usb_1_dwc3_ss: endpoint { > + remote-endpoint = <&pmic_glink_ss_in>; > + }; > + }; > + }; > }; > > -&usb_1_qmpphy { > - status = "okay"; > +&usb_1_dwc3 { > + dr_mode = "otg"; > + usb-role-switch; > +}; Duplicate > > - vdda-phy-supply = <&vreg_l6b_1p2>; > - vdda-pll-supply = <&vreg_l1b_0p88>; > +&usb_1_dwc3_hs { > + remote-endpoint = <&pmic_glink_hs_in>; > +}; > + > +&usb_1_dwc3_ss { > + remote-endpoint = <&pmic_glink_ss_in>; > }; > > &usb_2 { > -- With best wishes Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel