From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CBBCCA5FA5 for ; Tue, 29 Sep 2026 14:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=14lJ72vIWAnigHOp+fWNgRiWsF4V8Rz5/c4bDdh8fy8=; b=ngHpgZtUwAPYOwfyqkGwIUWJDp fGWCnTGHbbwoI2TAsNh//8xGTkTvGUhTQ0DyLowV5+lr1OLVINbdTuGi6vcY7l5TJhxWYfIsMd3zm B3pvc85Ne9/UkJAXWp4iSn9AAbCvdY9oVHoAtJn1Cs1xLVg5yaV2yVmjpxXngLejs9tV5Ch4RQ4iu 6mrCkLtIlycYkt28LAZWbHhzs6ZDGIFEEeUr3kG8hLyNx246Qf4BXsNtJd4Wkna8uYNepd5wVA7cn qDlnSF7mEJsJP76jAMcvlXTKa8PzCd969wIlGmN61rrtoYttseyguIeuZRjkkd5dMCHVG6lD0i0Rv ecDzLszg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xBZ2f-00000003oay-1BvI; Tue, 29 Sep 2026 14:42:49 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xBZ2d-00000003oaY-2Aof for linux-arm-kernel@bombadil.infradead.org; Tue, 29 Sep 2026 14:42:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=MIME-Version:Content-Transfer-Encoding :Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=14lJ72vIWAnigHOp+fWNgRiWsF4V8Rz5/c4bDdh8fy8=; b=Chiy8fPtzpllPtnfy0Xg4I0VP3 UyZDyWLPEz8uCshPqiQSd4VLZO3cPt/Q6qlysAol0043khQkVD75wbXwSVWVsDnY8St7Ac7aUwGpy ByX/yj2qxeLOxFReGUbGWrfWx8PeK9BBr5KTKRBFxT0OhHYmlUoUFrEI+vncY1z1XUAS3e9/wFeW2 4KnBX0CPZkVxZ7BTQG1U3ajBVP4yPgUauk5fJ0eEn0ReIzVpR/KzFIlLtum7RhLuQ/q8HMrDS1W5n CTdio1ZhUtC4cd83Nrd+sCDKiOmPqxdg3FHJ0ly5JIIzosGOP6uDiDTpUuZckagS2cHuKC12AeBS1 3r8Zihew==; Received: from smtp25.cstnet.cn ([159.226.251.25] helo=cstnet.cn) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1xBZ2X-00000002kUE-3PVv for linux-arm-kernel@lists.infradead.org; Tue, 29 Sep 2026 14:42:45 +0000 Received: from edelgard.fodlan.icenowy.me (unknown [112.94.101.54]) by APP-05 (Coremail) with SMTP id zQCowAC3IDtEzrtqWCqvCQ--.41306S2; Tue, 29 Sep 2026 22:42:15 +0800 (CST) Message-ID: Subject: Re: [PATCH v2 2/7] drm: verisilicon: stop using deprecated devm_drm_of_get_bridge() From: Icenowy Zheng To: Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Dave Stevenson , =?ISO-8859-1?Q?Ma=EDra?= Canal , Raspberry Pi Kernel Maintenance , Geert Uytterhoeven Cc: Arnd Bergmann , Doug Anderson , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, kernel test robot Date: Tue, 29 Sep 2026 22:42:12 +0800 In-Reply-To: <20260929-drm-fix-of_get_bridge-build-regression-v2-2-6da431d8f180@bootlin.com> References: <20260929-drm-fix-of_get_bridge-build-regression-v2-0-6da431d8f180@bootlin.com> <20260929-drm-fix-of_get_bridge-build-regression-v2-2-6da431d8f180@bootlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 MIME-Version: 1.0 X-CM-TRANSID: zQCowAC3IDtEzrtqWCqvCQ--.41306S2 X-Coremail-Antispam: 1UD129KBjvJXoWxAry7Jr15Kw43Cw1DZFWkZwb_yoWrJF1rpF 40qa98try5XrWxXw42kr4j9FyYya4Dtw4rGFWUt34Fvr1FqF4DGF1kAry5Z3W5CF17GF1r tr4DtFySv3W8Aa7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvvb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26rWj6s0DM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4 A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IE w4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMc vjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwACI402YVCY1x02628vn2kIc2xKxwCY 1x0262kKe7AKxVW8ZVWrXwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw C20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAF wI0_GFv_WrylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjx v20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2 jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJbIYCTnIWIevJa73Uj IFyTuYvjxUv4EEDUUUU X-Originating-IP: [112.94.101.54] X-CM-SenderInfo: x2kh0wp0lqwv3d6l2u1dvotugofq/ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260929_154242_964452_F0000B84 X-CRM114-Status: GOOD ( 22.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org =E5=9C=A8 2026-09-29=E4=BA=8C=E7=9A=84 15:39 +0200=EF=BC=8CLuca Ceresoli=E5= =86=99=E9=81=93=EF=BC=9A > devm_drm_of_get_bridge() is deprecated, switch to > of_drm_get_bridge_by_endpoint(). As of_drm_get_bridge_by_endpoint() > returns > a refcounted bridge, ensure it is put by using bridge.next_bridge. >=20 > Fixes build failure when CONFIG_OF is disabled. >=20 > Fixes: aa8a8c7e4641 ("drm/bridge: panel: move all code to > drm_panel.c") > Reported-by: Arnd Bergmann > Closes: > https://lore.kernel.org/r/20260928161605.2271412-1-arnd@kernel.org > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202609291109.OIsGTysr-lkp@intel.com= / > Closes: > https://lore.kernel.org/oe-kbuild-all/202609290408.BOs7sk55-lkp@intel.com= / > Signed-off-by: Luca Ceresoli Checked the code in drm_bridge.c, and it looks like the lifetime of next_bridge should be indirectly managed by devm when devm_drm_bridge_alloc() successes and the next_bridge field assigned, so the only explicit put needed here should be in the alloc failure path. Patch is: ``` Reviewed-by: Icenowy Zheng ``` >=20 > --- >=20 > Changes in v2: > - fix bridge reference leak on attach error path It should be `bridge alloc error` instead of `attach error`, but I don't know how to correct the error in the changelog, and anyway it won't be part of the final commit. Thanks, Icenowy > - mention lkp report > --- > =C2=A0drivers/gpu/drm/verisilicon/vs_bridge.c | 11 ++++++----- > =C2=A0drivers/gpu/drm/verisilicon/vs_bridge.h |=C2=A0 1 - > =C2=A02 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/gpu/drm/verisilicon/vs_bridge.c > b/drivers/gpu/drm/verisilicon/vs_bridge.c > index dc7c85b07fe3..3a5091c0ac2c 100644 > --- a/drivers/gpu/drm/verisilicon/vs_bridge.c > +++ b/drivers/gpu/drm/verisilicon/vs_bridge.c > @@ -29,7 +29,7 @@ static int vs_bridge_attach(struct drm_bridge > *bridge, > =C2=A0{ > =C2=A0 struct vs_bridge *vbridge =3D drm_bridge_to_vs_bridge(bridge); > =C2=A0 > - return drm_bridge_attach(encoder, vbridge->next_bridge, > + return drm_bridge_attach(encoder, vbridge->base.next_bridge, > =C2=A0 bridge, flags); > =C2=A0} > =C2=A0 > @@ -303,8 +303,7 @@ struct vs_bridge *vs_bridge_init(struct > drm_device *drm_dev, > =C2=A0 return NULL; > =C2=A0 } > =C2=A0 > - next =3D devm_drm_of_get_bridge(drm_dev->dev, drm_dev->dev- > >of_node, > - =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 output, intf); > + next =3D of_drm_get_bridge_by_endpoint(drm_dev->dev->of_node, > output, intf); > =C2=A0 if (IS_ERR(next)) { > =C2=A0 ret =3D PTR_ERR(next); > =C2=A0 if (ret !=3D -EPROBE_DEFER) > @@ -321,12 +320,14 @@ struct vs_bridge *vs_bridge_init(struct > drm_device *drm_dev, > =C2=A0 > =C2=A0 bridge =3D devm_drm_bridge_alloc(drm_dev->dev, struct > vs_bridge, base, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bridge_funcs); > - if (IS_ERR(bridge)) > + if (IS_ERR(bridge)) { > + drm_bridge_put(next); > =C2=A0 return ERR_PTR(PTR_ERR(bridge)); > + } > =C2=A0 > =C2=A0 bridge->crtc =3D crtc; > =C2=A0 bridge->intf =3D intf; > - bridge->next_bridge =3D next; > + bridge->base.next_bridge =3D next; > =C2=A0 > =C2=A0 if (intf =3D=3D VSDC_OUTPUT_INTERFACE_DPI) > =C2=A0 enctype =3D DRM_MODE_ENCODER_DPI; > diff --git a/drivers/gpu/drm/verisilicon/vs_bridge.h > b/drivers/gpu/drm/verisilicon/vs_bridge.h > index 70fee1749699..2b0ed94e4520 100644 > --- a/drivers/gpu/drm/verisilicon/vs_bridge.h > +++ b/drivers/gpu/drm/verisilicon/vs_bridge.h > @@ -25,7 +25,6 @@ struct vs_bridge { > =C2=A0 struct drm_connector *conn; > =C2=A0 > =C2=A0 struct vs_crtc *crtc; > - struct drm_bridge *next_bridge; > =C2=A0 enum vs_bridge_output_interface intf; > =C2=A0}; > =C2=A0