From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59F0BC433EF for ; Tue, 14 Jun 2022 13:28:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HddzReCWTECq85qsJSjQ2DCggk4k6+fL/DqEk2+Ir9k=; b=R4RyJsuUBJZ7OS RYGiZWRGvUbTcOl5EdqvB3mQqGjV8U0pvTUcb5QzN2xr7gxUUPRaOwU8quqBMV5Vt1rnYn37zU6A9 eOOruPAnsmXoiNGYzPotXv6xxCC0g7gDcu5ByLfh1wzpEj5sM4g1iqvQ831GCHkbhwINnTYwopQFE zj5Vdmu0bqZSILSULwqGtKWnxJyw1/dU53q9JnlUnMsKMY5tac/QnCPVgb+A7vAoijT6htWzG9nYn XoVGyVnfnRkRrV0LLIfDCG+iW+FnPD5aaPMiIoJ1cW84Q/tZM5wYZZ2DpD/EMgvAGF7d7oP/cXe48 oQXf3hihX40qF52QvU6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o16Zc-009kxO-L3; Tue, 14 Jun 2022 13:27:12 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o16ZY-009kvn-Gm for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 13:27:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655213226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W2Oyz5BLSx98FrfxVtN7aUrvWLBCLCwgtj+5NpCgj+w=; b=SWv5YVPsVlwzgK7nnKux5/+gzPZ4RLNX+6k0OzzoxZMTdowgmC5THQ+EoVjYoWGRGT8nQJ XRoUkOv+B+ZA1KSI8Gb1ZF5vl6lzeCK5c0s7VLsiHvBtH7A3QljQX+SXzGktnZEJWuFMoF gRlJz23dO0PWLz4UPT79h0idL6m4wmw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-615-zhjQn258P2qzAePspOB2lw-1; Tue, 14 Jun 2022 09:27:02 -0400 X-MC-Unique: zhjQn258P2qzAePspOB2lw-1 Received: by mail-wr1-f72.google.com with SMTP id v14-20020a5d610e000000b00213b51a0234so1308353wrt.11 for ; Tue, 14 Jun 2022 06:27:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=W2Oyz5BLSx98FrfxVtN7aUrvWLBCLCwgtj+5NpCgj+w=; b=wN/d7M88iDqGB89B+1/uZp8YSJgP2Uw7xcELP0kXazqHtrBYfRqzH3R8vYaFQyGoAH 7hG3fNLRIjZius5fNcDI6eN9RdxAB99N1FV6QzlekZoVRggj69BNT1tiBv0PJc3C4L7v M4Umjt77iSsLFPLOKVe2jI9CaXNOAPZFUaZuzfiTHh1GmPqdf0+Mk6tBcHgmAqPBx7/r ksGWYn25YwSu2NQUBnf4bysomwSso2so+L2bTBcVBcLWwQ9BekfUbxSB8y31qJ9WRx8l +UiVkE9n4YM/D5a9Yc39C1rnkh12CvpJWMK+0I+dkVqdI/dJatIZGHdZcCUp+OtOzo0h cg+w== X-Gm-Message-State: AOAM533uDsKqzM5SGnZ0puEGkSg1UFSFIprAZGlsku3vbZjiLJREINa6 9RfpHRNbV6EwB5qzvt72TjlIq1dh/k45GzX3ejhu0vKWZfo9kHFjJ7SWJccUyi147Qyy6dyTPKN OhmGg81imYRk3RchYBI3OTS5PoPC95hFfloc= X-Received: by 2002:a05:600c:4fc6:b0:39c:9417:a8bf with SMTP id o6-20020a05600c4fc600b0039c9417a8bfmr4190683wmq.26.1655213221620; Tue, 14 Jun 2022 06:27:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUL6zSdwc+UtaN5DgJibMH4ErsZPfi02dxbJWoJ3Zi5c+po5Kh+BGsd4b+ktM660XxQ1zceA== X-Received: by 2002:a05:600c:4fc6:b0:39c:9417:a8bf with SMTP id o6-20020a05600c4fc600b0039c9417a8bfmr4190664wmq.26.1655213221314; Tue, 14 Jun 2022 06:27:01 -0700 (PDT) Received: from [192.168.1.129] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id q14-20020adfea0e000000b00213ba4b5d94sm14235877wrm.27.2022.06.14.06.27.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jun 2022 06:27:00 -0700 (PDT) Message-ID: Date: Tue, 14 Jun 2022 15:26:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] drm/arm/hdlcd: Take over EFI framebuffer properly To: Robin Murphy , liviu.dudau@arm.com Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org References: <0f96c44b10dcd1444ad43e6027fd5c6aff34e54d.1655211704.git.robin.murphy@arm.com> From: Javier Martinez Canillas In-Reply-To: <0f96c44b10dcd1444ad43e6027fd5c6aff34e54d.1655211704.git.robin.murphy@arm.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_062708_678988_A541F02B X-CRM114-Status: GOOD ( 17.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Robin, On 6/14/22 15:04, Robin Murphy wrote: > The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0 > for some time now, which works nicely as an early framebuffer. However, > once the HDLCD driver probes and takes over the hardware, it should > take over the logical framebuffer as well, otherwise the now-defunct GOP > device hangs about and virtual console output inevitably disappears into > the wrong place most of the time. > > Signed-off-by: Robin Murphy > --- > drivers/gpu/drm/arm/hdlcd_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c > index af59077a5481..a5d04884658b 100644 > --- a/drivers/gpu/drm/arm/hdlcd_drv.c > +++ b/drivers/gpu/drm/arm/hdlcd_drv.c > @@ -331,6 +331,8 @@ static int hdlcd_drm_bind(struct device *dev) > goto err_vblank; > } > > + drm_fb_helper_remove_conflicting_framebuffers(NULL, "hdlcd", false); > + Seems you are using an older base, since this function doesn't exist anymore after commit 603dc7ed917f ("drm/aperture: Inline fbdev conflict helpers into aperture helpers"). Instead, you should use the drm_aperture_remove_framebuffers() function, i.e: + drm_aperture_remove_framebuffers(false, &hdlcd_driver); If you do that and re-spin the patch, feel free to add: Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel