From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3D6DCAC5B0 for ; Thu, 2 Oct 2025 03:56:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=75occNliO452i9JaCTKQp2DR2e3uD+1A2V3SIe+kvro=; b=1JaHqAQnPbUG5s9n7NWKQPi9Yb w1tAt1BlexrwW9DYIJtFlGfcfPahSiUFd++Y1fZkMjz4UsQT3fe6VmoC9GkaKuz8kiMlzPQ8RsgCO U5zIYC1zI7edEbR1fvgkrSH+Fajpsv01n1d1B+YZ/ZZc3Hq4fxNpiQF7a418hgBvOGsu1d9xM71L8 45sL1BgX4AvORVQroJze8gnB/Nkmr2GA7eWwM3NMmhLt7HbOU5OXqXyrYcjYVRWwgfSTwx3E+gCi/ OoNl2vjRlL87a73L7xR41lrUuB0axbr9ag8M72OBvx/kbNg0JppKQlWJZHP1rucrutAaM88hH7uuL sicKA1cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v4AQ8-00000009Z7k-1SFf; Thu, 02 Oct 2025 03:55:56 +0000 Received: from mail-northcentralusazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c105::7] helo=CH4PR04CU002.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v4AQ6-00000009Z7N-1ZvU for linux-arm-kernel@lists.infradead.org; Thu, 02 Oct 2025 03:55:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gz1gaRq9SlK4R1rhN8kHxuLQuRQYzL1F2MzXYbjHLmmWOvNnZgK9s2VSskqvWKE8Ui764D4+CdS8XqKR/dv4UP2JdJKx31B4k6KHfb9VtY6RfNP3OtVCmaAvTE0hUCiO7idxkTm/jJHVLWCtAnzgRuN2aXoCXIFFcQks6zohm+kMNRnFxLlTf6xI0UTP6YyATzg7/Cxclc6wA3KIG1QeIM5vsBSvw9unlY5ZYfn00hm/2+YAv/zkcUwKDGCM27iCNofJJNFeb2Vxsibm9MnqB2T0Ary0BR964zV6508VkCHT+v9mLLgmBIfu7yGZYaLdDiQin4RVnc8q/67QqWkEfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=75occNliO452i9JaCTKQp2DR2e3uD+1A2V3SIe+kvro=; b=h0LqEPOafT0VvjEVrtipn5NUIX6ynINrCeEMXJavDip5I3ayvNM/cx2v4j1/L7+vJKX4lwpAm0yhQNirdCVzvgLiErtU7sg+ljKouQV/bvSbPfho6aIrG894z9lcanQb+MGkNkZiYMr80wg+KT+6sIuolJhVL1ocGAGxjHic0VrSRyQELAZeRO4hlzQAzKx2hHZL2kgi3Xxl3yN+2RNjCiyI2+DUBOwd3mncGz5bphEC/lbk+P/HqWoDtciwC8HzTjwTUpDSbhpjbsIwjRmDNQYY/1Lu/dx58yrElcWiucoSpV6zY3BjJ81/VBVy6XBBk+TB/8XSl2b9NO7qgAX/hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=75occNliO452i9JaCTKQp2DR2e3uD+1A2V3SIe+kvro=; b=ViLPRqUmowFVdhgSsq4PQk3d+qvFM9FqJNdK4oS8QOPQ6LnAs4zPZiywkEic3Lj+d3tjpGFEACpKvKq5wmKKc+FtltX1NWE/d4MJ0YZB7ZECEcQxd18EYyD05TdFNgygBgqMBNXAUL3fwc2TXK7vQxiK3uMxFNHvEugM+ka+Xbm7noM3geeETSJBxhFqf9BG457YBv/j//pV9JfgffIM/xxqFNPnVxSgFtDSAIcfQ1r+BoJ0vI8G90a3aWMQjq3ldXJzpfa8V+XM8YlSKburlzPKuTOSs1mtne1MtQ83F4AjPjN36i/Ste1qXJW74XYEwnVPJ2biaX7A9QmfOvrRXA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB2667.namprd12.prod.outlook.com (2603:10b6:5:42::28) by BL1PR12MB5825.namprd12.prod.outlook.com (2603:10b6:208:394::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Thu, 2 Oct 2025 03:55:38 +0000 Received: from DM6PR12MB2667.namprd12.prod.outlook.com ([fe80::bd88:b883:813d:54a2]) by DM6PR12MB2667.namprd12.prod.outlook.com ([fe80::bd88:b883:813d:54a2%6]) with mapi id 15.20.9160.008; Thu, 2 Oct 2025 03:55:38 +0000 Message-ID: Date: Wed, 1 Oct 2025 20:55:20 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/29] ACPI / PPTT: Stop acpi_count_levels() expecting callers to clear levels To: James Morse , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Cc: D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-3-james.morse@arm.com> Content-Language: en-US From: Fenghua Yu In-Reply-To: <20250910204309.20751-3-james.morse@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR03CA0346.namprd03.prod.outlook.com (2603:10b6:a03:39c::21) To DM6PR12MB2667.namprd12.prod.outlook.com (2603:10b6:5:42::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB2667:EE_|BL1PR12MB5825:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c577789-b2b9-442a-3a2e-08de01678c23 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aHZPUnh0T2RzblNndUdUSzFiUEJnVDJpVmtaaGdFdC9pdW9FdVRxOEtNaWNX?= =?utf-8?B?b1ZDV1FZTElGM1Nna3V3VElLR2dYNFIwZVJYYUhMRFhmTXNvWjdlWHNDcEY3?= =?utf-8?B?RE9CckdPbzBXdm5jWlV2MVgxdkVBWEVERGI5M29haU0rbHAyNk5kSlJia0p5?= =?utf-8?B?SWJHSjVFVGZFWEw1azVMcDZiVFFGTUUzMlBFMmZlczNZVWIwY2NIZThmbjJj?= =?utf-8?B?UTU4Z1pEeDFham8zTFl6MXlodDdOUDdmN3RjZmo2MDFuOE5kRlRDeGhmV0Vx?= =?utf-8?B?Q1FGWmliaHNwcUpwN0lDaTNYd1ZOSUdqWk1QT29wMnVUVHdkbisrSnJ2N0x3?= =?utf-8?B?Mk9VUGxqZDNSTWttZU13ZW5Sbm5Nenc0d1duZFFoTWw2VXlrSDdsYklwWnBn?= =?utf-8?B?elpiV0NwUDN0WEdkemdTNHlGWGNBN0FoSkdiMlVRY0xEOUthM2JEc2JySTFS?= =?utf-8?B?M1htekNNWGZPTHZuUjU0MU4waFJEUkhQSitDaXFJVnpWbERReVdJT1g0RDZB?= =?utf-8?B?SmR6TGxkc1pkNFE5NnBuQldJZ2wyTGdhd0MxWS96SHdRZkxMMFEzQk1JbE03?= =?utf-8?B?TlhRL2pDZnZqcG80cFFYNW80WGNiZFZVV01jSk5STlJheDJ1b2kxYjNOaEIx?= =?utf-8?B?VTlsNXVOdGg3YkVNSnFmdkoxMzRCWHVkeUtKQXhaOXBDelZmd3llVE5EQVJK?= =?utf-8?B?ZWR2TTdKRUtjSXZBTUdoM09YRVVaWVRUMkluZUhJNENiWFNYb0k1eW5Gb1JK?= =?utf-8?B?VkRGd25veW50aUF2eWZBUXdKT3B0VC9ZN25xYWdnYUJOSUtBVzR1RXQyempG?= =?utf-8?B?Tm1wV2dQOEdKQVFkNVBvRzRickxqUnNvLzdzSUxITFFhRy8zTHMwRVRiVDdN?= =?utf-8?B?eEd1V3JvT3FYSTJlMzdTZHVJYm1iK1hETDhwcDE4OExuTlhXTnAwajdJYTRQ?= =?utf-8?B?L2g0U3NWMi95TE11eGltelZ3VngzMUoraGZEQ3BOVzB4cWFmakxEZkI0WjQ2?= =?utf-8?B?Wko5bUM3YWIrd0FmRFB2R1llUVRKa1d4WnZqamJBNi9zZWZIOGtEVTg2M1hC?= =?utf-8?B?aThMaGlCRDV5WXc4ajZuRVE1SUFHOGc3UEVJTndCVFNYb1ZZa1lyeTRzbGdn?= =?utf-8?B?RWFLMkRPekRTQ1NxUFlKaEswUUFTdmk3WkZ3VTRpVEJteHVDZTJFNFFDVDI2?= =?utf-8?B?Rng3d0V6QWpaaGhrb2hlREV6WkRhMnc1RWRGS3EvbGJGcDFQelRoSFV0cm4z?= =?utf-8?B?TlJUVm9QNnR1WjIxcDNTUjBmU3E4QUJlUWdzVEhGVFR4Q2pJUzdFSTBWaWpS?= =?utf-8?B?YUlwT0ZrQk1TUDRuRktFZ2tCbEZiTi9qWWhaT2gvYVpqUUNpUjl5djZ0TzAy?= =?utf-8?B?bVR2L0s3RGtEMnQ5UVVkempQbWpobDdjN1ZselNlTzQ0SHlZZmtiZHFGRk0x?= =?utf-8?B?NmNETDRyOHdOOTQ2VHUwVmw1UWIwMnpxSy9ZNUZSN0xweGY3MXMvOXRpMFdE?= =?utf-8?B?ZWNFa1FYYkFkWGRoR2lyZFgyWXprakZHUjJmRGRoK24wSmJoZVZJZ1V2UXp0?= =?utf-8?B?NDhYcTAyZkhsVEpjK1l2OGFnMGcrVGYvbElMMWNadkRhTzhxdmRpR3g4NEts?= =?utf-8?B?YnpDSU9JTGpiKytQTFh5VURoRHFHSkkrc2daMDdpcWRNVkYyUzBGMFRnbjdm?= =?utf-8?B?ZGdhMXg3enlpZFVWUUJRazFJV0lQR0dpTE42NldNSDBUUnR4Wm85RFJLSkdR?= =?utf-8?B?RENmTUd6a0hNS21HZWExbGVxU2JkM2FBc29PbWRFSTBuVzRwOHFlaXhoYmZo?= =?utf-8?B?ajRQY0g1NFYwZzZoeXBTWVpJUWphRUVXZGsvMXBDWS85YkNxdFFmME11YkRa?= =?utf-8?B?Zy9yNWwvRmlVMFNoWityY2h0cFdFRFRGVWVibS9mTmhrc1VwK0RPQ1RSOXlo?= =?utf-8?Q?+AJrSibb9Bm6hj+5eQtRLumbP+JYzb/L?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUdIMW8zYllrNFYrU3lleFF0RllwRHRHTjAwQlJKUnR2SHVONTBod1JyRlNm?= =?utf-8?B?SnRPUmQ5ek5YeWpFbi8zd0RGNkFRZlFtTnc4TUNJd3AzWUY0R3JrSGUrMFZi?= =?utf-8?B?czdqYkhHNDM1QlhoU1M5NWx5Y3F3d0dhU2JrRkdEaTVqU3BLQXdrd29iclVK?= =?utf-8?B?dE1XY3luL21HamhuN2xqTVRiOHlRNHBOckxGcW5BWkJPaUd0QmlwRkJKc1Nn?= =?utf-8?B?dGF4R3lveFhoM0M3Yk1XQmJTN2J1TXBURWtJSk9SNzV5cXhHbCs0RWhTalpy?= =?utf-8?B?K2hQbVlPY3BEb2M0VExWczJOdExGTHUrcnpwRDNVZTUwb3cvSmVUZk1HU1dn?= =?utf-8?B?RCtCSUVRYTJMRjBXWnl3WEh2eXp0YW9PcU5kYllxZHVpdjd1WEVSdVVMQW82?= =?utf-8?B?TGVLSUNFQUNBNnF1Wi8zaFVPcHc5UFpZTVlGUVVpMDAvR2NEVm9FelpWN25r?= =?utf-8?B?MjJuMHc5UUFCeFljaWFoVU15aGFhYzFaZDlSaHZkaysxMDFVbXJVc1gwYUwr?= =?utf-8?B?UlB2RmRENjRUSjkwNXVldG10OUZ6WU9yeHdRSG5Ma3F2M0d6amFMaVlPUWVP?= =?utf-8?B?OGFvSmxQSWdqbGJDNmZZYVhwMjhYV0ZwbFkwdDEwL0NqQzBXbFR5OU50Ris1?= =?utf-8?B?cVF6UlBKWjV6TmxscE4wb1B3MGNzWkhQVzBXYW1URTdlOFRIKzd6RThXVE5R?= =?utf-8?B?L21IM2wvaGRnMGVaaDdDOVU2TUthUWtVaWFEOFNKVVB5NlNib2dobTRaY3B4?= =?utf-8?B?SzBwS1F1Z0NIY1dNNWRReGFPZWR3QnZkOUUzWEhNZkRoUDhUM1c4cVV2TWpt?= =?utf-8?B?R2tmaFk1TVc4bHg3WFJCRWZTR2xnSk1LSlE1ODJXUmdsVHBtTkZ6UmJCb1dF?= =?utf-8?B?Nk5XZ3lxV3JnNm9wdy9wV1JiMy9jenhsSnVGdGFoR1ZMeU1mREhyUEx1Vzh1?= =?utf-8?B?OHdYUWt3MUVHQm1QcllHcXVnVzBWV09RaVBKREh2cUJnb0VEcEc4ejJ0VUxp?= =?utf-8?B?c2tsRVJtTGdiOXFSTXBsaHJJMzVZTUltM3FuN1NGbjRTdmdUaU5oVTYrSzJp?= =?utf-8?B?aTNrcnlYUm92WElLMnlLRUVHRlNKblJuekFaYi83elRmcHdDeDJjSGJzYllo?= =?utf-8?B?a3lOTGhoc3plOUovT2JIcmZJQUFpVWw2d1NkcWZRWXRBVWhnVTlCQjFkd3Jl?= =?utf-8?B?UVRKdUk3Z21idTFCOHpYZnFRRjRQVm9SN2M4bkpCWFN0RVN6bS9SSzNkRTdP?= =?utf-8?B?TERnbm43US96UkgyQkwrYmRlNFBTcjRTZytPRGp3dmpxQTNyYlJjQjNnbzRm?= =?utf-8?B?M3UwKy9FV0dnZHRLMG9LaXh5ZmtMZnJtdlJZZW13ZktWUXFGbUpKaThvVFpL?= =?utf-8?B?RmR5L3FyRkY5Snd3Nk0wME85WnQ5OGYzUTBwNjFXR0t4MGxGTGppbHBDWGNq?= =?utf-8?B?VzBiRXppR284S0Npb1B4THBBODhFSEYxeTQxSll1a1JzNFRndXJXWW9IajlP?= =?utf-8?B?OWU5NmtnODY0NDRMbUZ6eHFzNTRxRFpPNzk1SnA3Z0FJQ0ViY252YWtkUUtw?= =?utf-8?B?Y3pEV3I4bVZna1hOUVI1ekIzNGlaM0UrQmU3TzZvZFJlS1ZJYmZmcVdlNmFq?= =?utf-8?B?Z0pJTFdVMkV6bitMQkhrdjg4cDZJTzhtRmhMNWVpdWJ3ZnFhNU9UOHd6TFFR?= =?utf-8?B?bXlvRkZrdlYrYmtYSzd0R05jVzViRVF2b3NSdm5Id3FYYXVkd3dNU1NkK01P?= =?utf-8?B?c1BwenBHWlBHS0NDTXRHRElJOWpxRUxBZ1VTcXVpdFpacThjbk5tbFpLcVd1?= =?utf-8?B?cDh2RStqa3R2TjJLWlpFUHlLUnhaYTFqdTB2bXI5WEphSWtwYU84OWpMbk5l?= =?utf-8?B?UnpIRklKc1RNQlFiWkJMT0JQSitRY1J1QlNSd1l1bmw3NThPR2MrV1Z0aEVD?= =?utf-8?B?K3NaWTdqWTROYi9BWVVIU2ZrYy8za3VMZ1dhUDQxUytOTGFEaCtKNExUSnE2?= =?utf-8?B?SmMyS3dXenlFdWozamlkVFNDVTUrekZkaERjdE0xZDhUOTBEUWt2MEtiR2p2?= =?utf-8?B?RHZUT283UkllZmIyREZFMUw1UUlZeVU5V1dXTmR0WGNSUU9PYkcrOTI2b3Y1?= =?utf-8?Q?XqPAvQv4nOj3QxEukBJ8PMnAO?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c577789-b2b9-442a-3a2e-08de01678c23 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2667.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2025 03:55:38.1418 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7szE4APyg3rw0E6ilTNU0DEENB9dhl4T2hP14h4OLCSqzPbwAb02DfWBUtqD8XeLGH8vDRS6mSY5V9seLXgeMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5825 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251001_205554_438378_F5D32C28 X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/10/25 13:42, James Morse wrote: > In acpi_count_levels(), the initial value of *levels passed by the > caller is really an implementation detail of acpi_count_levels(), so it > is unreasonable to expect the callers of this function to know what to > pass in for this parameter. The only sensible initial value is 0, > which is what the only upstream caller (acpi_get_cache_info()) passes. > > Use a local variable for the starting cache level in acpi_count_levels(), > and pass the result back to the caller via the function return value. > > Gid rid of the levels parameter, which has no remaining purpose. > > Fix acpi_get_cache_info() to match. > > Suggested-by: Jonathan Cameron > Signed-off-by: James Morse > Reviewed-by: Lorenzo Pieralisi Reviewed-by: Fenghua Yu Thanks. -Fenghua