From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B696C48BC4 for ; Fri, 16 Feb 2024 13:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T07TMSW4tD+5+qRVwJeXYbyTsDyM744qOpFwb/RrF5Y=; b=HH7bwEmo3yU3Yk 9pCnWL+fFtOdDmq70z+hRLupoqkFM3LkPY1ShiSloqgU+dAXUGbgI4T+Zn3CGjauluhobdTMmOUCJ QkKmY1habiS+P6kAPDu8DA9smoT8NrJsq/cMghb0uexIqEWt6z2tKQK7NtPd708c/oegBHwURzLgz VjmC/UH17asvJi38znKTlF4bFfEk1a2rlSuTVy6aJKwFcYIXGALyyi5lHsRTBnxwIduGj05qUHaOI tNmXbQOgxErRd8mTlfslzBkNZ63f3qOFRHPBaeMy34Gt7WTfFfGLoZvEm+nx3V9I0Oi3IlMTSiUHN Mm9VN45o770LxY1K99bA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raxy6-00000002Nrz-058r; Fri, 16 Feb 2024 13:09:30 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raxy2-00000002Nol-38i6 for linux-arm-kernel@lists.infradead.org; Fri, 16 Feb 2024 13:09:28 +0000 Received: from [192.168.0.43] (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4407F6B3; Fri, 16 Feb 2024 14:09:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1708088956; bh=TwsN9C7Fo6AIvbubC96VPrwSsoOR6Erw6Vb2lFZeK7o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=J41Rqi8IrFMujJJ50z+IFzpleYkScHihTXx/xK6TGldIqiC+VrOktbDF988yEeDTY Q3On+OOaTNf7PZNfsYVUfzBwaAGhMt3cB4Er/2rWY2RJXGyhaycEQbLhj+O9uRbROC TT/GmRcN/CebTdrY4A2bv/FyGz+5w82nESEGbvWM= Message-ID: Date: Fri, 16 Feb 2024 13:09:15 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] dt-bindings: media: Add bindings for ARM mali-c55 Content-Language: en-US To: Laurent Pinchart , Conor Dooley Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jacopo.mondi@ideasonboard.com, nayden.kanchev@arm.com, robh+dt@kernel.org, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jerome.forissier@linaro.org, kieran.bingham@ideasonboard.com References: <20240214141906.245685-1-dan.scally@ideasonboard.com> <20240214141906.245685-3-dan.scally@ideasonboard.com> <20240214142825.GA7873@pendragon.ideasonboard.com> <20240214-velcro-pushy-0cbd18b23361@spud> <20240215110205.GD7873@pendragon.ideasonboard.com> From: Dan Scally Autocrypt: addr=dan.scally@ideasonboard.com; keydata= xsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW B31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove eIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq MHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX sUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU RWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1 NTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf vzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl 1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33 u4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5 IDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe kiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2 EAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg cEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm w/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi HSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7 c0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ nhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh AiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6 9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y ejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj xjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x xHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC PJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16 tPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t 8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp hyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT +49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj JwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX xGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K aL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL a/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT BQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM Res4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp vjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC FHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR du90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy xBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901 D+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM yMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt 9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1 u1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC In-Reply-To: <20240215110205.GD7873@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_050926_980487_31B105EA X-CRM114-Status: GOOD ( 25.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi both On 15/02/2024 11:02, Laurent Pinchart wrote: > On Wed, Feb 14, 2024 at 05:37:17PM +0000, Conor Dooley wrote: >> On Wed, Feb 14, 2024 at 04:28:25PM +0200, Laurent Pinchart wrote: >>> On Wed, Feb 14, 2024 at 02:19:03PM +0000, Daniel Scally wrote: >>>> Add the yaml binding for ARM's Mali-C55 Image Signal Processor. >>>> >>>> Acked-by: Nayden Kanchev >>>> Signed-off-by: Daniel Scally >>>> --- >>>> Changes in v2: >>>> >>>> - Added clocks information >>>> - Fixed the warnings raised by Rob >>>> >>>> .../bindings/media/arm,mali-c55.yaml | 77 +++++++++++++++++++ >>>> 1 file changed, 77 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/media/arm,mali-c55.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/media/arm,mali-c55.yaml b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml >>>> new file mode 100644 >>>> index 000000000000..30038cfec3a4 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml >>>> @@ -0,0 +1,77 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/media/arm,mali-c55.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: ARM Mali-C55 Image Signal Processor >>>> + >>>> +maintainers: >>>> + - Daniel Scally >>>> + - Jacopo Mondi >>>> + >>>> +properties: >>>> + compatible: >>>> + const: arm,mali-c55 >>>> + >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + interrupts: >>>> + maxItems: 1 >>>> + >>>> + clocks: >>>> + items: >>>> + - description: ISP video clock >>> I wonder if we need this clock. Granted, it's an input clock to the ISP, >>> but it's part of the input video bus. I don't expect anyone would ever >>> need to control it manually, it should be provided by the video source >>> automatically. >> I'd say that if there's a clock controller providing this clock, even if >> it is implicit in the video feed it's good to have here. Being able to >> increment the refcount on that clock would be good, even if you don't >> actually control it manually? > I don't expect there would be a clock controller to directly reference > in most cases. It depends a bit on where the clock domain crossing > between the source (often a CSI-2 receiver) and the ISP is. If it's > implemented in glue logic bundled with the ISP, which wouldn't be > described in DT as a separate node, then there's a higher chance we'll > have a clock controller for vclk. If it's implemented in the source, > vclk will just come from the source, which won't be listed as a clock > controller. > > One option would be to make this clock optional, by moving it to the end > of the clocks list, and setting > > minItems: 2 > maxItems: 3 > >>>> + - description: ISP AXI clock >>>> + - description: ISP AHB-lite clock >>> These two other clocks look good to me. >>> >>>> + >>>> + clock-names: >>>> + items: >>>> + - const: vclk >>>> + - const: aclk >>>> + - const: hclk >> Why not "video" "axi" "ahb-lite"? There's 3 useful letters between the >> tree clock names you've provided - they're all clocks, so having "clk" >> in them is just noise :) > As far as I understand, the names proposed by Dan come directly from the > IP core documentation. This is the case, but I do take Conor's point that more descriptive names might be nicer - if I'm honest I just didn't think about it particularly given "Xclk" is such a common name for them already, but having been poked into thinking about it I do agree. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel