linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Guillaume La Roque <glaroque@baylibre.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Andrew Davis <afd@ti.com>,
	vishalm@ti.com, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Nishanth Menon <nm@ti.com>,
	linux@ew.tq-group.com
Subject: Re: [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3
Date: Tue, 1 Jul 2025 20:57:52 +0200	[thread overview]
Message-ID: <e0773f0e-8d2f-4918-aaad-aab6345fdb81@baylibre.com> (raw)
In-Reply-To: <f44c7074337b79df9ad67f62acbc268acc344a23.camel@ew.tq-group.com>

Le 01/07/2025 à 16:36, Matthias Schiffer a écrit :
> On Mon, 2025-05-19 at 10:20 +0200, Guillaume La Roque wrote:
>>
>> After patch done on TI_MESSAGE_MANAGER[1] and TI_SCI_PROTOCOL[2] driver
>> select on ARCH_K3 are not needed anymore.
>> Select MAILBOX by default is not needed anymore[3],
>> PM_GENERIC_DOMAIN if PM was enabled by default so not needed.
> 
> Hi,

Hi,

> 
> what selects PM_GENERIC_DOMAIN in your configuration? linux-next fails to boot
> on our AM62x-based TQMa62xx if I don't (partially) revert this patch - I have
> not found a way to enable PM_GENERIC_DOMAIN and TI_SCI_PM_DOMAINS without
> enabling other unneeded features to pull it in.
> 
With master branch if i apply this patch and i do make ARCH=arm64 
defconfig and check in .config  both TI_SCI_PM_DOMAINS and 
PM_GENERIC_DOMAINS are enabled.
with linux-next it's same. i don't really understand link with  PM part 
in this patch and boot issue on your SOM.

I probably misunderstand something.


what is your problem exactly ?

if you can share log or link to jobs

Regards
Guillaume

> Best,
> Matthias
> 
> 
>>
>> Remove it and give possibility to enable this driver in modules.
>>
>> [1] https://lore.kernel.org/all/20180828005311.8529-1-nm@ti.com/
>> [2] https://lore.kernel.org/all/20250220-ti-firmware-v2-1-ff26883c6ce9@baylibre.com/
>> [3] https://lore.kernel.org/all/20250507135213.g6li6ufp3cosxoys@stinging/
>>
>> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
>> ---
>> Changes in v2:
>> - Remove some other config after comment from Nishanth.
>> - Link to v1: https://lore.kernel.org/r/20250504-kconfig-v1-1-ab0216f4fa98@baylibre.com
>> ---
>>   arch/arm64/Kconfig.platforms | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>> index 8b76821f190f..bf9e3d76b4c0 100644
>> --- a/arch/arm64/Kconfig.platforms
>> +++ b/arch/arm64/Kconfig.platforms
>> @@ -135,11 +135,7 @@ config ARCH_SPARX5
>>   
>>   config ARCH_K3
>>   	bool "Texas Instruments Inc. K3 multicore SoC architecture"
>> -	select PM_GENERIC_DOMAINS if PM
>> -	select MAILBOX
>>   	select SOC_TI
>> -	select TI_MESSAGE_MANAGER
>> -	select TI_SCI_PROTOCOL
>>   	select TI_K3_SOCINFO
>>   	help
>>   	  This enables support for Texas Instruments' K3 multicore SoC
>>
>> ---
>> base-commit: e8ab83e34bdc458b5cd77f201e4ed04807978fb1
>> change-id: 20250504-kconfig-68f139fbf337
>>
>> Best regards,
> 



  reply	other threads:[~2025-07-01 21:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19  8:20 [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3 Guillaume La Roque
2025-06-24 18:42 ` Vignesh Raghavendra
2025-07-01 14:36 ` Matthias Schiffer
2025-07-01 18:57   ` Guillaume La Roque [this message]
2025-07-02  7:25     ` Matthias Schiffer
2025-07-02 18:14       ` Guillaume La Roque
2025-07-03 12:28       ` Nishanth Menon
2025-07-07  9:59         ` Guillaume La Roque

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0773f0e-8d2f-4918-aaad-aab6345fdb81@baylibre.com \
    --to=glaroque@baylibre.com \
    --cc=afd@ti.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@ew.tq-group.com \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=nm@ti.com \
    --cc=vishalm@ti.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).