From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7D25C433EF for ; Fri, 18 Mar 2022 13:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V0M4s9+3L1luUzBUfNXvLQtlWxNi9MPEop+IX3kyOEQ=; b=szXDoV80VjLCSR 6Xc+QPGbo+c4fwZuCPR2pYNK36gX47IJ7L4RHFmmAvJfRraceu/a7rBEzejZn/bZnUsdg8pXwWvL7 DFv5Lm+G8iEwUrLll+YCJ+LrAJKlWmJv6+jntZzEtC2IalyYesJMuHtCYM31E+1nL8gjlsl4qgt10 pepqeCcFMCdb+EjVwKQZzHJzf6Yb5RyD4hGQ5bu3EP58poH4ykQScLLXIySwtdbS0UscX/zIMhVwv DB3YAsYH2egKVtUjU5cfvOLeV91c3eG0rxi1kM9unIsy+0zhXZVSGHNXx5kN0LMB+Q0aCyn9Llm23 6ET+bNaiv3pQNZB2VrmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVD5k-001n3b-Jp; Fri, 18 Mar 2022 13:56:32 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVD5g-001n1y-TO; Fri, 18 Mar 2022 13:56:30 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 1F1091F46053 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1647611787; bh=WW2IaA9n9cAPDlRSBj0mOwH/eH4P6GAUHKgCpdJwtmk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cpq6UFB+YPJAAY2YBpwTmpzQvUCgl7GvqK1HuV1xf3r6N3v0ler0buDb+ai0A/jHg 9Pv0tuip/gPib6cd74DG0i+AEYQlH0+7fZdItTRDaq/R53taqgnCWWf7X79s+PY+61 Q6v6agGDq8DxEmY2bgHkLk3NOdmsSEqfMlmDCBHCbpoFVdKa3/e/FwBe1SFPWMdemY RAod8cX7rzlUeBXa8cAXMFY/11pDV3hND3U+x23NGF2g2mteaPDhoa/BGn+qf7JEWL ZTNtaqYeeOgaveAUNgAT3gdOWiADOgW50bNzrFPVJHuudZPlKsz8FADZ13rGlle6Xr mCl1Of2Malo7Q== Message-ID: Date: Fri, 18 Mar 2022 14:56:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v2 1/2] dt-bindings: phy: mediatek: Add YAML schema for PCIe PHY Content-Language: en-US To: Krzysztof Kozlowski , Jianjun Wang , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Matthias Brugger , Chen-Yu Tsai Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rex-bc.chen@mediatek.com, randy.wu@mediatek.com, jieyy.yang@mediatek.com, chuanjia.liu@mediatek.com, qizhong.cheng@mediatek.com, jian.yang@mediatek.com References: <20220318095417.2016-1-jianjun.wang@mediatek.com> <20220318095417.2016-2-jianjun.wang@mediatek.com> <2e0989c3-7132-6091-5c9e-5dc8d9af22e8@collabora.com> <319cf016-55fb-dcd4-9157-ad795c8e68ff@kernel.org> From: AngeloGioacchino Del Regno In-Reply-To: <319cf016-55fb-dcd4-9157-ad795c8e68ff@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_065629_158810_ECED1309 X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 18/03/22 14:51, Krzysztof Kozlowski ha scritto: > On 18/03/2022 12:12, AngeloGioacchino Del Regno wrote: >> Il 18/03/22 10:54, Jianjun Wang ha scritto: >>> Add YAML schema documentation for PCIe PHY on MediaTek chipsets. >>> >>> Signed-off-by: Jianjun Wang >>> --- >>> .../bindings/phy/mediatek,pcie-phy.yaml | 75 +++++++++++++++++++ >>> 1 file changed, 75 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/phy/mediatek,pcie-phy.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/phy/mediatek,pcie-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,pcie-phy.yaml >>> new file mode 100644 >>> index 000000000000..868bf976568b >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/phy/mediatek,pcie-phy.yaml >>> @@ -0,0 +1,75 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/phy/mediatek,pcie-phy.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: MediaTek PCIe PHY >>> + >>> +maintainers: >>> + - Jianjun Wang >>> + >>> +description: | >>> + The PCIe PHY supports physical layer functionality for PCIe Gen3 port. >>> + >>> +properties: >>> + compatible: >>> + const: mediatek,mt8195-pcie-phy >> >> Since I don't expect this driver to be only for MT8195, but to be extended to >> support some more future MediaTek SoCs and, depending on the number of differences >> in the possible future Gen4 PHYs, even different gen's, I propose to add a generic >> compatible as const. >> >> So you'll have something like: >> >> - enum: >> - mediatek,mt8195-pcie-phy >> - const: mediatek,pcie-gen3-phy > > I am not sure if this is a good idea. How sure are you that there will > be no different PCIe Gen3 PHY not compatible with this one? > > Thanks for pointing that out, I have underestimated this option. Perhaps Jianjun may be more informed about whether my proposal is valid or not. Cheers, Angelo > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel