From: Lukasz Luba <lukasz.luba@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: catalin.marinas@arm.com, bristot@redhat.com,
linux-pm@vger.kernel.org, juri.lelli@redhat.com,
agross@kernel.org, viresh.kumar@linaro.org, rafael@kernel.org,
linux-kernel@vger.kernel.org, rui.zhang@intel.com,
dietmar.eggemann@arm.com, mgorman@suse.de,
linux-trace-kernel@vger.kernel.org, mingo@redhat.com,
peterz@infradead.org, konrad.dybcio@linaro.org,
andersson@kernel.org, rostedt@goodmis.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, bsegall@google.com,
vschneid@redhat.com, will@kernel.org, sudeep.holla@arm.com,
daniel.lezcano@linaro.org, mhiramat@kernel.org,
amit.kachhap@gmail.com
Subject: Re: [PATCH 4/4] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure
Date: Thu, 14 Dec 2023 08:54:10 +0000 [thread overview]
Message-ID: <e0b1a6a8-0163-4f7d-b876-b7a3e6c74b2e@arm.com> (raw)
In-Reply-To: <CAKfTPtDKRfF7QzwoDwkGKZ_DJS3ewBncifC37LADfNJwtQfiYA@mail.gmail.com>
On 12/14/23 08:36, Vincent Guittot wrote:
> On Thu, 14 Dec 2023 at 09:30, Lukasz Luba <lukasz.luba@arm.com> wrote:
>>
>>
>> On 12/12/23 14:27, Vincent Guittot wrote:
[snip]
>>> update_rq_clock(rq);
>>> - thermal_pressure = arch_scale_thermal_pressure(cpu_of(rq));
>>> - update_thermal_load_avg(rq_clock_thermal(rq), rq, thermal_pressure);
>>> + hw_pressure = arch_scale_hw_pressure(cpu_of(rq));
>>> + update_hw_load_avg(rq_clock_task(rq), rq, hw_pressure);
>>
>> We switch to task clock here, could you tell me why?
>> Don't we have to maintain the boot command parameter for the shift?
>
> This should have been part of the patch5 that I finally removed. IMO,
> the additional time shift with rq_clock_thermal is no more needed now
> that we have 2 separates signals
>
I didn't like the left-shift which causes the signal to converge slowly.
I rather wanted right-shift to converge (react faster), so you have my
vote for this change. Also, I agree that with the two-signal approach
this shift trick can go away now. I just worry about the dropped boot
parameter.
So, are going to send that patach5 which removes the
'sched_thermal_decay_shift' and documentation bit?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-14 8:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 14:27 [PATCH 0/5] Rework system pressure interface to the scheduler Vincent Guittot
2023-12-12 14:27 ` [PATCH 1/4] cpufreq: Add a cpufreq pressure feedback for " Vincent Guittot
2023-12-13 7:17 ` Viresh Kumar
2023-12-13 8:05 ` Vincent Guittot
2023-12-14 0:41 ` Tim Chen
2023-12-14 5:36 ` Viresh Kumar
2023-12-14 5:43 ` Viresh Kumar
2023-12-14 7:57 ` Vincent Guittot
2023-12-14 9:08 ` Lukasz Luba
2023-12-14 9:40 ` Rafael J. Wysocki
2023-12-14 10:41 ` Lukasz Luba
2023-12-14 9:21 ` Lukasz Luba
2023-12-14 11:06 ` Vincent Guittot
2023-12-12 14:27 ` [PATCH 2/4] sched: Take cpufreq feedback into account Vincent Guittot
2023-12-15 16:03 ` Lukasz Luba
2023-12-12 14:27 ` [PATCH 3/4] thermal/cpufreq: Remove arch_update_thermal_pressure() Vincent Guittot
2023-12-15 15:38 ` Lukasz Luba
2023-12-12 14:27 ` [PATCH 4/4] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure Vincent Guittot
2023-12-14 8:31 ` Lukasz Luba
2023-12-14 8:36 ` Vincent Guittot
2023-12-14 8:54 ` Lukasz Luba [this message]
2023-12-14 8:54 ` Vincent Guittot
2023-12-14 8:22 ` [PATCH 0/5] Rework system pressure interface to the scheduler Lukasz Luba
2023-12-14 8:29 ` Vincent Guittot
2023-12-14 8:32 ` Lukasz Luba
2023-12-15 15:54 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0b1a6a8-0163-4f7d-b876-b7a3e6c74b2e@arm.com \
--to=lukasz.luba@arm.com \
--cc=agross@kernel.org \
--cc=amit.kachhap@gmail.com \
--cc=andersson@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox