From: <Claudiu.Beznea@microchip.com>
To: <groeck@google.com>, <shraash@google.com>
Cc: <alexandre.belloni@bootlin.com>, <linux-kernel@vger.kernel.org>,
<Ludovic.Desroches@microchip.com>, <groeck@chromium.org>,
<lee.jones@linaro.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning
Date: Mon, 28 Feb 2022 07:36:09 +0000 [thread overview]
Message-ID: <e13337ff-508c-ff69-1ba2-70ca2b503b6e@microchip.com> (raw)
In-Reply-To: <CABXOdTcMj_=XqTnTiUmT8r585W2N2-12ddg4OGDHpwaiTp-Tjw@mail.gmail.com>
On 25.02.2022 21:00, Guenter Roeck wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Fri, Feb 25, 2022 at 2:15 AM Aashish Sharma <shraash@google.com> wrote:
>>
>> Fix this kernel test robot warning:
>>
>> drivers/mfd/atmel-flexcom.c:108:32: warning: unused
>> variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]
>>
>> The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
>> is not selected, so marking it as __maybe_unsed.
>>
>> Signed-off-by: Aashish Sharma <shraash@google.com>
>
> Reviewed-by: Guenter Roeck <groeck@google.com>
There is already [1] posted a while ago...
[1] https://lkml.org/lkml/2021/12/7/474
>
>> ---
>> drivers/mfd/atmel-flexcom.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
>> index 559eb4d352b6..33caa4fba6af 100644
>> --- a/drivers/mfd/atmel-flexcom.c
>> +++ b/drivers/mfd/atmel-flexcom.c
>> @@ -105,7 +105,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
>> return 0;
>> }
>>
>> -static const struct dev_pm_ops atmel_flexcom_pm_ops = {
>> +static const struct dev_pm_ops __maybe_unused atmel_flexcom_pm_ops = {
>> .resume_noirq = atmel_flexcom_resume_noirq,
>> };
>>
>> --
>> 2.35.1.574.g5d30c73bfb-goog
>>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-28 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 10:15 [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning Aashish Sharma
2022-02-25 19:00 ` Guenter Roeck
2022-02-28 7:36 ` Claudiu.Beznea [this message]
2022-02-28 8:15 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e13337ff-508c-ff69-1ba2-70ca2b503b6e@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shraash@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).