From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 608FCCA0EEB for ; Sun, 24 Aug 2025 18:25:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3tzmcq5UHoSp2ja0gb2/Tl5rI9IHPiQ/cyR9lEWKpio=; b=MPpsnglZoANtXGmfU9mQmSunfz Jo657CaWJkssrbpyVPgLejVe/HIb19I7kMjzMo+GpAxifSyrHVkujdhghFmWj8+h75vmB/fXFfOAQ OmRdTwZcnTusBWsGjzqzvmdj0Ea/8XokJ4So6BH2hGwOaLzbm1Jl29e/TRaNInYCGBeP+qo+g9wo5 2qjOY4RDuBgoM20PWcTkrm6jfUy6R/frsKg4D7jslhyeEL0Nbrc57WA3LSbGOwy3dM/ImUbzpwLJ5 sJ8s8vhDnJRY3e38Q1VNoEq5cjjV6Lhp5eTF2GZd+W+LNpv5SEN1qGwhQPo075uyIcnEpVJO4rw24 ipoEHXbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqFOi-00000006RVM-3D6y; Sun, 24 Aug 2025 18:24:56 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqF9V-00000006PyP-3Vr8 for linux-arm-kernel@lists.infradead.org; Sun, 24 Aug 2025 18:09:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id CEDA6601CF; Sun, 24 Aug 2025 18:09:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D56CCC4CEEB; Sun, 24 Aug 2025 18:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756058950; bh=tIb8TOaYFmDPG2l1skDR+dK6peTTauqAWzIqoeEul+s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=F4HZimzEDCxhs/tjlSR4cjBwj38UvzzONt2cA+xlCh3Bk1atrnT47m/sqAvRizXzR 7EV/dVhFUXmreDSwBtkitoAPltjvvyBUreUOqfsQWUw+x3KaZOc7JsbfTZrirlWUK+ EnXd2mMl4G5Hups2hPJ1+rdY8msSc6L27222OCIodAg+IRrdxlowiwSI5PGN6xoc8v rDe5rq+iiRtmdaLrPIZ7snLhqR0fXzexyh1OyBvrESdgnHKGNoaTpPytrbZJE0M+GM yWp4ZAI9++a3iGmtSlYjGT3VPGP+KHFsQH7N70qphpD2Zfb0o+BgFkDkQ3ySSWglYm JPfdvXK8W1Lig== Message-ID: Date: Sun, 24 Aug 2025 19:10:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] clk: samsung: add Exynos ACPM clock driver To: Tudor Ambarus , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Michael Turquette , Stephen Boyd , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com References: <20250819-acpm-clk-v1-0-6bbd97474671@linaro.org> <20250819-acpm-clk-v1-3-6bbd97474671@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20250819-acpm-clk-v1-3-6bbd97474671@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/08/2025 13:45, Tudor Ambarus wrote: > + > +static int acpm_clk_set_rate(struct clk_hw *hw, unsigned long rate, > + unsigned long parent_rate) > +{ > + struct acpm_clk *clk = to_acpm_clk(hw); > + > + return clk->handle->ops.dvfs_ops.set_rate(clk->handle, > + clk->acpm_chan_id, clk->id, rate); > +} > + > +static const struct clk_ops acpm_clk_ops = { > + .recalc_rate = acpm_clk_recalc_rate, > + .round_rate = acpm_clk_round_rate, This should be determine_rate. Check recent patchset from Brian Masney. I applied the samsung bits from it to samsung soc tree. ... > + > +static int __init acpm_clk_probe(struct platform_device *pdev) module probe for sure should not be __init. > +{ > + const struct acpm_clk_match_data *match_data; > + const struct acpm_handle *acpm_handle; > + struct clk_hw_onecell_data *clk_data; > + struct clk_hw **hws; > + struct device *dev = &pdev->dev; > + struct acpm_clk *aclks; > + unsigned int acpm_chan_id; > + int i, err, count; > + > + acpm_handle = devm_acpm_get_by_node(dev, dev->parent->of_node); > + if (IS_ERR(acpm_handle)) > + return dev_err_probe(dev, PTR_ERR(acpm_handle), > + "Failed to get acpm handle.\n"); > + > + match_data = of_device_get_match_data(dev); > + if (!match_data) > + return dev_err_probe(dev, -EINVAL, > + "Failed to get match data.\n"); > + > + count = match_data->nr_clks; > + acpm_chan_id = match_data->acpm_chan_id; > + > + clk_data = devm_kzalloc(dev, struct_size(clk_data, hws, count), > + GFP_KERNEL); > + if (!clk_data) > + return -ENOMEM; > + > + clk_data->num = count; > + hws = clk_data->hws; > + > + aclks = devm_kcalloc(dev, count, sizeof(*aclks), GFP_KERNEL); > + if (!aclks) > + return -ENOMEM; > + > + for (i = 0; i < count; i++) { > + const struct acpm_clk_variant *variant = &match_data->clks[i]; > + struct acpm_clk *aclk = &aclks[i]; > + > + hws[i] = &aclk->hw; > + > + aclk->id = variant->id; > + aclk->handle = acpm_handle; > + aclk->acpm_chan_id = acpm_chan_id; > + > + err = acpm_clk_ops_init(dev, aclk, variant->name); > + if (err) > + return dev_err_probe(dev, err, > + "Failed to register clock.\n"); > + } > + > + return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, > + clk_data); > +} > + > +#define ACPM_CLK(_id, cname) \ > + { \ > + .id = _id, \ > + .name = cname, \ > + } > + > +static const struct acpm_clk_variant gs101_acpm_clks[] __initconst = { This goes to top of the file, after struct declarations. > + ACPM_CLK(CLK_ACPM_DVFS_MIF, "mif"), > + ACPM_CLK(CLK_ACPM_DVFS_INT, "int"), > + ACPM_CLK(CLK_ACPM_DVFS_CPUCL0, "cpucl0"), > + ACPM_CLK(CLK_ACPM_DVFS_CPUCL1, "cpucl1"), > + ACPM_CLK(CLK_ACPM_DVFS_CPUCL2, "cpucl2"), > + ACPM_CLK(CLK_ACPM_DVFS_G3D, "g3d"), > + ACPM_CLK(CLK_ACPM_DVFS_G3DL2, "g3dl2"), > + ACPM_CLK(CLK_ACPM_DVFS_TPU, "tpu"), > + ACPM_CLK(CLK_ACPM_DVFS_INTCAM, "intcam"), > + ACPM_CLK(CLK_ACPM_DVFS_TNR, "tnr"), > + ACPM_CLK(CLK_ACPM_DVFS_CAM, "cam"), > + ACPM_CLK(CLK_ACPM_DVFS_MFC, "mfc"), > + ACPM_CLK(CLK_ACPM_DVFS_DISP, "disp"), > + ACPM_CLK(CLK_ACPM_DVFS_BO, "b0"), > +}; > + > +static const struct acpm_clk_match_data acpm_clk_gs101 __initconst = { Are you going to have more of such clk_match_data? More variants? > + .clks = gs101_acpm_clks, > + .nr_clks = ARRAY_SIZE(gs101_acpm_clks), > + .acpm_chan_id = 0, > +}; > + > +static const struct of_device_id acpm_clk_ids[] __initconst = { > + { > + .compatible = "google,gs101-acpm-dvfs-clocks", > + .data = &acpm_clk_gs101, > + }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, acpm_clk_ids); > + > +static struct platform_driver acpm_clk_driver __refdata = { __refdata feels wrong here. There is a long standing issue with Samsung clock drivers - I sent a patchset for that but it did failed testing. But your code is even simpler - no CLK_OFDECLARE - so why is this refdata? Best regards, Krzysztof