From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF40DC43334 for ; Wed, 20 Jul 2022 17:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ngu7zo8uXyU3I2kmyydqOPlElZFwv84XyncabNs2hyo=; b=rVjZ7/QiWepZuc 66nnWY1gp5eWe7rVHIP0P8yEVw0RSp3E27fXnflSNZbZGSAaJakXzlAl3bIX1oQuO7DqDP3m3lW9w qGU4kDfUpjpEoigws0zQ8FwXphy+3o8Czaz5vbVaHPISBrCVuNmtUYK5/v1OI4u7JI91kl7Bm+xkT B2mlHJTKRdrW9+l9PJVk4RSFExYE59RP/eSz4xkSy033NnmlYCv+xriVbqzD4qJc7sGVnPkK991+c bwduVtr2yd07K1+Cdexe8LOa64YWiGoexjuYie2JADEr4lZiuwOYZmc7+piizbsbVBDB4wTHrj0vf Z0GFwjg5iQYGDdFYWDEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEDH9-008WI3-NH; Wed, 20 Jul 2022 17:14:19 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEDH6-008WFb-OD for linux-arm-kernel@lists.infradead.org; Wed, 20 Jul 2022 17:14:18 +0000 Received: by mail-lj1-x230.google.com with SMTP id k19so3778283lji.10 for ; Wed, 20 Jul 2022 10:14:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=5RkpDfJmyBWfRHg2fVFR+/EdZ4rlvuqSFEKHbwoMbsM=; b=H+7FhV05lIhk0PGB4Z6gEALJjTiEw084oSQ2Ud8MgD/y8JOhBTo9CTroBwwYaV4KRf wo+T2+13vBg07aE5ZDkkmJIQREcaPEvxHTDK2GeS9txCcnfFeII3xhclMU7qdpgTtKpq Qv6x+YINWQAxvFegcEHp6NxYwoRPU6CirCLgAxMLhcSDQ2VkFe0yR+YwsEa4iv3KZpDf 4S8Mu6emImwTEBRYFM5m/GSpYwNK9vR4HZsbk/6xWL0+7eMGpVBpFy+QpHoXc9ERr5CT +PZtNyIhcUhtAVC3NpzD3jCYEfxQ3IWW0HE8xTYTeZoSA1ssGYiIlzIpiARAdMOO2xNu wMIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5RkpDfJmyBWfRHg2fVFR+/EdZ4rlvuqSFEKHbwoMbsM=; b=ZrVHeuyynfMiyUbmuQ4uPTfRWwK+DLbBWHyKYUW670NvLtAAJH0u6nGFDuGRAkE8FF VDWQNv4qRj+6U1s5Wby36yiPVRaaiUcUTdNWw2w2lnbZwr8u7xZurGZWDehT57oQwEeL fhaxAaXbS4MwPLZAhJ3YZEJz4UCkNfx/LFoZv+9Hp5tQocoFOVgUXi4QphXNlYKwCQVb SbENJ5v5oBVmAJxuBR4U0OCdTGfjbCHJbWj3B3KQLFnlxYwpXtQ8EI7tknBKkfKiWZLn VJE4JVccn27c11FwmJoB3i0N6LKSUzXE0PcGTWclnJU/5aqTsEJC1ia7cZYMhDp6jx8M 5lOA== X-Gm-Message-State: AJIora8/TmwfWJNnrNHXZuwqOxU1iwRDte+G/1TC/GqcEYJ4jFXmxKqL mgtWGvsGKG56TAEDVlq1qAfVYw== X-Google-Smtp-Source: AGRyM1slZ6hO/HAIyCG+31XwLnAM/4pQ8U2rWmJCFJJE6uLFgNQ5+vsUtnCPoRcx6jCpEMRuF7B7KQ== X-Received: by 2002:a2e:9ed6:0:b0:25d:5cef:72c3 with SMTP id h22-20020a2e9ed6000000b0025d5cef72c3mr16423219ljk.381.1658337255308; Wed, 20 Jul 2022 10:14:15 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id d25-20020a19e619000000b00489c7fb668dsm3901824lfh.182.2022.07.20.10.14.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jul 2022 10:14:14 -0700 (PDT) Message-ID: Date: Wed, 20 Jul 2022 19:14:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 2/6] dt-bindings: mediatek,mt6779-keypad: use unevaluatedProperties Content-Language: en-US To: Mattijs Korpershoek , Rob Herring , Krzysztof Kozlowski , Dmitry Torokhov , Matthias Brugger Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Fabien Parent , linux-arm-kernel@lists.infradead.org References: <20220720-mt8183-keypad-v1-0-ef9fc29dbff4@baylibre.com> <20220720-mt8183-keypad-v1-2-ef9fc29dbff4@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20220720-mt8183-keypad-v1-2-ef9fc29dbff4@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220720_101416_820701_862ECC02 X-CRM114-Status: UNSURE ( 9.15 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/07/2022 16:48, Mattijs Korpershoek wrote: > writing-bindings.rst states: >> - If schema includes other schema (e.g. /schemas/i2c/i2c-controller.yaml) use >> "unevaluatedProperties:false". In other cases, usually use >> "additionalProperties:false". > > mt6779-keypad includes matrix-keymap.yaml so replace additionalProperties:false > by unevaluatedProperties:false. This is not sufficient explanation. You now allow all properties from matrix-keymap.yaml, which might be desired or might be not (e.g. they are not valid for this device). Please investigate it and mention the outcome. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel