From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03457C7619A for ; Wed, 12 Apr 2023 08:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KL178NHKzYmyYvjI1MzN3Rv3hLeB4DM/FlzphpX0kgc=; b=YQ96pFpn0ryuMt rHMEMRWxeE7JwbgK6nVCK2+D0mJiewR+vgiooZSulrqyJ5hJX7hcviiEOTWKHD63tUuWlkaeWExcT bqOaOMNiquJtqh1xoBL71FBKKznMi9vqXhfDWkCiETcz64sUTBvweJbQxH0/RwZo73JS5g4BwzSZy shjDByIazfzEWx2R3gcuChv5J7Ey9pVCoBX0aQebEMrC6pTJETFUM5zfQmM46eIREW6mCe553cBe+ Pf5NCo0P4ce2uW54X4VH3kMLWNIrgrCNp7X6s9+6n45PPv/rGnBbWbI8Aa5x8BpGqwS1qpKiiGIt7 JbFuqmnwjdQyLPhS/4XQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmVdG-002DkV-2A; Wed, 12 Apr 2023 08:15:10 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmVdC-002Dk2-2t for linux-arm-kernel@lists.infradead.org; Wed, 12 Apr 2023 08:15:08 +0000 Received: by mail-ej1-x635.google.com with SMTP id qa44so26396906ejc.4 for ; Wed, 12 Apr 2023 01:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681287304; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fFt2X04+gRJHM2+VI6ttu8hA+NrhkWSLmAUSA85EMys=; b=Z6I6MrMH/lfo0t0Y0h6nvWLZnvjhnC6NwFLDT6uewKACghnLMh/GTj1v+inaNlz+Kl wZ6na2RHpYTyWT781486puPTghs6mXJXOHSICprqmvDRjdYwykvupA3XID25f/nf6F1K oUbO4bgP7K3rjUPhiLbcIDtHgLpEL9FFNzsDXZTHKUj5hE3YkoLANTGk6bH61+tEbAGR x0IDS7wMevWHc/rOtJOTKoYkVrlXH+X5akkL+HXcioyVHDYsikBJSZ17zaFwMlAtWEkD qLPqlTep0SpYlat+X9ZZOf/iVvD1wgfr1MUuns1XiI5imaP3LgX/Ls+Gfyw4UcVCQ1bR XZlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681287304; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fFt2X04+gRJHM2+VI6ttu8hA+NrhkWSLmAUSA85EMys=; b=PTYg5seqs0LlFrsdVVC0kRrvGC7VdVipQi4gTTRbxA6FCXIPxL6g1MVyH7w0ivNfPA Kvc+eVc4LZCljNZ321WU0zBOnLIJGSNZxQiD+2pfmuZPt74b3CNU0VvhsrczByyH7Jis +IqzlLWbPbOIMIUQyuZ4AhbtNHd9s5dpMmI2pVmBSU+53PoxuSAaZAt+cTybvDLsyIEs 6sYNXGVM5pM2aPbtCHmy88QGf6RdpJ/SE6yUfP++Z2VJ9/X6RtOS54Mqvs7vrDiJh/SF KtQT5ICAcwjV5/YOy8owV4a6te5UCplhyf7G1Br8kyl6XRHOI2nNX8WPuctnHcsjGtSZ nQPA== X-Gm-Message-State: AAQBX9fKwBD7X5ZeW/NvmcEKjqRFXjWXOxVDxRxFqwybvdcyJvDa4Tor dK7fPZoaRb4NvdSI/U0/TSZt6w== X-Google-Smtp-Source: AKy350YN+rstwkL7t/fiU5nlz3Ynak5pPMW0pVAEUiLlmM3URy4db0+sE67ofxpCGhmf8BuykmLBKA== X-Received: by 2002:a17:906:6494:b0:94a:653b:ba40 with SMTP id e20-20020a170906649400b0094a653bba40mr1571344ejm.15.1681287304232; Wed, 12 Apr 2023 01:15:04 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:8fa0:9989:3f72:b14f? ([2a02:810d:15c0:828:8fa0:9989:3f72:b14f]) by smtp.gmail.com with ESMTPSA id wt13-20020a170906ee8d00b0094a8115e148sm3103930ejb.87.2023.04.12.01.15.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 01:15:03 -0700 (PDT) Message-ID: Date: Wed, 12 Apr 2023 10:15:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH V2 1/3] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM Content-Language: en-US To: Souradeep Chowdhury , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rajendra Nayak References: <96601c1f9e433ef8fbc608d5ca09365b9c0d8132.1680874520.git.quic_schowdhu@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <96601c1f9e433ef8fbc608d5ca09365b9c0d8132.1680874520.git.quic_schowdhu@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_011506_945692_09C5D363 X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/04/2023 16:04, Souradeep Chowdhury wrote: > All Qualcomm bootloaders log useful timestamp information related > to bootloader stats in the IMEM region. Add the child node within > IMEM for the boot stat region containing register address and > compatible string. > > Signed-off-by: Souradeep Chowdhury > --- > .../devicetree/bindings/sram/qcom,imem.yaml | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml > index 665c06e..9998d65 100644 > --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml > +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml > @@ -26,6 +26,7 @@ properties: > - qcom,sdm845-imem > - qcom,sdx55-imem > - qcom,sdx65-imem > + - qcom,sm8450-imem > - const: syscon > - const: simple-mfd > > @@ -48,6 +49,26 @@ patternProperties: > $ref: /schemas/remoteproc/qcom,pil-info.yaml# > description: Peripheral image loader relocation region > > + "^boot-stat@[0-9a-f]+$": Konrad, Just like for RPM Master stats, didn't we want to call these just "stats"? https://lore.kernel.org/linux-arm-msm/20230405-topic-master_stats-v2-1-51c304ecb610@linaro.org/ > + type: object > + description: > + Imem region dedicated for storing timestamps related > + information regarding bootstats. Description is okay, but you ignored the rest. This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel