From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF99BC47077 for ; Tue, 16 Jan 2024 07:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C4oaC7m1fc4V29X8lsBslUyqyHsHNmVLJ53KuKRQc94=; b=ZtqpfD2dMXpfVg 77iVo5tERc8SEDX+jLezb5ub+0/vWItl3a8DxQOj3WvILZrdzTXsHaIeTyTgH1EG9HTKulkhnp9DL WZv7Uu/jAmPUkEdVg/8Ck58TftnsPZxVZbOrejyzq0p1MF904GrAUmhh8i/z2hJNawOvYccAs+Pzo ZE0ksoOT2DyOvwffHFr7rw9+NjKNKhna6mpzYwd3DgQlkU6Ghyzj50wo4JiX/uJZLXHUUX42ytcV+ f+T/nsPF7Hy9TtQwIXP7gRcRem4PdqFaiQOO0kkqRqUNvUzPiJVDPWjILZMsTaClW/YPgHKNuLRam grCiULRLRD2nfbwBF+1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rPdrD-00BDN2-1e; Tue, 16 Jan 2024 07:27:35 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rPdr9-00BDMY-2K for linux-arm-kernel@lists.infradead.org; Tue, 16 Jan 2024 07:27:33 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5542a7f1f3cso11521253a12.2 for ; Mon, 15 Jan 2024 23:27:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705390049; x=1705994849; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wuBLtt2GZSpGcO9j/EnadY8DR8roytq++vYju0CnFXo=; b=KJSeq2bJ3GzSA2SKANdn/oeAbMwA7DKyQp9lq0eNPJhQTmCuCaqsVV5c6d/fqbiEgc 3SUdhP833pebe83+cnl68QU9NvZUZNHW69KMiFGNsyuep4d6LJNTNzctIR57j+O95wvp h3xJJhLPr3dgwlGEWhzHggyEfSPWudNsDkiS/94yRKVAQo7VaObdY+P9eGY+xJ3EwXqv sGBb/06AHA37OeUXjqzlHkaWr6TZp/TMgdr/Yo/BqsWqZl+Lxl89r1DPWU4gFXKHcah+ DyGQ0LaRP6S3+pEHewuB1mBiNT8hryo8hTsCzkMkXS9ADyWRf6aKB5uWmkbg/N5BOAVc S4Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705390049; x=1705994849; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wuBLtt2GZSpGcO9j/EnadY8DR8roytq++vYju0CnFXo=; b=p+KEoS8gjOIb5mEi9tkAR2YdEkBpQcASlECzjBhQuojh3dupavmBh86/IZCwA4JOL3 o0+S9PcJ8PiPfQWwyFEt8sEqEGHpsXAM/gISmBkUM3CDHgjg1xRiWPHSCVQLJTe3tmyG +0FKEj7Dq4zOZtJZZ30dZieoKOa+7wUR1ep03axmrGxocpcI/jKu93ESMm7GWUvoVuKG 1LtH/Cy+IeB5u0N2cek3L6Atm3wsy/tKvU6lpq/hbzDGSS6PzC8clYRSyIhJ4HGkaLxy wc5AaroxPy0hcc3SeLN3QLgNrlyC6Jf76yDmwNz1KG6GpcNXWDE23VUyur2Wc0KOs4Fl iD4A== X-Gm-Message-State: AOJu0YzV28BgbA7pD/znPr/gjFUW2TvPv7IK/hEWyDe/ylyyVqE6Q9Vr R0URySQQYmHbUbbUD5kTvinSB0J1/TR9gw== X-Google-Smtp-Source: AGHT+IHdKHkIBgK6L0jIMlQ3v6xRghPzDBEX0+OVS4q0bI64XYK4k9HjphY6IR1YoqAe3wuzYlZfrQ== X-Received: by 2002:a50:ee13:0:b0:558:d5ce:dd74 with SMTP id g19-20020a50ee13000000b00558d5cedd74mr2944423eds.34.1705390049307; Mon, 15 Jan 2024 23:27:29 -0800 (PST) Received: from [192.168.1.20] ([178.197.215.66]) by smtp.gmail.com with ESMTPSA id fj23-20020a0564022b9700b00557f54cceb6sm6428657edb.4.2024.01.15.23.27.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jan 2024 23:27:28 -0800 (PST) Message-ID: Date: Tue, 16 Jan 2024 08:27:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] ARM: dts: aspeed-g6: Add I3C controller nodes Content-Language: en-US To: Delphine CC Chiu , patrick@stwcx.xyz, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20240116065050.3657049-1-Delphine_CC_Chiu@wiwynn.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240116065050.3657049-1-Delphine_CC_Chiu@wiwynn.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240115_232731_787715_9E583900 X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/01/2024 07:50, Delphine CC Chiu wrote: > Add default device tree settings for the 6 I3C controllers embedded in > the aspeed-g6 family SOCs. > > Signed-off-by: Delphine CC Chiu > --- > arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 148 ++++++++++++++++++++++++ > 1 file changed, 148 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > index c4d1faade8be..ed5021001e7f 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > @@ -13,6 +13,12 @@ / { > interrupt-parent = <&gic>; > > aliases { > + i3c0 = &i3c0; > + i3c1 = &i3c1; > + i3c2 = &i3c2; > + i3c3 = &i3c3; > + i3c4 = &i3c4; > + i3c5 = &i3c5; > i2c0 = &i2c0; > i2c1 = &i2c1; > i2c2 = &i2c2; > @@ -577,6 +583,13 @@ wdt4: watchdog@1e7850c0 { > status = "disabled"; > }; > > + i3c: bus@1e7a0000 { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x1e7a0000 0x8000>; > + }; > + > peci0: peci-controller@1e78b000 { > compatible = "aspeed,ast2600-peci"; > reg = <0x1e78b000 0x100>; > @@ -1139,3 +1152,138 @@ i2c15: i2c-bus@800 { > status = "disabled"; > }; > }; > + > +&i3c { > + i3c_global: i3cg@0 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + reg = <0x0 0x1000>; > + compatible = "aspeed,ast2600-i3c-global", "syscon"; There is no such compatible. > + }; > + > + i3c0: i3c0@2000 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Anyway, please respect DTS coding style for order of properties. Compatible is always first. > + compatible = "aspeed,ast2600-i3c", "syscon"; It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel