From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01FCCECAAA1 for ; Thu, 27 Oct 2022 18:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OWHeuZ3t03Rmt24RSRNKJvDnuL3LoYJirndgp4Ci3pI=; b=pkgJiFur0xgkdRZ1r3BloeYJ0P JpY4ISSmRJPr8120T3wCmUwwjZIEUeRwWVvJfxxqFj59XuloIpbRZE5B8H3xQ/5MCYbueHTOHrt/m TPeZykxSPkGlv9uYvOM7ucapLxURGyJrlTn58lYiXsqIQeXqYcP+BdwXBC4iA01hlNQkRpHFKSRrY LFxD4H3C98PGVhLMFhftudhcEUurVuDdx+i9N0R1vFuUD4/KccnZaop3r2QpZm0ytLvwolEcjuBD5 lp5jXCXtLbnHnk+lSe09TEAPt2TiJLypt8vPOtY+jTKj2auW+QWgtilW5R6kTWBGekSL+q0xKp4AC LsHxRRxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oo7Qv-00ETaL-FM; Thu, 27 Oct 2022 18:16:50 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oo7Qb-00ETOs-WA for linux-arm-kernel@lists.infradead.org; Thu, 27 Oct 2022 18:16:34 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 29RIGLH0037720; Thu, 27 Oct 2022 13:16:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1666894581; bh=/zj3g63JhQDHegIxQO0BLz+KSVsmlonxodsKrtWMvcg=; h=Date:Subject:To:References:From:In-Reply-To; b=lfPMG+cvYIxoBAkM0+DXQherZgSGwsW8587eLYBmme9zo/1pZdp0ikE3G8S7zzXVC 64Sn9Bd0aIN0QcrQVf8elePQQ2/TFFmGX9J8ybdc9sa4RcyRQWFEpwulUQPQ0iOq6J w+MTVAMjfeCBb+iLvJdakUtmjHtath07zeMikDXM= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 29RIGLfJ067267 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 27 Oct 2022 13:16:21 -0500 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Thu, 27 Oct 2022 13:16:21 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Thu, 27 Oct 2022 13:16:21 -0500 Received: from [10.250.35.234] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 29RIGKXe112488; Thu, 27 Oct 2022 13:16:20 -0500 Message-ID: Date: Thu, 27 Oct 2022 13:16:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 1/2] ARM: nspire: Use syscon-reboot to handle restart Content-Language: en-US To: Krzysztof Kozlowski , Arnd Bergmann , Linus Walleij , Geert Uytterhoeven , Daniel Tang , Fabian Vogt , , , References: <20221026161302.5319-1-afd@ti.com> <20221026161302.5319-2-afd@ti.com> <9314a458-0fd9-c645-bb55-5f28b961ea5f@linaro.org> From: Andrew Davis In-Reply-To: <9314a458-0fd9-c645-bb55-5f28b961ea5f@linaro.org> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221027_111630_212956_42578241 X-CRM114-Status: GOOD ( 17.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/26/22 3:17 PM, Krzysztof Kozlowski wrote: > On 26/10/2022 12:13, Andrew Davis wrote: >> Writing this bit can be handled by the syscon-reboot driver. Add the >> info to DT and remove the machine_desc version. >> >> Signed-off-by: Andrew Davis >> Reviewed-by: Linus Walleij >> --- >> arch/arm/boot/dts/nspire.dtsi | 7 +++++++ > > DTS cannot go with code. > > Additionally, this breaks people's filtering as there is no "dts" prefix > in the subject. > >> arch/arm/mach-nspire/Kconfig | 2 ++ >> arch/arm/mach-nspire/mmio.h | 3 --- >> arch/arm/mach-nspire/nspire.c | 10 ---------- >> 4 files changed, 9 insertions(+), 13 deletions(-) >> >> diff --git a/arch/arm/boot/dts/nspire.dtsi b/arch/arm/boot/dts/nspire.dtsi >> index bb240e6a3a6f..6357b803521e 100644 >> --- a/arch/arm/boot/dts/nspire.dtsi >> +++ b/arch/arm/boot/dts/nspire.dtsi >> @@ -172,7 +172,14 @@ rtc: rtc@90090000 { >> }; >> >> misc: misc@900a0000 { >> + compatible = "syscon", "simple-mfd"; > > These are not allowed on their own (need specific compatible) and you > should have warnings when running dtbs_check. > Ah, my bad, must have gotten lost in the other existing warnings. Sent v3 with the above fixes, and tried to remove some existing warnings. Thanks, Andrew > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel